summaryrefslogtreecommitdiffstats
path: root/src/com
diff options
context:
space:
mode:
authorMatthew Fritze <mfritze@google.com>2017-01-26 15:21:24 -0800
committerMatthew Fritze <mfritze@google.com>2017-02-15 00:36:25 +0000
commit46173a526536598dcbb2b0d8397985262c7190b7 (patch)
treec0e685aa3131477194c442d30e14c93274b50ebc /src/com
parent007d120c4700492cf76b75ba1c5dcbea07224cb8 (diff)
downloadpackages_apps_Settings-46173a526536598dcbb2b0d8397985262c7190b7.tar.gz
packages_apps_Settings-46173a526536598dcbb2b0d8397985262c7190b7.tar.bz2
packages_apps_Settings-46173a526536598dcbb2b0d8397985262c7190b7.zip
Remove extra IndexProviders that provided bad data.
Gesture Settings and Wireless settings were indexing duplicate results that only added complexity to Search. PowerUsageDetail was never supposed to be indexed. Bug:33701673 Test: make RunSettingsRoboTests Change-Id: I45d1fa4bd412c3418acec24f8c98eb4736f220ab
Diffstat (limited to 'src/com')
-rw-r--r--src/com/android/settings/WirelessSettings.java52
-rw-r--r--src/com/android/settings/fuelgauge/PowerUsageDetail.java15
-rw-r--r--src/com/android/settings/gestures/DoubleTapPowerPreferenceController.java10
-rw-r--r--src/com/android/settings/gestures/DoubleTapScreenPreferenceController.java10
-rw-r--r--src/com/android/settings/gestures/DoubleTwistPreferenceController.java10
-rw-r--r--src/com/android/settings/gestures/GestureSettings.java47
-rw-r--r--src/com/android/settings/gestures/PickupGesturePreferenceController.java10
-rw-r--r--src/com/android/settings/gestures/SwipeToNotificationPreferenceController.java10
8 files changed, 0 insertions, 164 deletions
diff --git a/src/com/android/settings/WirelessSettings.java b/src/com/android/settings/WirelessSettings.java
index 253ed7652d..32dc0c3571 100644
--- a/src/com/android/settings/WirelessSettings.java
+++ b/src/com/android/settings/WirelessSettings.java
@@ -216,56 +216,4 @@ public class WirelessSettings extends SettingsPreferenceFragment implements Inde
protected int getHelpResource() {
return R.string.help_url_more_networks;
}
-
- /**
- * For Search.
- */
- public static final Indexable.SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
- new BaseSearchIndexProvider() {
- @Override
- public List<SearchIndexableResource> getXmlResourcesToIndex(
- Context context, boolean enabled) {
- // Remove wireless settings from search in demo mode
- if (UserManager.isDeviceInDemoMode(context)) {
- return Collections.emptyList();
- }
- SearchIndexableResource sir = new SearchIndexableResource(context);
- sir.xmlResId = R.xml.wireless_settings;
- return Arrays.asList(sir);
- }
-
- @Override
- public List<String> getNonIndexableKeys(Context context) {
- final ArrayList<String> result = new ArrayList<String>();
-
- final UserManager um = (UserManager) context.getSystemService(
- Context.USER_SERVICE);
- final boolean isSecondaryUser = !um.isAdminUser();
- final boolean isWimaxEnabled = !isSecondaryUser
- && context.getResources().getBoolean(
- com.android.internal.R.bool.config_wimaxEnabled);
- if (!isWimaxEnabled) {
- result.add(KEY_WIMAX_SETTINGS);
- }
-
- new VpnPreferenceController(context).updateNonIndexableKeys(result);
-
- new NfcPreferenceController(context).updateNonIndexableKeys(result);
- new MobilePlanPreferenceController(context, null /* MobilePlanClickHandler */)
- .updateNonIndexableKeys(result);
- new MobileNetworkPreferenceController(context)
- .updateNonIndexableKeys(result);
-
- // Remove Airplane Mode settings if it's a stationary device such as a TV.
- new AirplaneModePreferenceController(context, null /* fragment */)
- .updateNonIndexableKeys(result);
-
- new ProxyPreferenceController(context).updateNonIndexableKeys(result);
-
- new TetherPreferenceController(context).updateNonIndexableKeys(result);
- new WifiCallingPreferenceController(context).updateNonIndexableKeys(result);
-
- return result;
- }
- };
}
diff --git a/src/com/android/settings/fuelgauge/PowerUsageDetail.java b/src/com/android/settings/fuelgauge/PowerUsageDetail.java
index b3f304a196..dace4da337 100644
--- a/src/com/android/settings/fuelgauge/PowerUsageDetail.java
+++ b/src/com/android/settings/fuelgauge/PowerUsageDetail.java
@@ -829,19 +829,4 @@ public class PowerUsageDetail extends PowerUsageBase implements Button.OnClickLi
}
}
}
-
- public static final SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
- new BaseSearchIndexProvider() {
- @Override
- public List<SearchIndexableResource> getXmlResourcesToIndex(
- Context context, boolean enabled) {
- if (!FeatureFactory.getFactory(context).getDashboardFeatureProvider(context)
- .isEnabled()) {
- return null;
- }
- final SearchIndexableResource sir = new SearchIndexableResource(context);
- sir.xmlResId = R.xml.power_usage_details;
- return Arrays.asList(sir);
- }
- };
}
diff --git a/src/com/android/settings/gestures/DoubleTapPowerPreferenceController.java b/src/com/android/settings/gestures/DoubleTapPowerPreferenceController.java
index 213259be01..d38902e50b 100644
--- a/src/com/android/settings/gestures/DoubleTapPowerPreferenceController.java
+++ b/src/com/android/settings/gestures/DoubleTapPowerPreferenceController.java
@@ -64,14 +64,4 @@ public class DoubleTapPowerPreferenceController extends GesturePreferenceControl
Settings.Secure.CAMERA_DOUBLE_TAP_POWER_GESTURE_DISABLED, 0);
return cameraDisabled == 0;
}
-
- @Override
- public ResultPayload getResultPayload() {
- ArrayMap<Integer, Boolean> valueMap = new ArrayMap<>();
- valueMap.put(0, true);
- valueMap.put(1, false);
-
- return new InlineSwitchPayload(Settings.Secure.CAMERA_DOUBLE_TAP_POWER_GESTURE_DISABLED,
- ResultPayload.SettingsSource.SECURE, valueMap);
- }
}
diff --git a/src/com/android/settings/gestures/DoubleTapScreenPreferenceController.java b/src/com/android/settings/gestures/DoubleTapScreenPreferenceController.java
index 02d8dd73b0..49e8f51758 100644
--- a/src/com/android/settings/gestures/DoubleTapScreenPreferenceController.java
+++ b/src/com/android/settings/gestures/DoubleTapScreenPreferenceController.java
@@ -70,14 +70,4 @@ public class DoubleTapScreenPreferenceController extends GesturePreferenceContro
protected boolean isSwitchPrefEnabled() {
return mAmbientConfig.pulseOnDoubleTapEnabled(mUserId);
}
-
- @Override
- public ResultPayload getResultPayload() {
- ArrayMap<Integer, Boolean> valueMap = new ArrayMap<>();
- valueMap.put(1, true);
- valueMap.put(0, false);
-
- return new InlineSwitchPayload(Settings.Secure.DOZE_PULSE_ON_DOUBLE_TAP,
- ResultPayload.SettingsSource.SECURE, valueMap);
- }
}
diff --git a/src/com/android/settings/gestures/DoubleTwistPreferenceController.java b/src/com/android/settings/gestures/DoubleTwistPreferenceController.java
index fea1c9dab1..c5174fd536 100644
--- a/src/com/android/settings/gestures/DoubleTwistPreferenceController.java
+++ b/src/com/android/settings/gestures/DoubleTwistPreferenceController.java
@@ -85,14 +85,4 @@ public class DoubleTwistPreferenceController extends GesturePreferenceController
}
return false;
}
-
- @Override
- public ResultPayload getResultPayload() {
- ArrayMap<Integer, Boolean> valueMap = new ArrayMap<>();
- valueMap.put(1, true);
- valueMap.put(0, false);
-
- return new InlineSwitchPayload(Settings.Secure.CAMERA_DOUBLE_TWIST_TO_FLIP_ENABLED,
- ResultPayload.SettingsSource.SECURE, valueMap);
- }
}
diff --git a/src/com/android/settings/gestures/GestureSettings.java b/src/com/android/settings/gestures/GestureSettings.java
index db6925e834..df8e37c78d 100644
--- a/src/com/android/settings/gestures/GestureSettings.java
+++ b/src/com/android/settings/gestures/GestureSettings.java
@@ -143,51 +143,4 @@ public class GestureSettings extends DashboardFragment {
mPreferences.add((GesturePreference) preference);
}
}
-
- public static final Indexable.SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
- new BaseSearchIndexProvider() {
- @Override
- public List<SearchIndexableResource> getXmlResourcesToIndex(Context context,
- boolean enabled) {
- ArrayList<SearchIndexableResource> result =
- new ArrayList<SearchIndexableResource>();
-
- SearchIndexableResource sir = new SearchIndexableResource(context);
- sir.xmlResId = R.xml.gesture_settings;
- result.add(sir);
-
- return result;
- }
-
- @Override
- public List<String> getNonIndexableKeys(Context context) {
- ArrayList<String> result = new ArrayList<String>();
-
- List<PreferenceController> preferenceControllers =
- getPreferenceControllers(context);
- for (PreferenceController controller : preferenceControllers) {
- controller.updateNonIndexableKeys(result);
- }
- return result;
- }
-
- @Override
- public List<PreferenceController> getPreferenceControllers(Context context) {
- List<PreferenceController> controllers = new ArrayList<>();
- AmbientDisplayConfiguration ambientConfig
- = new AmbientDisplayConfiguration(context);
-
- controllers.add(new DoubleTapPowerPreferenceController(context,
- null /* lifecycle */));
- controllers.add(new PickupGesturePreferenceController(context,
- null /* lifecycle */, ambientConfig, UserHandle.myUserId()));
- controllers.add(new DoubleTapScreenPreferenceController(context,
- null /* lifecycle */, ambientConfig, UserHandle.myUserId()));
- controllers.add(new SwipeToNotificationPreferenceController(context,
- null /* lifecycle */));
- controllers.add(new DoubleTwistPreferenceController(context,
- null /* lifecycle */));
- return controllers;
- }
- };
}
diff --git a/src/com/android/settings/gestures/PickupGesturePreferenceController.java b/src/com/android/settings/gestures/PickupGesturePreferenceController.java
index f48551e7c8..ce20f15796 100644
--- a/src/com/android/settings/gestures/PickupGesturePreferenceController.java
+++ b/src/com/android/settings/gestures/PickupGesturePreferenceController.java
@@ -70,14 +70,4 @@ public class PickupGesturePreferenceController extends GesturePreferenceControll
Settings.Secure.DOZE_PULSE_ON_PICK_UP, enabled ? 1 : 0);
return true;
}
-
- @Override
- public ResultPayload getResultPayload() {
- ArrayMap<Integer, Boolean> valueMap = new ArrayMap<>();
- valueMap.put(1, true);
- valueMap.put(0, false);
-
- return new InlineSwitchPayload(Settings.Secure.DOZE_PULSE_ON_PICK_UP,
- ResultPayload.SettingsSource.SECURE, valueMap);
- }
}
diff --git a/src/com/android/settings/gestures/SwipeToNotificationPreferenceController.java b/src/com/android/settings/gestures/SwipeToNotificationPreferenceController.java
index 67c8e142ad..22b88fc15f 100644
--- a/src/com/android/settings/gestures/SwipeToNotificationPreferenceController.java
+++ b/src/com/android/settings/gestures/SwipeToNotificationPreferenceController.java
@@ -63,14 +63,4 @@ public class SwipeToNotificationPreferenceController extends GesturePreferenceCo
Settings.Secure.SYSTEM_NAVIGATION_KEYS_ENABLED, 0)
== 1;
}
-
- @Override
- public ResultPayload getResultPayload() {
- ArrayMap<Integer, Boolean> valueMap = new ArrayMap<>();
- valueMap.put(1, true);
- valueMap.put(0, false);
-
- return new InlineSwitchPayload(Settings.Secure.SYSTEM_NAVIGATION_KEYS_ENABLED,
- ResultPayload.SettingsSource.SECURE, valueMap);
- }
}