summaryrefslogtreecommitdiffstats
path: root/src/com/android/settings/connecteddevice
diff options
context:
space:
mode:
authorLei Yu <jackqdyulei@google.com>2018-03-08 18:04:25 -0800
committerLei Yu <jackqdyulei@google.com>2018-03-21 10:46:02 -0700
commit687964cf28591b30895a087f6cd364b3a6a9c1b3 (patch)
treefd6cc34d3249ee4e5a632d04f590eb297251c87c /src/com/android/settings/connecteddevice
parent048b71a67ce80f5dc534d8e00c33084fea2dc546 (diff)
downloadpackages_apps_Settings-687964cf28591b30895a087f6cd364b3a6a9c1b3.tar.gz
packages_apps_Settings-687964cf28591b30895a087f6cd364b3a6a9c1b3.tar.bz2
packages_apps_Settings-687964cf28591b30895a087f6cd364b3a6a9c1b3.zip
Add search index provider for bt page
1. Implement the search index provider for ConnectedDeviceDashboardFragment. 2. Since in SEARCH_INDEX_DATA_PROVIDER fragment is null, so we need to pass in context to all components instead of getting it from fragment. 3. Update test for it as well as creating new shadow. Change-Id: If0aa67d5b6ca207c6b728c8355581bf414577091 Fixes: 69333961 Test: RunSettingsRoboTests
Diffstat (limited to 'src/com/android/settings/connecteddevice')
-rw-r--r--src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java38
-rw-r--r--src/com/android/settings/connecteddevice/ConnectedDeviceGroupController.java12
-rw-r--r--src/com/android/settings/connecteddevice/SavedDeviceGroupController.java10
-rw-r--r--src/com/android/settings/connecteddevice/usb/ConnectedUsbDeviceUpdater.java8
4 files changed, 45 insertions, 23 deletions
diff --git a/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java b/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java
index 8aab3cf3df..4218219533 100644
--- a/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java
+++ b/src/com/android/settings/connecteddevice/ConnectedDeviceDashboardFragment.java
@@ -26,17 +26,22 @@ import com.android.settings.dashboard.DashboardFragment;
import com.android.settings.dashboard.SummaryLoader;
import com.android.settings.nfc.NfcPreferenceController;
import com.android.settings.search.BaseSearchIndexProvider;
-import com.android.settings.search.Indexable;
import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.lifecycle.Lifecycle;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.List;
public class ConnectedDeviceDashboardFragment extends DashboardFragment {
private static final String TAG = "ConnectedDeviceFrag";
+ @VisibleForTesting
+ static final String KEY_CONNECTED_DEVICES = "connected_device_list";
+ @VisibleForTesting
+ static final String KEY_SAVED_DEVICES = "saved_device_list";
+
@Override
public int getMetricsCategory() {
return MetricsProto.MetricsEvent.SETTINGS_CONNECTED_DEVICE_CATEGORY;
@@ -59,11 +64,14 @@ public class ConnectedDeviceDashboardFragment extends DashboardFragment {
@Override
protected List<AbstractPreferenceController> createPreferenceControllers(Context context) {
- final List<AbstractPreferenceController> controllers = new ArrayList<>();
- final Lifecycle lifecycle = getLifecycle();
+ return buildPreferenceControllers(context, getLifecycle(), this);
+ }
- controllers.add(new ConnectedDeviceGroupController(this, lifecycle));
- controllers.add(new SavedDeviceGroupController(this, lifecycle));
+ private static List<AbstractPreferenceController> buildPreferenceControllers(Context context,
+ Lifecycle lifecycle, DashboardFragment dashboardFragment) {
+ final List<AbstractPreferenceController> controllers = new ArrayList<>();
+ controllers.add(new ConnectedDeviceGroupController(context, dashboardFragment, lifecycle));
+ controllers.add(new SavedDeviceGroupController(context, dashboardFragment, lifecycle));
return controllers;
}
@@ -108,18 +116,30 @@ public class ConnectedDeviceDashboardFragment extends DashboardFragment {
/**
* For Search.
*/
- //TODO(b/69333961): update the index for this new fragment
- public static final Indexable.SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
+ public static final SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER =
new BaseSearchIndexProvider() {
@Override
public List<SearchIndexableResource> getXmlResourcesToIndex(
Context context, boolean enabled) {
- return new ArrayList<>();
+ final SearchIndexableResource sir = new SearchIndexableResource(context);
+ sir.xmlResId = R.xml.connected_devices;
+ return Arrays.asList(sir);
+ }
+
+ @Override
+ public List<AbstractPreferenceController> createPreferenceControllers(Context
+ context) {
+ return buildPreferenceControllers(context, null /* lifecycle */,
+ null /* dashboardFragment */);
}
@Override
public List<String> getNonIndexableKeys(Context context) {
- return new ArrayList<>();
+ List<String> keys = super.getNonIndexableKeys(context);
+ // Disable because they show dynamic data
+ keys.add(KEY_CONNECTED_DEVICES);
+ keys.add(KEY_SAVED_DEVICES);
+ return keys;
}
};
}
diff --git a/src/com/android/settings/connecteddevice/ConnectedDeviceGroupController.java b/src/com/android/settings/connecteddevice/ConnectedDeviceGroupController.java
index c77a7358d6..731acae663 100644
--- a/src/com/android/settings/connecteddevice/ConnectedDeviceGroupController.java
+++ b/src/com/android/settings/connecteddevice/ConnectedDeviceGroupController.java
@@ -16,6 +16,7 @@
package com.android.settings.connecteddevice;
import android.content.pm.PackageManager;
+import android.content.Context;
import android.support.annotation.VisibleForTesting;
import android.support.v7.preference.Preference;
import android.support.v7.preference.PreferenceGroup;
@@ -26,8 +27,6 @@ import com.android.settings.core.BasePreferenceController;
import com.android.settings.core.PreferenceControllerMixin;
import com.android.settings.bluetooth.BluetoothDeviceUpdater;
import com.android.settings.bluetooth.ConnectedBluetoothDeviceUpdater;
-import com.android.settings.search.ResultPayload;
-import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settings.dashboard.DashboardFragment;
@@ -49,10 +48,11 @@ public class ConnectedDeviceGroupController extends BasePreferenceController
private BluetoothDeviceUpdater mBluetoothDeviceUpdater;
private ConnectedUsbDeviceUpdater mConnectedUsbDeviceUpdater;
- public ConnectedDeviceGroupController(DashboardFragment fragment, Lifecycle lifecycle) {
- super(fragment.getContext(), KEY);
- init(lifecycle, new ConnectedBluetoothDeviceUpdater(fragment, this),
- new ConnectedUsbDeviceUpdater(fragment, this));
+ public ConnectedDeviceGroupController(Context context, DashboardFragment fragment,
+ Lifecycle lifecycle) {
+ super(context, KEY);
+ init(lifecycle, new ConnectedBluetoothDeviceUpdater(context, fragment, this),
+ new ConnectedUsbDeviceUpdater(context, fragment, this));
}
@VisibleForTesting
diff --git a/src/com/android/settings/connecteddevice/SavedDeviceGroupController.java b/src/com/android/settings/connecteddevice/SavedDeviceGroupController.java
index da38d9fddb..ff21bff0dd 100644
--- a/src/com/android/settings/connecteddevice/SavedDeviceGroupController.java
+++ b/src/com/android/settings/connecteddevice/SavedDeviceGroupController.java
@@ -16,6 +16,7 @@
package com.android.settings.connecteddevice;
import android.content.pm.PackageManager;
+import android.content.Context;
import android.support.annotation.VisibleForTesting;
import android.support.v7.preference.Preference;
import android.support.v7.preference.PreferenceGroup;
@@ -26,7 +27,6 @@ import com.android.settings.bluetooth.SavedBluetoothDeviceUpdater;
import com.android.settings.core.BasePreferenceController;
import com.android.settings.core.PreferenceControllerMixin;
import com.android.settings.dashboard.DashboardFragment;
-import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnStart;
@@ -46,9 +46,11 @@ public class SavedDeviceGroupController extends BasePreferenceController
PreferenceGroup mPreferenceGroup;
private BluetoothDeviceUpdater mBluetoothDeviceUpdater;
- public SavedDeviceGroupController(DashboardFragment fragment, Lifecycle lifecycle) {
- super(fragment.getContext(), KEY);
- init(lifecycle, new SavedBluetoothDeviceUpdater(fragment, SavedDeviceGroupController.this));
+ public SavedDeviceGroupController(Context context, DashboardFragment fragment,
+ Lifecycle lifecycle) {
+ super(context, KEY);
+ init(lifecycle, new SavedBluetoothDeviceUpdater(context, fragment,
+ SavedDeviceGroupController.this));
}
@VisibleForTesting
diff --git a/src/com/android/settings/connecteddevice/usb/ConnectedUsbDeviceUpdater.java b/src/com/android/settings/connecteddevice/usb/ConnectedUsbDeviceUpdater.java
index 31910980db..b570204fba 100644
--- a/src/com/android/settings/connecteddevice/usb/ConnectedUsbDeviceUpdater.java
+++ b/src/com/android/settings/connecteddevice/usb/ConnectedUsbDeviceUpdater.java
@@ -50,18 +50,18 @@ public class ConnectedUsbDeviceUpdater {
}
};
- public ConnectedUsbDeviceUpdater(DashboardFragment fragment,
+ public ConnectedUsbDeviceUpdater(Context context, DashboardFragment fragment,
DevicePreferenceCallback devicePreferenceCallback) {
- this(fragment, devicePreferenceCallback, new UsbBackend(fragment.getContext()));
+ this(context, fragment, devicePreferenceCallback, new UsbBackend(context));
}
@VisibleForTesting
- ConnectedUsbDeviceUpdater(DashboardFragment fragment,
+ ConnectedUsbDeviceUpdater(Context context, DashboardFragment fragment,
DevicePreferenceCallback devicePreferenceCallback, UsbBackend usbBackend) {
mFragment = fragment;
mDevicePreferenceCallback = devicePreferenceCallback;
mUsbBackend = usbBackend;
- mUsbReceiver = new UsbConnectionBroadcastReceiver(fragment.getContext(),
+ mUsbReceiver = new UsbConnectionBroadcastReceiver(context,
mUsbConnectionListener, mUsbBackend);
}