diff options
author | Lorenzo Colitti <lorenzo@google.com> | 2017-05-02 12:06:32 +0900 |
---|---|---|
committer | Lorenzo Colitti <lorenzo@google.com> | 2017-06-01 12:08:41 +0900 |
commit | 0bde06cd594840fb4aa49fe1b034a3859f36c246 (patch) | |
tree | 5f86bb566c0891b7b82bb86ea0c0fd48cbb5bc31 /res/xml/wifi_network_details_fragment.xml | |
parent | 8b1926888fa39f1e9487b510204bf475a12ca970 (diff) | |
download | packages_apps_Settings-0bde06cd594840fb4aa49fe1b034a3859f36c246.tar.gz packages_apps_Settings-0bde06cd594840fb4aa49fe1b034a3859f36c246.tar.bz2 packages_apps_Settings-0bde06cd594840fb4aa49fe1b034a3859f36c246.zip |
Reduce jank in the wifi detail status page.
Currently, when anything changes, the wifi detail status page
removes and then redraws all IP address information. This causes
the whole screen to flicker. Instead, only add and remove things
when they actually change.
In order to do this, convert the IPv6 addresses from a list of
Preference objects to a single newline-separated text field.
This removes the need to keep track of addresses as they are
added and deleted, and also looks a bit better.
Also, minor correctness fixes:
- Get the gateway from the default route, not from the last route
with a non-null gateway.
- Get the IPv4 subnet mask from the IPv4 address prefix, not from
the last route with prefix length > 0.
Bug: 62171690
Test: make -j64 RunSettingsRoboTests
Test: IP information does not flicker when signal strength changes
Change-Id: Ia9f2a277e53a2800407ae327701c5b95a9eec20a
Diffstat (limited to 'res/xml/wifi_network_details_fragment.xml')
-rw-r--r-- | res/xml/wifi_network_details_fragment.xml | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/res/xml/wifi_network_details_fragment.xml b/res/xml/wifi_network_details_fragment.xml index 5d5958d534..257533f0cc 100644 --- a/res/xml/wifi_network_details_fragment.xml +++ b/res/xml/wifi_network_details_fragment.xml @@ -82,8 +82,12 @@ <!-- IPv6 Details --> <PreferenceCategory - android:key="ipv6_details_category" + android:key="ipv6_category" android:title="@string/wifi_details_ipv6_address_header" - android:selectable="false"/> + android:selectable="false"> + <Preference + android:key="ipv6_addresses" + android:selectable="false"/> + </PreferenceCategory> </PreferenceScreen> |