diff options
| author | Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> | 2009-05-08 17:28:40 +0900 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-05-08 11:03:26 +0200 |
| commit | e5299926d7459d9fa7c7f856983147817aedb10e (patch) | |
| tree | e4ea790efd6d6bb5bd41a9969b10e917f9d18678 /arch/x86/kernel/reboot.c | |
| parent | 33df4db04a79660150e1948e3296eeb451ac121b (diff) | |
| download | kernel_replicant_linux-e5299926d7459d9fa7c7f856983147817aedb10e.tar.gz kernel_replicant_linux-e5299926d7459d9fa7c7f856983147817aedb10e.tar.bz2 kernel_replicant_linux-e5299926d7459d9fa7c7f856983147817aedb10e.zip | |
x86: MCE: make cmci_discover_lock irq-safe
Lockdep reports the warning below when Li tries to offline one cpu:
[ 110.835487] =================================
[ 110.835616] [ INFO: inconsistent lock state ]
[ 110.835688] 2.6.30-rc4-00336-g8c9ed89 #52
[ 110.835757] ---------------------------------
[ 110.835828] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
[ 110.835908] swapper/0 [HC1[1]:SC0[0]:HE0:SE1] takes:
[ 110.835982] (cmci_discover_lock){?.+...}, at: [<ffffffff80236dc0>] cmci_clear+0x30/0x9b
cmci_clear() can be called via smp_call_function_single().
It is better to disable interrupt while holding cmci_discover_lock,
to turn it into an irq-safe lock - we can deadlock otherwise.
[ Impact: fix possible deadlock in the MCE code ]
Reported-by: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <4A03ED38.8000700@jp.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Reported-by: Shaohua Li<shaohua.li@intel.com>
Diffstat (limited to 'arch/x86/kernel/reboot.c')
0 files changed, 0 insertions, 0 deletions