diff options
| author | Belgin Stirbu <belginstirbu@hotmail.com> | 2020-11-23 06:22:07 +0200 |
|---|---|---|
| committer | Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> | 2020-11-23 16:56:52 +0100 |
| commit | 7c578596a1c8b83f7652b373eb147e8c8ad124cf (patch) | |
| tree | 3dc246123a7d16cb6ca0273f234b691229e345b9 /samsung-ipc/devices/i9300/i9300.c | |
| parent | 139170c1f3e47de63d584a842ea502dcd0cc86f9 (diff) | |
| download | hardware_replicant_libsamsung-ipc-7c578596a1c8b83f7652b373eb147e8c8ad124cf.tar.gz hardware_replicant_libsamsung-ipc-7c578596a1c8b83f7652b373eb147e8c8ad124cf.tar.bz2 hardware_replicant_libsamsung-ipc-7c578596a1c8b83f7652b373eb147e8c8ad124cf.zip | |
libsamsung-ipc: improve board drivers print (issue #2150)
These are the functions and their corresponding error
messages:
xmm626_kernel_smdk4412_power
-> "Powering on/off the modem failed"
xmm626_kernel_smdk4412_hci_power
-> "Powering on/off the HCI bus failed"
xmm626_kernel_smdk4412_link_control_enable
-> "Enabling/Disabling the modem link failed"
xmm626_kernel_smdk4412_link_control_active
-> "Activating/Deactivating the modem link failed"
Signed-off-by: Belgin Stirbu <belginstirbu@hotmail.com>
Acked-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Diffstat (limited to 'samsung-ipc/devices/i9300/i9300.c')
| -rw-r--r-- | samsung-ipc/devices/i9300/i9300.c | 42 |
1 files changed, 32 insertions, 10 deletions
diff --git a/samsung-ipc/devices/i9300/i9300.c b/samsung-ipc/devices/i9300/i9300.c index 85709a8..a2c2b92 100644 --- a/samsung-ipc/devices/i9300/i9300.c +++ b/samsung-ipc/devices/i9300/i9300.c @@ -85,10 +85,14 @@ int i9300_boot(struct ipc_client *client) ipc_client_log(client, "Turned the modem off"); rc = xmm626_kernel_smdk4412_power(client, modem_boot_fd, 1); - rc |= xmm626_kernel_smdk4412_hci_power(client, 1); + if (rc < 0) { + ipc_client_log(client, "Powering on the modem failed"); + goto error; + } + rc = xmm626_kernel_smdk4412_hci_power(client, 1); if (rc < 0) { - ipc_client_log(client, "Turning the modem on failed"); + ipc_client_log(client, "Powering on the HCI bus failed"); goto error; } ipc_client_log(client, "Turned the modem on"); @@ -178,12 +182,21 @@ int i9300_boot(struct ipc_client *client) rc = xmm626_kernel_smdk4412_link_control_enable(client, modem_link_fd, 0); - rc |= xmm626_kernel_smdk4412_hci_power(client, 0); - rc |= xmm626_kernel_smdk4412_link_control_active(client, modem_link_fd, - 0); + if (rc < 0) { + ipc_client_log(client, "Disabling the modem link failed"); + goto error; + } + rc = xmm626_kernel_smdk4412_hci_power(client, 0); if (rc < 0) { - ipc_client_log(client, "Turning the modem off failed"); + ipc_client_log(client, "Powering off the HCI bus failed"); + goto error; + } + + rc = xmm626_kernel_smdk4412_link_control_active(client, modem_link_fd, + 0); + if (rc < 0) { + ipc_client_log(client, "Deactivating the modem link failed"); goto error; } @@ -197,12 +210,21 @@ int i9300_boot(struct ipc_client *client) rc = xmm626_kernel_smdk4412_link_control_enable(client, modem_link_fd, 1); - rc |= xmm626_kernel_smdk4412_hci_power(client, 1); - rc |= xmm626_kernel_smdk4412_link_control_active(client, modem_link_fd, - 1); + if (rc < 0) { + ipc_client_log(client, "Enabling the modem link failed"); + goto error; + } + rc = xmm626_kernel_smdk4412_hci_power(client, 1); + if (rc < 0) { + ipc_client_log(client, "Powering on the HCI bus failed"); + goto error; + } + + rc = xmm626_kernel_smdk4412_link_control_active(client, modem_link_fd, + 1); if (rc < 0) { - ipc_client_log(client, "Turning the modem on failed"); + ipc_client_log(client, "Activating the modem link failed"); goto error; } |