summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMikhail Naganov <mnaganov@google.com>2017-10-24 14:44:43 -0700
committerMSe <mse1969@posteo.de>2018-01-10 21:53:32 +0100
commit9d0749abe3fdc6d79599b57fe3ecbe6fa1a3e990 (patch)
tree474fbda682ac230aea1898e990dfcb667cbf3346
parent7659a838bdf18762217c986035ff673a71213028 (diff)
downloadframeworks_av-9d0749abe3fdc6d79599b57fe3ecbe6fa1a3e990.tar.gz
frameworks_av-9d0749abe3fdc6d79599b57fe3ecbe6fa1a3e990.tar.bz2
frameworks_av-9d0749abe3fdc6d79599b57fe3ecbe6fa1a3e990.zip
Add EFFECT_CMD_SET_PARAM parameter checking to Preset Reverb
Bug: 67647856 Test: Added CTS tests Change-Id: I027ce8f7a1cdb8406ca423aaae7c45b6b76617f0 (cherry picked from commit ee804dfa15cc2d34e5d67a9b437cd023349d633b) CVE-2017-13202
-rw-r--r--media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
index 19892ddac3..80c8a3878f 100644
--- a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
+++ b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
@@ -1768,6 +1768,10 @@ int Reverb_setParameter (ReverbContext *pContext, void *pParam, void *pValue, in
if (param != REVERB_PARAM_PRESET) {
return -EINVAL;
}
+ if (vsize < (int)sizeof(uint16_t)) {
+ android_errorWriteLog(0x534e4554, "67647856");
+ return -EINVAL;
+ }
uint16_t preset = *(uint16_t *)pValue;
ALOGV("set REVERB_PARAM_PRESET, preset %d", preset);