summaryrefslogtreecommitdiffstats
path: root/libsysutils/src
Commit message (Collapse)AuthorAgeFilesLines
* Parse IfIndex for Netlink RTM_NEWADDR / RTM_DELADDR eventRubin Xu2018-05-161-4/+5
| | | | | | Bug: 64692591 Test: cts-tradefed run commandAndExit cts-dev -m CtsHostsideNetworkTests -t com.android.cts.net.HostsideVpnTests Change-Id: Icb2ae1264f0d2fcd285b04edd27641175dd2646f
* Include iface index in the netlink eventChenbo Feng2018-03-091-0/+6
| | | | | | | | | | | | | | | | The TrafficController inside netd also get notified when the interface on device added or removed, and it need both ifaceName and ifaceIndex information from Netlink event. Add the ifaceIndex in the event can avoid the TrafficController to run if_nametoindex again when receive the event. Bug: 30950746 Bug: 73137611 Test: new interface show up in bpf interface map. (cherry picked from commit 5e5e5e9a733d9427064f6fb0a72df9769f634d92) Change-Id: Ia3b4aeb8eff345ce7cf03ccec88f0893cfe125c0
* Don't complain that the DNSSL RA option is "unknown".Lorenzo Colitti2017-11-281-0/+2
| | | | | | | | This option isn't unknown, we just don't support it. Bug: 69778511 Test: walleye builds, boots, connects to IPv6 network Change-Id: If3a37d855f404da708fec4a7ba242ed41a493895
* Stop depending on libnl.Lorenzo Colitti2017-10-051-10/+43
| | | | | | | | | | We only use it for trivial functions. Replace them and drop the dependency. Bug: 67345547 Test: bullhead builds, boots Test: CtsOsTestCases android.os.cts.StrictModeTest passes Change-Id: I36254962284babdd1a55a32a76dd0dc92d85420c
* Remove old LOG_EVENT_* code from libsysutilsYifan Hong2017-07-112-3/+0
| | | | | | | | | | | As a side effect, this change fixes libbsysutils => liblog dependencies. LOG_EVENT_* macros are not defined for liblog.vendor. Test: BOARD_VNDK_VERSION=current mma Bug: 33241851 Bug: 63034227 Change-Id: I3df700d97481ec9aa59cf1796da1e991af28bdf5
* libsysutils: Fix vold vulnerability in FrameworkListenerNIEJuhu2017-06-201-1/+1
| | | | | | | | | | Don't release the sender socket when FrameworkListener receives a command that exceed the maximum buffer length Bug: https://issuetracker.google.com/issues/62812018 Test: manual Change-Id: I160f504f3fb902ba25fc79deb8ae7d78d811a807
* There's no longer a limit to property names.Elliott Hughes2017-02-281-37/+15
| | | | | | Bug: http://b/33926793 Test: boots Change-Id: I8554d7af74e064c114cf817f5a2ba1247fa2a2db
* fix warning: Null pointer argument in call to memory comparison functionYunlian Jiang2017-02-081-2/+4
| | | | | | | | | This fixes warning: Null pointer argument in call to memory comparison function [clang-analyzer-cplusplus.NewDeleteLeaks] Bug: None Test: The warning is gone. Change-Id: I957365184966cc1435d7e37d64f2cc6a32846ebd
* Merge "system/core: preparation to pull back interfaces from android/log.h"Mark Salyzyn2016-10-207-7/+13
|\ | | | | | | | | | | am: 27d2d49f48 Change-Id: I604bb1d4cf62636663fa92e3d14a55887dbcae23
| * system/core: preparation to pull back interfaces from android/log.hMark Salyzyn2016-10-207-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Point to log/log.h where necessary, define LOG_TAG where necessary. Accept that private/android_logger.h is suitable replacement for log/logger.h and android/log.h. Correct liblog/README Effectively a cleanup and controlled select revert of 'system/core: drop or replace log/logger.h' and 'system/core: Replace log/log.h with android/log.h'. Test: compile Bug: 30465923 Change-Id: Ic2ad157bad6f5efe2c6af293a73bb753300b17a2
* | system/core Replace cutils/log.h with android/log.h am: 66ce3e08c5Mark Salyzyn2016-09-308-48/+95
|\| | | | | | | | | | | am: eb189f147b Change-Id: I3f2b13e259d9bbb7bc714f21eab7181fa72c35bf
| * system/core Replace cutils/log.h with android/log.hMark Salyzyn2016-09-308-48/+95
| | | | | | | | | | | | | | | | | | | | | | Should use android/log.h instead of cutils/log.h as a good example to all others. Adjust header order to comply with Android Coding standards. Test: Compile Bug: 26552300 Bug: 31289077 Change-Id: I2c9cbbbd64d8dccf2d44356361d9742e4a9b9031
* | Merge "Most accept/accept4 calls in system/core don't actually want the ↵Elliott Hughes2016-08-231-10/+1
|\| | | | | | | | | | | | | | | remote address." am: 299d64144b am: 8615d79d85 Change-Id: I89aeabf6efa8217c9acd3f8a766bbd18f7e994fa
| * Merge "Most accept/accept4 calls in system/core don't actually want the ↵Elliott Hughes2016-08-231-10/+1
| |\ | | | | | | | | | | | | | | | | | | | | | remote address." am: 299d64144b Change-Id: I3fb9678dfed08f0b1d6e90e547ecae6cdcabc9a1
| | * Most accept/accept4 calls in system/core don't actually want the remote address.Elliott Hughes2016-08-231-10/+1
| | | | | | | | | | | | | | | | | | | | | So don't write the extra code for it or waste the kernel's time copying it around. Change-Id: I93de64064c2d4fe58ba5b5322cfa69bf31a76dad
* | | Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c ↵Connor O'Brien2016-08-191-3/+14
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 am: 2f78b2c3d6 am: 2b5e6d8ffc am: 2427a462c0 am: 6b155c1cc4 am: 2f16eeede6 Change-Id: I3d2fdfc10f91080ca32aa6557b13391355427edc
| * | Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c ↵Connor O'Brien2016-08-191-3/+14
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 am: 2f78b2c3d6 am: 2b5e6d8ffc am: 2427a462c0 am: 6b155c1cc4 Change-Id: Ie6c2bcee1deacb94259a6153097757674fa19251
| | * \ Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c ↵Connor O'Brien2016-08-191-3/+14
| | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 Change-Id: I61f685976803f51db9ba85729554fc14efaa4b2c
| | | * \ Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c ↵Connor O'Brien2016-08-191-3/+14
| | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb Change-Id: Ia5f46e5b9622946ca0e44fbe7399729807d2d08a
| | | | * \ Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6cConnor O'Brien2016-08-191-3/+14
| | | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 109024f74a Change-Id: Ia6e8dca36bc28d442a6e374ecf033b79176f4b93
| | | | | * \ Fix vold vulnerability in FrameworkListener am: 470484d2a2Connor O'Brien2016-08-191-3/+14
| | | | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: e9e046df6c Change-Id: I8f2452782817ddf03051af08e70ba9d4c4fa578a
| | | | | | * | Fix vold vulnerability in FrameworkListenerConnor O'Brien2016-08-191-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modify FrameworkListener to ignore commands that exceed the maximum buffer length and send an error message. Bug: 29831647 Change-Id: I9e57d1648d55af2ca0191bb47868e375ecc26950 Signed-off-by: Connor O'Brien <connoro@google.com> (cherry picked from commit baa126dc158a40bc83c17c6d428c760e5b93fb1a)
* | | | | | | | Merge "Clean up CLOEXEC in SocketListener." am: ed83cfba68Elliott Hughes2016-02-231-2/+1
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | / | | |_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | am: f5a2f6e963 * commit 'f5a2f6e963b4c82adbb129b2df460594524ebedf': Clean up CLOEXEC in SocketListener.
| * | | | | | Clean up CLOEXEC in SocketListener.Elliott Hughes2016-02-191-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I9811573a4b64ef2e38f1e4ba17158911b05a5f34
* | | | | | | Tolerate RTM_DELADDR messages from deleted interfaces.Lorenzo Colitti2016-02-161-5/+3
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When an interface is deleted (which can happen, for example, to the tun interfaces used for VPN and 464xlat), the kernel sends RTM_DELADDR messages for all its IP addresses. Currently we ignore these because we cannot fetch the interface name. Instead, pass them up with an empty interface name so that NetlinkHandler can do something useful for them, such as destroy connections on the IP addresses that are being deleted. Bug: 26976388 Change-Id: I2ced7e389228f9d665d0a87d97bd3452c8c0c98b
* / / / / / Switch from using sockaddr to sockaddr_storage.Erik Kline2015-12-071-3/+4
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | This is to ensure sufficient space is always available. Change-Id: Ifa87b93ecdc90dcacbfb24446c872344da6703d3
* | | | | Fix incorrectly sized buffer.Erik Kline2015-07-281-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also: use a more correct size type. Bug: 21562630 Bug: 21764392 Bug: 22464419 Change-Id: I9a9cf64f0481670828fac707e00196e222d0311e
* | | | | Qualify IPv6 link-local DNS servers with an interface nameErik Kline2015-06-181-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 21562630 Bug: 21764392 Change-Id: I7d271ae0f3fd92f70049017d38ccc15e3c1dda83
* | | | | Give SocketListener some FD_CLOEXEC.Jeff Sharkey2015-04-011-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sockets love FD_CLOEXEC. Bug: 19993667 Change-Id: I0d72a27e0f46b79843bb91ed48ebaf1c89484fd2
* | | | | Revert "Sigh, more vendors linking against hidden APIs."Vineeta Srivastava2015-03-201-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 31837298166e678d8e9c9fba1b30aea5abf1350f. Change-Id: I5c041d7438b64c4c258c414ca9a133075999e1b6
* | | | | Sigh, more vendors linking against hidden APIs.Jeff Sharkey2015-03-161-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | Bug: 19762346 Change-Id: I6c0823bf69e3f7e854ffea7b5483d09bb7359ff6
* | | | | Define enum class for NetlinkEvent actions.Jeff Sharkey2015-03-131-25/+13
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | This lets us use it for switch statements, and gives us stronger type safety. Change-Id: Idb3ad7098657a09f13c95dc7070611d35ede66ae
* | | | Add missing <malloc.h> and <string.h> includes.Elliott Hughes2015-01-281-0/+1
| | | | | | | | | | | | | | | | Change-Id: Ia41756e607663d056e7d2fdd7ecbec7e5841a913
* | | | Extend to receive NFLOG packets.Jeff Sharkey2015-01-152-7/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Packets captured and logged by the NFLOG target are unicast, so extend to catch and decode them. To avoid escaping issues, the raw contents are passed around as hex strings. Bug: 18335678 Change-Id: Ib7299500baa00080a1f000f9da843eb527363353
* | | | Fix formatting in 4df4dfedf6beef891d05d4e80704f5f4a594a885.Elliott Hughes2014-11-101-1/+2
| | | | | | | | | | | | | | | | Change-Id: I1ad219285cb1f4a39cfe2bdef224b78eff843317
* | | | When new error happend,then errno should be updated accordingly.Bo Huang2014-11-101-1/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise, need to keep previous errno. Reproduced steps: pre-condition: DUT support external SDcard or Usb mass storage; 1. Insert blank(no partition) SDcard or UMS to DUT; Expected result: Should prompt user with storage error. Test result: There is no notification for error. Error log: 01-01 01:06:49.239 I/fsck_msdos( 200): fsck_msdos terminated by exit(8) 01-01 01:06:49.239 E/Vold ( 200): /dev/block/vold/179:16 failed FS checks (I/O error) 01-01 01:06:49.239 D/Vold ( 200): Volume sdcard1 state changing 3 (Checking) -> 1 (Idle-Unmounted) 01-01 01:06:49.239 W/Vold ( 200): Returning OperationFailed - no handler for errno 0) Root cause analysis: 1.Volume::setState will call senBroadcase to send out state notification; 2.Finally, SocketClient::sendDataLockedv was called to sent message. In sendDataLockedv funtion, when current == iovcnt, e is 0 by default. So Vold get incorrect errno. Change-Id: Icb32a4193f02f22b5e3feaba177bc278f8f1f41b Signed-off-by: Bo Huang <bo.b.huang@intel.com>
* | | Support parsing netlink route messages.Lorenzo Colitti2014-06-211-0/+99
| | | | | | | | | | | | | | | Bug: 9180552 Change-Id: I4a36d869ac692647fb226d0912285bdf2ffcb1fa
* | | Improvements to netlink event parsing.Lorenzo Colitti2014-06-212-107/+157
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Accept that parseNetlinkMessage can only parse one netlink message, because its way of returning output is to modify its member variables (mAction, mParams, etc.). Currently, it loops through all the messages it finds, updating its member variables as it goes along, and always returns true at the end of the buffer. This has the following problems: 1. Since the function always returns true even when no messages were parsed, the caller has no way to know if parsing succeeded, and we get lots of "No subsystem found in netlink event" logs if the buffer did not contain any valid messages we were interested in. 2. If there are multiple messages in the buffer, all but the last message will be silently ignored. 3. If there are multiple messages and previous messages have more parameters than the last one, the resulting event will have a mixture of parameters from multiple messages. Instead of doing all this, change the contract to "parse the first valid message of interest in the buffer and return true, or return false if there were no such messages", and update the code and the comments accordingly. 2. Modify the caller (NetlinkListener) so it doesn't log an error when parseBinaryNetlinkMessage returns false, because this can now simply mean that we weren't interested in that particular message. parseBinaryNetlinkMessage already logs more informative errors. 3. Provide utility functions to check received message lengths and to convert message types to message names. 4. Simplify logging duplicate attributes. 5. Use the appropriate IFLA_xxx macros instead of rolling our own code to parse link state messages. 6. Move all the parsing code out to per-message-type parsing functions to order to simplify parseBinaryNetlinkMessage. Bug: 9180552 Change-Id: I6bbc2f7a104f618674dde2369c1fd5e93ea49430
* | | libsysutil: turn on -Werror (part deux)Mark Salyzyn2014-05-011-4/+3
| | | | | | | | | | | | | | | | | | - x86_64 format warnings Change-Id: I81c2702f564bcada946f6a10f34bbf34c90f766b
* | | libsysutils: turn on -WerrorMark Salyzyn2014-04-302-3/+1
| | | | | | | | | | | | | | | | | | - Deal with some -Wunused / -Wunused-variable issues Change-Id: I428a0032a8743c68c97f528d5f305ba63fee1d29
* | | logd: libsysutils: logd startup outside init environmentMark Salyzyn2014-04-171-0/+5
| | | | | | | | | | | | Change-Id: I3426b6c3eebdd0c8258e966dcaaaa2825d7a23d1
* | | set /proc/sys/net/unix/max_dgram_qlen to large valueMark Salyzyn2014-03-031-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | - init: set /proc/sys/net/unix/max_dgram_qlen to 300 - libsysutils: Add listen backlog argument to startListener - logd: set listen backlog to 300 Change-Id: Id6d37d6c937ba2d221e76258d89c9516619caeec
* | | libsysutil: frequent native crash /system/bin/voldMark Salyzyn2014-01-311-12/+24
|/ / | | | | | | | | | | | | | | | | | | | | | | regression from commit a6e965578e44f9ae5f98de822ba5decec381dffc * wrap writev with sigaction SIG_IGN SIGPIPE to emulate the send(,,,MSG_NOSIGNAL) call it had replaced. (cherry pick from commit 83fc720785c4e40f3341daf7c0bf5ee99261fee9) BUG: 12796279 Change-Id: I14363630ada79c0a5b85bb6b2afd0a1c4d5c3109
* | libsysutils: SocketListener export releaseMark Salyzyn2014-01-271-26/+50
| | | | | | | | | | | | | | | | | | | | | | | | * Foreground thread (legacy) closes connection by reporting false return value for onDataAvailable. * Background thread can choose instead to close the connection asynchronously by calling release, must return true for the onDataAvailable method. (cherry picked from commit d7ad4e409eaac53db3a9789060097b712850b337) Change-Id: I70ab37d5c22b02804aa3b4dfb26cc9b75291f8b6
* | libsysutils: Add iovec/runOnEachSocketMark Salyzyn2014-01-272-23/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketClient: * Replace sendDataLocked with sendDataLockedv which takes an iovec. * Add a version of sendData, sendDatav, which takes an iovec. * do not preserve iovec content through sendDatav SocketListener: * Add runOnEachSocket, which allows to to specify a SocketClientCommand to run individually on each socket. This allows you to do broadcast-like actions customized for each individual socket. * Client safe list reference counting for sendBroadcast & runOnEach Socket (cherry picked from commit a6e965578e44f8ae5f98de822ba5decec381d5fc) Signed-off-by: Nick Kralevich <nnk@google.com> Signed-off-by: Mark Salyzyn <salyzyn@google.com> Change-Id: I716f89c01b4cb7af900045c7e41fac1492defb06
* | libsysutils: Get rid of warningsMark Salyzyn2014-01-273-4/+7
| | | | | | | | | | | | | | | | | | - UNUSED argument warnings - Remove LOG_NDEBUG define (cherry picked from commit 696f267ff5a1e6227c2f5784dae60c190e0228b8) Change-Id: I48b0942adfdb7a46a7693e580bc6ed5a685b0d5b
* | Merge commit '536dea9d61a032e64bbe584a97463c6638ead009' into HEADThe Android Open Source Project2013-11-221-0/+1
|\| | | | | | | Change-Id: I5c469a4b738629d99d721cad7ded02d6c35f56d5
| * Switch back to subsystem "net" for netlink events.Lorenzo Colitti2013-09-031-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | The change to enable address tracking via netlink incorrectly changed the subsystem of rtnetlink events from "net" to "interface". This broke interface add/delete notifications, which come from the kernel with subsystem "net". Switch back to "net" and deal with address tracking via new action codes instead of a new subsystem. Bug: 10433320 Change-Id: Ibf30efb426949dfd02304cc1d9adb1c005a539a6
| * Get rid of an infinite loop in NetlinkEvent.cpp.Lorenzo Colitti2013-08-171-8/+7
| | | | | | | | | | | | | | Bug: 10358527 Bug: 10263310 Bug: 10232006 Change-Id: I750e4bdf2000040adf214d6a772591d7bd25b350
| * Parse IP address changes in NetlinkEvent.Lorenzo Colitti2013-08-141-1/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | This adds support for parsing RTM_NEWADDR and RTM_DELADDR netlink messages received on netd's netlink socket and formatting them them so NetlinkHandler can process them. Address changes are notified in subsystem "address". Interface changes, which used to be notified in subsystem "net", are now notified in subsystem "interface" to avoid confusion. Bug: 10232006 Change-Id: I93a50e8de17014e118a42f5cc0eb90a0cbfa73cc
generated by cgit v1.2.3 (git 2.25.1) at 2026-04-10 17:00:52 +0000