diff options
Diffstat (limited to 'adb')
-rw-r--r-- | adb/adb_unique_fd.h | 26 | ||||
-rw-r--r-- | adb/adb_utils.cpp | 5 | ||||
-rw-r--r-- | adb/adb_utils.h | 10 | ||||
-rw-r--r-- | adb/commandline.cpp | 1 | ||||
-rw-r--r-- | adb/jdwp_service.cpp | 1 | ||||
-rw-r--r-- | adb/shell_service.cpp | 1 |
6 files changed, 34 insertions, 10 deletions
diff --git a/adb/adb_unique_fd.h b/adb/adb_unique_fd.h new file mode 100644 index 000000000..34c1bbcfa --- /dev/null +++ b/adb/adb_unique_fd.h @@ -0,0 +1,26 @@ +/* + * Copyright (C) 2016 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <android-base/unique_fd.h> + +// Helper to automatically close an FD when it goes out of scope. +struct AdbCloser { + static void Close(int fd); +}; + +using unique_fd = android::base::unique_fd_impl<AdbCloser>; diff --git a/adb/adb_utils.cpp b/adb/adb_utils.cpp index e138a9011..db39ef47f 100644 --- a/adb/adb_utils.cpp +++ b/adb/adb_utils.cpp @@ -17,6 +17,7 @@ #define TRACE_TAG ADB #include "adb_utils.h" +#include "adb_unique_fd.h" #include <libgen.h> #include <stdlib.h> @@ -309,3 +310,7 @@ std::string adb_get_android_dir_path() { } return android_dir; } + +void AdbCloser::Close(int fd) { + adb_close(fd); +} diff --git a/adb/adb_utils.h b/adb/adb_utils.h index d08c4119e..16317e021 100644 --- a/adb/adb_utils.h +++ b/adb/adb_utils.h @@ -20,7 +20,6 @@ #include <string> #include <android-base/macros.h> -#include <android-base/unique_fd.h> void close_stdin(); @@ -57,13 +56,4 @@ extern int adb_close(int fd); bool forward_targets_are_valid(const std::string& source, const std::string& dest, std::string* error); -// Helper to automatically close an FD when it goes out of scope. -struct AdbCloser { - static void Close(int fd) { - adb_close(fd); - } -}; - -using unique_fd = android::base::unique_fd_impl<AdbCloser>; - #endif diff --git a/adb/commandline.cpp b/adb/commandline.cpp index c69fe1981..20d40fd72 100644 --- a/adb/commandline.cpp +++ b/adb/commandline.cpp @@ -51,6 +51,7 @@ #include "adb_auth.h" #include "adb_client.h" #include "adb_io.h" +#include "adb_unique_fd.h" #include "adb_utils.h" #include "bugreport.h" #include "commandline.h" diff --git a/adb/jdwp_service.cpp b/adb/jdwp_service.cpp index 027821a7d..3135aa42a 100644 --- a/adb/jdwp_service.cpp +++ b/adb/jdwp_service.cpp @@ -34,6 +34,7 @@ #include "adb.h" #include "adb_io.h" +#include "adb_unique_fd.h" #include "adb_utils.h" /* here's how these things work. diff --git a/adb/shell_service.cpp b/adb/shell_service.cpp index d83622cbf..01e206a58 100644 --- a/adb/shell_service.cpp +++ b/adb/shell_service.cpp @@ -100,6 +100,7 @@ #include "adb.h" #include "adb_io.h" #include "adb_trace.h" +#include "adb_unique_fd.h" #include "adb_utils.h" #include "security_log_tags.h" |