diff options
| author | Andrew Boie <andrew.p.boie@intel.com> | 2011-11-14 21:16:16 -0800 |
|---|---|---|
| committer | Andrew Boie <andrew.p.boie@intel.com> | 2012-07-26 10:18:14 -0700 |
| commit | 0b344e7f111d845f9cbb8d284f62d546645c733e (patch) | |
| tree | 9e3a3b11b0807bbd821f5b8a8af7fe2b0d81f72c /libdiskconfig | |
| parent | 23ee469c4b790634959e5ccf83134f44e73fb72b (diff) | |
| download | core-0b344e7f111d845f9cbb8d284f62d546645c733e.tar.gz core-0b344e7f111d845f9cbb8d284f62d546645c733e.tar.bz2 core-0b344e7f111d845f9cbb8d284f62d546645c733e.zip | |
config_mbr: Fix integer overflow
The values need to be converted to loff_t *before* performing
the multiplication, else any sector offset past MAX_INT
bytes will overflow.
Change-Id: Ib8992f28aa4119ac7b4ad354b2448c4b0cfaf846
Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
Diffstat (limited to 'libdiskconfig')
| -rw-r--r-- | libdiskconfig/config_mbr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libdiskconfig/config_mbr.c b/libdiskconfig/config_mbr.c index 703484c21..b89d382be 100644 --- a/libdiskconfig/config_mbr.c +++ b/libdiskconfig/config_mbr.c @@ -152,7 +152,7 @@ mk_ext_pentry(struct disk_info *dinfo, struct part_info *pinfo, uint32_t *lba, /* we are going to write the ebr at the current LBA, and then bump the * lba counter since that is where the logical data partition will start */ - item->offset = (*lba) * dinfo->sect_size; + item->offset = ((loff_t)(*lba)) * dinfo->sect_size; (*lba)++; ebr = (struct pc_boot_record *) &item->data; |