diff options
author | Vernon Tang <vt@foilhead.net> | 2011-04-25 13:08:17 +1000 |
---|---|---|
committer | Vernon Tang <vt@foilhead.net> | 2011-04-28 05:16:21 +1000 |
commit | 3f582e92f07d358f3d0941b86407b39e2e7e67cc (patch) | |
tree | a04943dff52d809db2b9fc9d9bdd9709a80b6d65 /init | |
parent | ab6e55f72b975b4fc61c436d4540ba7416166262 (diff) | |
download | core-3f582e92f07d358f3d0941b86407b39e2e7e67cc.tar.gz core-3f582e92f07d358f3d0941b86407b39e2e7e67cc.tar.bz2 core-3f582e92f07d358f3d0941b86407b39e2e7e67cc.zip |
Fold uevent message origin checking from init into libcutils.
Change-Id: I7cbc0cb840d1b4962e6c360fdad9a9c0ce20e87b
Diffstat (limited to 'init')
-rw-r--r-- | init/devices.c | 34 |
1 files changed, 5 insertions, 29 deletions
diff --git a/init/devices.c b/init/devices.c index e73efdf03..eb5d84e05 100644 --- a/init/devices.c +++ b/init/devices.c @@ -33,6 +33,8 @@ #include <asm/page.h> #include <sys/wait.h> +#include <cutils/uevent.h> + #include "devices.h" #include "util.h" #include "log.h" @@ -589,35 +591,9 @@ static void handle_firmware_event(struct uevent *uevent) #define UEVENT_MSG_LEN 1024 void handle_device_fd() { - for(;;) { - char msg[UEVENT_MSG_LEN+2]; - char cred_msg[CMSG_SPACE(sizeof(struct ucred))]; - struct iovec iov = {msg, sizeof(msg)}; - struct sockaddr_nl snl; - struct msghdr hdr = {&snl, sizeof(snl), &iov, 1, cred_msg, sizeof(cred_msg), 0}; - - ssize_t n = recvmsg(device_fd, &hdr, 0); - if (n <= 0) { - break; - } - - if ((snl.nl_groups != 1) || (snl.nl_pid != 0)) { - /* ignoring non-kernel netlink multicast message */ - continue; - } - - struct cmsghdr * cmsg = CMSG_FIRSTHDR(&hdr); - if (cmsg == NULL || cmsg->cmsg_type != SCM_CREDENTIALS) { - /* no sender credentials received, ignore message */ - continue; - } - - struct ucred * cred = (struct ucred *)CMSG_DATA(cmsg); - if (cred->uid != 0) { - /* message from non-root user, ignore */ - continue; - } - + char msg[UEVENT_MSG_LEN+2]; + int n; + while ((n = uevent_checked_recv(device_fd, msg, UEVENT_MSG_LEN)) > 0) { if(n >= UEVENT_MSG_LEN) /* overflow -- discard */ continue; |