diff options
| author | Elliott Hughes <enh@google.com> | 2014-06-27 18:29:28 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2014-06-26 18:34:59 +0000 |
| commit | e080be575419e77c909b54791ea2b44467a1a913 (patch) | |
| tree | aabd2c504c6f155206d2be4f5621cb13e495ee7a /debuggerd | |
| parent | c8a7e34dfc0f8f1c994168672db21175b28b931f (diff) | |
| parent | 75582957cfe1c985aa58dd64d7e1405fa93b04e0 (diff) | |
| download | core-e080be575419e77c909b54791ea2b44467a1a913.tar.gz core-e080be575419e77c909b54791ea2b44467a1a913.tar.bz2 core-e080be575419e77c909b54791ea2b44467a1a913.zip | |
Merge "Fixed tid/pid mixup in debuggerd gdbclient output."
Diffstat (limited to 'debuggerd')
| -rw-r--r-- | debuggerd/debuggerd.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/debuggerd/debuggerd.cpp b/debuggerd/debuggerd.cpp index fc13977b0..61805c932 100644 --- a/debuggerd/debuggerd.cpp +++ b/debuggerd/debuggerd.cpp @@ -53,10 +53,10 @@ struct debugger_request_t { int32_t original_si_code; }; -static void wait_for_user_action(pid_t pid) { +static void wait_for_user_action(const debugger_request_t &request) { // Find out the name of the process that crashed. char path[64]; - snprintf(path, sizeof(path), "/proc/%d/exe", pid); + snprintf(path, sizeof(path), "/proc/%d/exe", request.pid); char exe[PATH_MAX]; int count; @@ -78,7 +78,7 @@ static void wait_for_user_action(pid_t pid) { "* Wait for gdb to start, then press the VOLUME DOWN key\n" "* to let the process continue crashing.\n" "********************************************************\n", - pid, exe, pid); + request.pid, exe, request.tid); // Wait for VOLUME DOWN. if (init_getevent() == 0) { @@ -93,7 +93,7 @@ static void wait_for_user_action(pid_t pid) { uninit_getevent(); } - ALOGI("debuggerd resuming process %d", pid); + ALOGI("debuggerd resuming process %d", request.pid); } static int get_process_info(pid_t tid, pid_t* out_pid, uid_t* out_uid, uid_t* out_gid) { @@ -323,7 +323,7 @@ static void handle_request(int fd) { // for user action for the crashing process. // in this case, we log a message and turn the debug LED on // waiting for a gdb connection (for instance) - wait_for_user_action(request.pid); + wait_for_user_action(request); } else { // just detach if (ptrace(PTRACE_DETACH, request.tid, 0, 0)) { |
