summaryrefslogtreecommitdiffstats
path: root/debuggerd/backtrace.cpp
diff options
context:
space:
mode:
authorBrigid Smith <brigidsmith@google.com>2014-06-18 14:17:57 -0700
committerElliott Hughes <enh@google.com>2014-06-19 10:59:01 -0700
commit50eb546ec1584c04cf18f1941a042d7c5d045a67 (patch)
tree6b04d86e7042d0470c0fcd4ce03451751d9c1b48 /debuggerd/backtrace.cpp
parent3f55d2f4e69dd155d558fc2aa38e6f9bb0900152 (diff)
downloadcore-50eb546ec1584c04cf18f1941a042d7c5d045a67.tar.gz
core-50eb546ec1584c04cf18f1941a042d7c5d045a67.tar.bz2
core-50eb546ec1584c04cf18f1941a042d7c5d045a67.zip
Removed log.quiet and log = NULL cases from debuggerd.
Now the functionality implemented by these semi-confusing cases has been replaced with the same logtype enum behavior that is easier to understand, and cases that used log-looking behavior to print to logcat (when log = NULL) now use the more transparent ALOGE/ALOGD functions. Change-Id: I7e38f2d4ca74a828df4d2266b3ea34edd3c6f5bb
Diffstat (limited to 'debuggerd/backtrace.cpp')
-rw-r--r--debuggerd/backtrace.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/debuggerd/backtrace.cpp b/debuggerd/backtrace.cpp
index d08242e76..50bc16702 100644
--- a/debuggerd/backtrace.cpp
+++ b/debuggerd/backtrace.cpp
@@ -95,7 +95,7 @@ static void dump_thread(
}
if (!attached && ptrace(PTRACE_DETACH, tid, 0, 0) != 0) {
- LOG_ERROR("ptrace detach from %d failed: %s\n", tid, strerror(errno));
+ _LOG(log, logtype::ERROR, "ptrace detach from %d failed: %s\n", tid, strerror(errno));
*detach_failed = true;
}
}
@@ -105,7 +105,6 @@ void dump_backtrace(int fd, int amfd, pid_t pid, pid_t tid, bool* detach_failed,
log_t log;
log.tfd = fd;
log.amfd = amfd;
- log.quiet = true;
dump_process_header(&log, pid);
dump_thread(&log, tid, true, detach_failed, total_sleep_time_usec);