summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJosh Gao <jmgao@google.com>2016-03-17 13:39:15 -0700
committerJosh Gao <jmgao@google.com>2016-03-17 13:47:48 -0700
commitb17f228ff6cdc73f0ca3ab4578f78faf1a7f1b86 (patch)
tree31c418cb32bb331d777880cf027362ad5b386d57
parentb45800afa38a1cfb7c4e1e9adb3440022c82618a (diff)
downloadcore-b17f228ff6cdc73f0ca3ab4578f78faf1a7f1b86.tar.gz
core-b17f228ff6cdc73f0ca3ab4578f78faf1a7f1b86.tar.bz2
core-b17f228ff6cdc73f0ca3ab4578f78faf1a7f1b86.zip
debuggerd: don't send SIGSTOP to crashing processes.
This was actually nonfunctional until f5e8f0b, because it was using kill after privileges were dropped. This doesn't seem necessary after the changes to the sibling thread ptrace logic, though. Bug: http://b/27427439 Change-Id: I6bffbc14e0cf5e377bbfa39c945518e0d436c223
-rw-r--r--debuggerd/debuggerd.cpp5
1 files changed, 0 insertions, 5 deletions
diff --git a/debuggerd/debuggerd.cpp b/debuggerd/debuggerd.cpp
index 71c1e83da..fff28802a 100644
--- a/debuggerd/debuggerd.cpp
+++ b/debuggerd/debuggerd.cpp
@@ -417,12 +417,7 @@ static bool perform_dump(const debugger_request_t& request, int fd, int tombston
#endif
case SIGTRAP:
ALOGV("stopped -- fatal signal\n");
- // Send a SIGSTOP to the process to make all of
- // the non-signaled threads stop moving. Without
- // this we get a lot of "ptrace detach failed:
- // No such process".
*crash_signal = signal;
- send_signal(request.pid, 0, SIGSTOP);
engrave_tombstone(tombstone_fd, backtrace_map, request.pid, request.tid, siblings, signal,
request.original_si_code, request.abort_msg_address);
break;