From 21efffa54e136e1b45d8016339bda25690b2b7fd Mon Sep 17 00:00:00 2001 From: Yunlian Jiang Date: Tue, 17 May 2016 11:33:06 -0700 Subject: GOLD/DWP: exit without segfault if the binary is not built with debug fission. dwp segfaults when trying to get .dwp file from a binary built without debug fission. This patch fixes that. upstream thread is https://sourceware.org/ml/binutils/2016-05/msg00204.html BUG=None TEST=dwp still works with files built with debug fission and dwp does not segfault on files that are not built with debug fission. --- binutils-2.25/gold/dwp.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/binutils-2.25/gold/dwp.cc b/binutils-2.25/gold/dwp.cc index 121f37b1..9eef68ab 100644 --- a/binutils-2.25/gold/dwp.cc +++ b/binutils-2.25/gold/dwp.cc @@ -2427,6 +2427,10 @@ main(int argc, char** argv) if (exe_filename == NULL && files.empty()) gold_fatal(_("no input files and no executable specified")); + // If there are no DWO files, there is nothing to do. + if (files.empty()) + return EXIT_SUCCESS; + if (verify_only) { // Get list of DWO files in the DWP file and compare with -- cgit v1.2.3