summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYiran Wang <yiran@google.com>2015-06-16 23:58:29 (GMT)
committerYiran Wang <yiran@google.com>2015-06-16 23:58:29 (GMT)
commit53164d07778578ddf7787a75e167af74becd9da9 (patch)
tree67fcbf5b9f4541feb0af57846d9c78bbf345f744
parentc39479f4ab4d372b518957871e1f205a03e7c3d6 (diff)
downloadtoolchain_binutils-53164d07778578ddf7787a75e167af74becd9da9.zip
toolchain_binutils-53164d07778578ddf7787a75e167af74becd9da9.tar.gz
toolchain_binutils-53164d07778578ddf7787a75e167af74becd9da9.tar.bz2
Disable the warning of a hidden symbol matches a reference to be
resolved. It looks like it is WAI, but in some scenario there could a lot of them and the build script just die on any warning. Please refer to bug 21502954 for some details. Change-Id: I6cc90adccc63d26f15821bed6e4c6ff336722eff
-rw-r--r--binutils-2.25/gold/ChangeLog4
-rw-r--r--binutils-2.25/gold/resolve.cc11
2 files changed, 6 insertions, 9 deletions
diff --git a/binutils-2.25/gold/ChangeLog b/binutils-2.25/gold/ChangeLog
index 4e9aec0..6ce6110 100644
--- a/binutils-2.25/gold/ChangeLog
+++ b/binutils-2.25/gold/ChangeLog
@@ -1,3 +1,7 @@
+2015-06-16 Yiran Wang <yiran@google.com>
+ * resolve.cc disable the warning of a hidden symbol matches a
+ reference to be resolved
+
2015-04-27 Han Shen <shenhan@google.com>
* options.h (--fix-cortex-a53-843419): Rename option.
diff --git a/binutils-2.25/gold/resolve.cc b/binutils-2.25/gold/resolve.cc
index 1c0344c..effcdca 100644
--- a/binutils-2.25/gold/resolve.cc
+++ b/binutils-2.25/gold/resolve.cc
@@ -279,15 +279,8 @@ Symbol_table::resolve(Sized_symbol<size>* to,
&& (to->visibility() == elfcpp::STV_HIDDEN
|| to->visibility() == elfcpp::STV_INTERNAL))
{
- // A dynamic object cannot reference a hidden or internal symbol
- // defined in another object.
- gold_warning(_("%s symbol '%s' in %s is referenced by DSO %s"),
- (to->visibility() == elfcpp::STV_HIDDEN
- ? "hidden"
- : "internal"),
- to->demangled_name().c_str(),
- to->object()->name().c_str(),
- object->name().c_str());
+ // it is good to be helpful, but the warning leads to build error
+ // for some users, so disable it if not really wanted.
return;
}
else