system_core/adb/adb_auth_host.cpp, branch replicant-6.0 system/core adb: win32: fix key files reading/writing 2015-06-12T18:02:37+00:00 Spencer Low CompareAndSwap@gmail.com 2015-05-08T02:08:29+00:00 d62bce804005ef55bba90b9513a17db63c186ab3 The issue is that adb uses fopen() with "e" (presumably to open the file with O_CLOEXEC), but that flag causes MSVCRT.DLL to return an error. So when adb_auth_host.cpp goes to read or write the adbkey files, it fails. The quick fix is to not use the "e" option on adb host code since it isn't necessary there, compared to adbd. An alternative fix would be to have a fopen() wrapper on Windows that filters out the "e" option. Bug: http://b/21806456 Bug: https://code.google.com/p/android/issues/detail?id=175077 Change-Id: I7d8ba2847dab0ed558ffe156e79093251eb253c9 Signed-off-by: Spencer Low <CompareAndSwap@gmail.com> (cherry picked from commit 9b9603148b0a42ee9b4fc2df76bfde31ba29c311) 
The issue is that adb uses fopen() with "e" (presumably to open the file
with O_CLOEXEC), but that flag causes MSVCRT.DLL to return an error. So
when adb_auth_host.cpp goes to read or write the adbkey files, it fails.

The quick fix is to not use the "e" option on adb host code since it
isn't necessary there, compared to adbd.

An alternative fix would be to have a fopen() wrapper on Windows that
filters out the "e" option.

Bug: http://b/21806456
Bug: https://code.google.com/p/android/issues/detail?id=175077
Change-Id: I7d8ba2847dab0ed558ffe156e79093251eb253c9
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
(cherry picked from commit 9b9603148b0a42ee9b4fc2df76bfde31ba29c311)
Remove strtok from adb. 2015-04-28T17:55:24+00:00 Elliott Hughes enh@google.com 2015-04-25T06:02:00+00:00 d81f75ae41b2eed4ae7b0911f250778f3e6ec9c2 Also fix android::base::Split to behave like Java, Python, and google3. (cherry picked from commit 8d5fa6da44d56511b3e173bc463cbc65ff221b4a) Change-Id: I9388ae37ee8dd4a4a6c2a9a19f068b70d9a78353 
Also fix android::base::Split to behave like Java, Python, and google3.

(cherry picked from commit 8d5fa6da44d56511b3e173bc463cbc65ff221b4a)

Change-Id: I9388ae37ee8dd4a4a6c2a9a19f068b70d9a78353
File header cleanup. 2015-03-19T22:32:33+00:00 Dan Albert danalbert@google.com 2015-03-19T22:21:08+00:00 3313426fad9eaaf53017cdbde889ebcec91358ec * sysdeps.h should always be included first. * TRACE_TAG needs to be defined before anything is included. * Some files were missing copyright headers. * Save precious bytes on my SSD by removing useless whitespace. Change-Id: I88980e6e00b5be1093806cf286740d9e4a033b94 
 * sysdeps.h should always be included first.
 * TRACE_TAG needs to be defined before anything is included.
 * Some files were missing copyright headers.
 * Save precious bytes on my SSD by removing useless whitespace.

Change-Id: I88980e6e00b5be1093806cf286740d9e4a033b94
Move adb to C++. 2015-03-09T21:06:11+00:00 Dan Albert danalbert@google.com 2015-02-26T01:51:28+00:00 bac3474a8256cb32a29e8d46f78cad95a5502692 I keep trying to clean things up and needing std::strings. Might as well just do this now. usb_linux_client.c is going to stay as C because GCC isn't smart enough to deal with the designated initializers it uses (though for some reason it is in C mode). The Darwin files are staying as C because I don't have a way to test that they build. The Windows files are staying as C because while I can actually build for them, it's slow and painful. Change-Id: I75367d29205a9049d34460032b3bb36384f43941 
I keep trying to clean things up and needing std::strings. Might as
well just do this now.

usb_linux_client.c is going to stay as C because GCC isn't smart
enough to deal with the designated initializers it uses (though for
some reason it is in C mode).

The Darwin files are staying as C because I don't have a way to test
that they build.

The Windows files are staying as C because while I can actually build
for them, it's slow and painful.

Change-Id: I75367d29205a9049d34460032b3bb36384f43941