system_core/adb/adb.cpp, branch replicant-6.0

strrchr() returns const char*, so casting is necessary

2021-08-25T16:26:58+00:00

fixes build errors with custom toolchain

Change-Id: I6aeddf8007a467b3e08af0e86d0016db7dd8ac9e
Signed-off-by: Wolfgang Wiedmeyer

Backport missing null check in "adb get-state".

2015-09-01T19:57:07+00:00

Bug: https://code.google.com/p/android/issues/detail?id=184011
Bug: http://b/23709037
Change-Id: Ia33814bd2adc310c2471cd6a12b9a73f27d77182

Ignore ro.adb.secure in user builds.

2015-06-19T20:26:02+00:00

Require authorization by default, and remove the ability to override
that in user builds. (userdebug and eng are still free to do whatever
they want.)

Bug: http://b/21862859
Change-Id: Ibf8af375be5bf1141c1ad481eee7a59fb10a7adb
(cherry picked from commit 5cba504215ea91187cc36ec7aec5dce1b0f4b0fe)

Add WriteFdFmt and clean up more code.

2015-05-02T00:37:28+00:00

Also say *which* device wasn't found.

Bug: http://b/20666660
Change-Id: I50e234ad89e39ae0a8995083c0b642c61275c5a3
(cherry picked from commit ab52c181fa4c1c9891644635dc5653cda5b90e2b)

More adb buffer fixes.

2015-05-02T00:09:34+00:00

This patch factors out a lot of the basic protocol code: sending OKAY,
sending FAIL, and sending a length-prefixed string.

ADB_TRACE has been non-optional for a long time, so let's just remove
the #ifs.

Also actually build the device tracker test tool (and remove its duplicate).

Bug: http://b/20666660
Change-Id: I6c7d59f18707bdc62ca69dea45547617f9f31fc6
(cherry picked from commit e67f1f87d9b1188ec8617035db7006c37ee7b21e)

Add missing 'else' to fix all devices showing up as "host".

2015-04-30T05:44:47+00:00

Bug: http://b/20705355
Change-Id: I4f7830278f0c2bc87d95d148d85455b8da894645
(cherry picked from commit 3ce9575af76fa6dc110506080434303b9459abf4)

Remove strtok from adb.

2015-04-28T17:55:24+00:00

Also fix android::base::Split to behave like Java, Python, and google3.

(cherry picked from commit 8d5fa6da44d56511b3e173bc463cbc65ff221b4a)

Change-Id: I9388ae37ee8dd4a4a6c2a9a19f068b70d9a78353

Always explain why bind(2) failed.

2015-04-20T15:09:20+00:00

This has confused several people lately.

Bug: http://b/20219978
Change-Id: I2537ceb83bff0b3166c230c728d4389a983db858

Show $ADB_VENDOR_KEYS if authentication fails.

2015-04-17T05:54:44+00:00

Incorrectly set $ADB_VENDOR_KEYS is the most likely cause of failed
adb connections. Make it easier to debug such problems by including
the value in use in the error message.

Bug: 20165551
Change-Id: I64c1d98ae6d3fb40eea9e1f0ddcfcf4f2d9d7318

Additional cleanup of start_device_log.

2015-03-20T16:49:15+00:00

Addresses nnk's post commit review comments on
https://android-review.googlesource.com/#/c/139381/

Remove unneeded code for creating /data/adb.

Add an O_CLOEXEC.

Move the closing of stdin out to main().

Append the pid of the current process to the log file to avoid
clobbering the log if the process crashes and restarts within the same
second.

Change-Id: Ide0be86b4b33256486634c29ba02efaf10cf913d