From 9a940cbf047e65e210f302b18cc95f45e63a1b13 Mon Sep 17 00:00:00 2001 From: John Spurlock Date: Mon, 20 Oct 2014 14:22:38 -0400 Subject: Settings: Display 'Calls' category on non-voice devices. Since the category applies to any call, include config for this interruption even on non-voice-capable devices. Bug: 17666139 Change-Id: I3732246179c527220f8c6bee539ba7bc1e80de18 --- .../settings/notification/ZenModeSettings.java | 54 +++++++--------------- 1 file changed, 16 insertions(+), 38 deletions(-) (limited to 'src') diff --git a/src/com/android/settings/notification/ZenModeSettings.java b/src/com/android/settings/notification/ZenModeSettings.java index 7fd3aa1d9..64a5d810c 100644 --- a/src/com/android/settings/notification/ZenModeSettings.java +++ b/src/com/android/settings/notification/ZenModeSettings.java @@ -51,8 +51,6 @@ import android.widget.TimePicker; import com.android.settings.R; import com.android.settings.SettingsPreferenceFragment; -import com.android.settings.Utils; -import com.android.settings.notification.DropDownPreference.Callback; import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.search.Indexable; import com.android.settings.search.SearchIndexableRaw; @@ -69,7 +67,7 @@ public class ZenModeSettings extends SettingsPreferenceFragment implements Index private static final String KEY_ZEN_MODE = "zen_mode"; private static final String KEY_IMPORTANT = "important"; - private static final String KEY_CALLS = "phone_calls"; + private static final String KEY_CALLS = "calls"; private static final String KEY_MESSAGES = "messages"; private static final String KEY_STARRED = "starred"; private static final String KEY_EVENTS = "events"; @@ -105,12 +103,8 @@ public class ZenModeSettings extends SettingsPreferenceFragment implements Index private static SparseArray allKeyTitles(Context context) { final SparseArray rt = new SparseArray(); rt.put(R.string.zen_mode_important_category, KEY_IMPORTANT); - if (Utils.isVoiceCapable(context)) { - rt.put(R.string.zen_mode_phone_calls, KEY_CALLS); - rt.put(R.string.zen_mode_option_title, KEY_ZEN_MODE); - } else { - rt.put(R.string.zen_mode_option_title_novoice, KEY_ZEN_MODE); - } + rt.put(R.string.zen_mode_calls, KEY_CALLS); + rt.put(R.string.zen_mode_option_title, KEY_ZEN_MODE); rt.put(R.string.zen_mode_messages, KEY_MESSAGES); rt.put(R.string.zen_mode_from_starred, KEY_STARRED); rt.put(R.string.zen_mode_events, KEY_EVENTS); @@ -155,7 +149,7 @@ public class ZenModeSettings extends SettingsPreferenceFragment implements Index mConfig = getZenModeConfig(); if (DEBUG) Log.d(TAG, "Loaded mConfig=" + mConfig); - final Preference zenMode = PREF_ZEN_MODE.init(this); + PREF_ZEN_MODE.init(this); PREF_ZEN_MODE.setCallback(new SettingPrefWithCallback.Callback() { @Override public void onSettingSelected(int value) { @@ -164,31 +158,23 @@ public class ZenModeSettings extends SettingsPreferenceFragment implements Index } } }); - if (!Utils.isVoiceCapable(mContext)) { - zenMode.setTitle(R.string.zen_mode_option_title_novoice); - } final PreferenceCategory important = (PreferenceCategory) root.findPreference(KEY_IMPORTANT); mCalls = (SwitchPreference) important.findPreference(KEY_CALLS); - if (Utils.isVoiceCapable(mContext)) { - mCalls.setOnPreferenceChangeListener(new OnPreferenceChangeListener() { - @Override - public boolean onPreferenceChange(Preference preference, Object newValue) { - if (mDisableListeners) return true; - final boolean val = (Boolean) newValue; - if (val == mConfig.allowCalls) return true; - if (DEBUG) Log.d(TAG, "onPrefChange allowCalls=" + val); - final ZenModeConfig newConfig = mConfig.copy(); - newConfig.allowCalls = val; - return setZenModeConfig(newConfig); - } - }); - } else { - important.removePreference(mCalls); - mCalls = null; - } + mCalls.setOnPreferenceChangeListener(new OnPreferenceChangeListener() { + @Override + public boolean onPreferenceChange(Preference preference, Object newValue) { + if (mDisableListeners) return true; + final boolean val = (Boolean) newValue; + if (val == mConfig.allowCalls) return true; + if (DEBUG) Log.d(TAG, "onPrefChange allowCalls=" + val); + final ZenModeConfig newConfig = mConfig.copy(); + newConfig.allowCalls = val; + return setZenModeConfig(newConfig); + } + }); mMessages = (SwitchPreference) important.findPreference(KEY_MESSAGES); mMessages.setOnPreferenceChangeListener(new OnPreferenceChangeListener() { @@ -554,14 +540,6 @@ public class ZenModeSettings extends SettingsPreferenceFragment implements Index } return result; } - - public List getNonIndexableKeys(Context context) { - final ArrayList rt = new ArrayList(); - if (!Utils.isVoiceCapable(context)) { - rt.add(KEY_CALLS); - } - return rt; - } }; private static class SettingPrefWithCallback extends SettingPref { -- cgit v1.2.3