summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortnmy-cyngn <tlnu@cyngn.com>2016-06-23 09:36:58 +0530
committerJoey Rizzoli <joey@lineageos.org>2017-11-14 20:28:49 +0100
commit30109213a0e05913c4442bab42d640794358ab55 (patch)
tree420ec4ac9b91a2b48383646c220d8a74327b3e0f
parent1225357c5bba0fd9f215e86f9a077aec8c761908 (diff)
downloadpackages_apps_Messaging-30109213a0e05913c4442bab42d640794358ab55.tar.gz
packages_apps_Messaging-30109213a0e05913c4442bab42d640794358ab55.tar.bz2
packages_apps_Messaging-30109213a0e05913c4442bab42d640794358ab55.zip
Messaging app crashes after a few MMS
In some scenarios, data not bound when SIM state change local broadcasts are received. See stacktrace for more info. Protect against/skip call to update() in such scenarios. Change-Id: Iee7775a74d22808cb262e8973ca70e5e1f0acfc9 Bug-Id: CYNGNOS-3062, KIPPER-718
-rw-r--r--src/com/android/messaging/ui/conversation/ConversationFragment.java3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/com/android/messaging/ui/conversation/ConversationFragment.java b/src/com/android/messaging/ui/conversation/ConversationFragment.java
index a6a191a..419ad5d 100644
--- a/src/com/android/messaging/ui/conversation/ConversationFragment.java
+++ b/src/com/android/messaging/ui/conversation/ConversationFragment.java
@@ -191,7 +191,8 @@ public class ConversationFragment extends Fragment implements ConversationDataLi
intent.getStringExtra(UIIntents.UI_INTENT_EXTRA_CONVERSATION_SELF_ID);
Assert.notNull(conversationId);
Assert.notNull(selfId);
- if (TextUtils.equals(mBinding.getData().getConversationId(), conversationId)) {
+ if (isBound() && TextUtils
+ .equals(mBinding.getData().getConversationId(), conversationId)) {
mComposeMessageView.updateConversationSelfIdOnExternalChange(selfId);
}
}