summaryrefslogtreecommitdiffstats
path: root/res/layout
diff options
context:
space:
mode:
authorTyler Gunn <tgunn@google.com>2014-12-04 09:24:03 -0800
committerTyler Gunn <tgunn@google.com>2014-12-04 09:24:03 -0800
commit7ad00e04589d04413387c987c8b547a0a6df5f13 (patch)
tree5c16a43bf269e99a3fb4c6e185d3d2dd43fa7fe2 /res/layout
parentfcd44c7de3928918dc7e4e93c45f23db5801d201 (diff)
downloadpackages_apps_InCallUI-7ad00e04589d04413387c987c8b547a0a6df5f13.tar.gz
packages_apps_InCallUI-7ad00e04589d04413387c987c8b547a0a6df5f13.tar.bz2
packages_apps_InCallUI-7ad00e04589d04413387c987c8b547a0a6df5f13.zip
Fixing manage conference accessibility issues.
1. The "Manage Conference" button would be announced twice when it received focus. Moved content description to the parent FrameLayout that acts as the button and made it focusable to ensure that the description is read only a single time. 2. When tapping "Manage Conference" button there was no audible feedback that the manage conference screen was opened. Set focus to the list of conference participants so that this list is announced when the manage conference screen opens. 3. It was possible to change focus from the list of participants in the manage conference screen to the call card buttons and other elements behind the manage conference screen. Fixed by explicitly setting the call card fragment visibility to GONE when the conference manager is shown. Bug: 18440532 Change-Id: I0ce4f74ccb98c5cefd6c6e75eb8ef9310bd6d7fb
Diffstat (limited to 'res/layout')
-rw-r--r--res/layout/conference_manager_fragment.xml5
-rw-r--r--res/layout/manage_conference_call_button.xml13
2 files changed, 11 insertions, 7 deletions
diff --git a/res/layout/conference_manager_fragment.xml b/res/layout/conference_manager_fragment.xml
index 5aed520b..8e55ad76 100644
--- a/res/layout/conference_manager_fragment.xml
+++ b/res/layout/conference_manager_fragment.xml
@@ -23,7 +23,6 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:paddingTop="@dimen/conference_call_manager_padding_top"
- android:clickable="true"
android:visibility="gone">
<!-- List of conference participants. -->
@@ -33,5 +32,7 @@
android:layout_height="match_parent"
android:listSelector="@null"
android:background="@color/background_dialer_white"
- android:divider="@null" />
+ android:divider="@null"
+ android:focusableInTouchMode="true"
+ android:focusable="true"/>
</FrameLayout>
diff --git a/res/layout/manage_conference_call_button.xml b/res/layout/manage_conference_call_button.xml
index e9de926f..3b5ef993 100644
--- a/res/layout/manage_conference_call_button.xml
+++ b/res/layout/manage_conference_call_button.xml
@@ -15,12 +15,14 @@
~ limitations under the License
-->
-<!-- This button is used only on GSM devices, during a conference call. -->
+<!-- This button is used only on GSM and IMS devices, during a conference call. -->
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/manage_conference_call_button"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:background="@color/incall_banner_secondary_background_color">
+ android:background="@color/incall_banner_secondary_background_color"
+ android:focusable="true"
+ android:contentDescription="@string/onscreenManageConferenceText">
<Space android:layout_width="match_parent"
android:layout_height="1dp"
@@ -42,8 +44,8 @@
android:layout_height="wrap_content"
android:src="@drawable/ic_group_white_24dp"
android:tint="@color/incall_banner_secondary_text_color"
- android:contentDescription="@string/onscreenManageConferenceText"
- android:paddingEnd="16dp" />
+ android:paddingEnd="16dp"
+ android:importantForAccessibility="no" />
<TextView android:id="@+id/manageConferenceButtonLabel"
android:layout_width="match_parent"
@@ -51,7 +53,8 @@
android:gravity="center_vertical"
android:textColor="@color/incall_banner_secondary_text_color"
android:textSize="@dimen/secondary_call_info_text_size"
- android:text="@string/onscreenManageConferenceText" />
+ android:text="@string/onscreenManageConferenceText"
+ android:importantForAccessibility="no" />
</LinearLayout>