summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarcos Marado <mmarado@cyngn.com>2016-10-18 18:05:24 +0100
committerAdrian DC <radian.dc@gmail.com>2016-12-03 22:30:43 +0100
commit4b6e7dbf45ca024222c067cf751fe38b3b0e788e (patch)
treeb48f0cfbb85a204c6f7501d33bbc2edd7f49e97e
parentc38528adfd79e96ae0128e5230236a8a4bf5289a (diff)
downloadpackages_apps_ContactsCommon-stable/cm-13.0-ZNH5Y.tar.gz
packages_apps_ContactsCommon-stable/cm-13.0-ZNH5Y.tar.bz2
packages_apps_ContactsCommon-stable/cm-13.0-ZNH5Y.zip
PhoneNumberHelper: formatNumber: check if isEmptystable/cm-13.0-ZNH5Y
If formatNumber is invoked with an empty number, then there's no formatting to be done. This patch avoids an NPE while trying to parse an inexistent string. RM-290 Change-Id: Ic7a9dd3d1e0e7b27457f59f1209387b7faa359d9
-rw-r--r--src/com/android/contacts/common/util/PhoneNumberHelper.java6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/com/android/contacts/common/util/PhoneNumberHelper.java b/src/com/android/contacts/common/util/PhoneNumberHelper.java
index 39f8a39b..3c057052 100644
--- a/src/com/android/contacts/common/util/PhoneNumberHelper.java
+++ b/src/com/android/contacts/common/util/PhoneNumberHelper.java
@@ -118,8 +118,10 @@ public class PhoneNumberHelper {
* is made public.
*/
public static String formatNumber(String phoneNumber, String defaultCountryIso) {
- // Do not attempt to format numbers that start with a hash or star symbol.
- if (phoneNumber.startsWith("#") || phoneNumber.startsWith("*")) {
+ // Do not attempt to format numbers that are empty or start with a hash
+ // or star symbol.
+ if (TextUtils.isEmpty(phoneNumber) || phoneNumber.startsWith("#") ||
+ phoneNumber.startsWith("*")) {
return phoneNumber;
}