From 35e3f20b5d5bf21aedcd70b01dbaf7ad7ae62631 Mon Sep 17 00:00:00 2001 From: Sukanya Rajkhowa Date: Mon, 7 Dec 2009 17:39:44 -0800 Subject: Interpret keypresses as numbers on ffa Phone app Keypresses from the hard keyboard on ffa were being interpreted as letters and not numbers in Phone app since InputType was set to null. Changed keyboard to phone mode so that keypresses in Phone app are interpreted as numbers belonging to Phone class --- src/com/android/contacts/TwelveKeyDialer.java | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/com/android/contacts/TwelveKeyDialer.java b/src/com/android/contacts/TwelveKeyDialer.java index 2d8b4e636..e617e82ad 100644 --- a/src/com/android/contacts/TwelveKeyDialer.java +++ b/src/com/android/contacts/TwelveKeyDialer.java @@ -232,15 +232,7 @@ public class TwelveKeyDialer extends Activity implements View.OnClickListener, mDialpad = findViewById(R.id.dialpad); // This is null in landscape mode. - // In landscape we put the keyboard in phone mode. - // In portrait we prevent the soft keyboard to show since the - // dialpad acts as one already. - if (null == mDialpad) { - mDigits.setInputType(android.text.InputType.TYPE_CLASS_PHONE); - } else { - mDigits.setInputType(android.text.InputType.TYPE_NULL); - } - + mDigits.setInputType(android.text.InputType.TYPE_CLASS_PHONE); // Set up the "dialpad chooser" UI; see showDialpadChooser(). mDialpadChooser = (ListView) findViewById(R.id.dialpadChooser); mDialpadChooser.setOnItemClickListener(this); -- cgit v1.2.3 From 24b8c74925e7457a7dffc3052ec85ceb214b4675 Mon Sep 17 00:00:00 2001 From: Alok Tongaonkar Date: Mon, 8 Mar 2010 19:24:23 -0800 Subject: ContactList: Prevent Dialer from loading when Contacts app is launched. This change prevents Dialer from being setup as the current tab when Contacts is launched. This improves performance by preventing the TwelveKeyDialer class from getting loaded when Contacts List is viewed. When the Phone app is launched, the original behavior is unchanged and the Dialer is set up as the current tab. Change-Id: I0794dc860d55565f3a33ea65484e5ae8a26d89bd CRs-Fixed: 228919 --- src/com/android/contacts/DialtactsActivity.java | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/com/android/contacts/DialtactsActivity.java b/src/com/android/contacts/DialtactsActivity.java index 208fbf45c..6cffd16c0 100644 --- a/src/com/android/contacts/DialtactsActivity.java +++ b/src/com/android/contacts/DialtactsActivity.java @@ -74,8 +74,27 @@ public class DialtactsActivity extends TabActivity implements TabHost.OnTabChang mTabHost = getTabHost(); mTabHost.setOnTabChangedListener(this); + String componentName = intent.getComponent().getClassName(); + /* If intent is to view the Contacts List, prevent Dialer tab + * from being set as current tab. + */ + if (!getClass().getName().equals(componentName) && + !FAVORITES_ENTRY_COMPONENT.equals(componentName)) { + mTabHost.setAvoidFirstTabLoad(true); + } + // Setup the tabs setupDialerTab(); + + /* If intent is to view the Contacts List, restore the state of mTabhost so + * that the rest of the application semantics remains unchanged. + */ + if (!getClass().getName().equals(componentName) && + !FAVORITES_ENTRY_COMPONENT.equals(componentName)) { + mTabHost.setCurrentTabToZero(); + mTabHost.setAvoidFirstTabLoad(false); + } + setupCallLogTab(); setupContactsTab(); setupFavoritesTab(); -- cgit v1.2.3 From c88f80d3c5b2d276bf32b455555cf17047693444 Mon Sep 17 00:00:00 2001 From: Shylender Gaddamwar Date: Mon, 29 Mar 2010 17:17:47 -0700 Subject: Fix "Acore" crash when exporting contacts to SDCard. On Export confirmation (ExportConfirmationListener::onClick function) start the ActualExportThread after the progress dialog window pop's up. ActualExportThread::onCreateDialog instantiates ProgressDialog class, the thread start (run) function access mProgressDialog methods. since the thread started before the OnCreateDialog , the mProgressDialog object is null , Hence the Exception is thrown. Change-Id: Ia23e494535b7b7bd3066cbd418aff899c5e20825 CRs-Fixed:232123 --- src/com/android/contacts/ExportVCardActivity.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com/android/contacts/ExportVCardActivity.java b/src/com/android/contacts/ExportVCardActivity.java index baf2371d9..ea3b1d90c 100644 --- a/src/com/android/contacts/ExportVCardActivity.java +++ b/src/com/android/contacts/ExportVCardActivity.java @@ -102,8 +102,8 @@ public class ExportVCardActivity extends Activity { public void onClick(DialogInterface dialog, int which) { if (which == DialogInterface.BUTTON_POSITIVE) { mActualExportThread = new ActualExportThread(mFileName); - mActualExportThread.start(); showDialog(R.id.dialog_exporting_vcard); + mActualExportThread.start(); } } } @@ -451,4 +451,4 @@ public class ExportVCardActivity extends Activity { public String getErrorReason() { return mErrorReason; } -} \ No newline at end of file +} -- cgit v1.2.3