summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Don't display "CUSTOM" when PHONE_TYPE == "CUSTOM" and no label set.Tingting Wang2015-07-171-3/+6
| | | | | | | | | Check the case which PHONE_TYPE="CUSTOM" and no label set in QuickActivity, and return empty string instead of "CUSTOM". BUG 21900262 Change-Id: Icde2d7ec68bb2b489875b99dc6c2166d939134ea
* Show phonetic name next to display name in UI.Tingting Wang2015-07-141-1/+10
| | | | | | | | | In Quick contact UI, show phonetic name following its display name if phonetic name exists. BUG 22235947 Change-Id: I0066d2811b207bb36480f1d3c14712573b92a1a0
* Merge "Catch WRITE_CONTACTS SecurityExceptions" into mnc-devJay Shrauner2015-07-101-4/+8
|\
| * Catch WRITE_CONTACTS SecurityExceptionsJay Shrauner2015-07-101-4/+8
| | | | | | | | | | | | | | | | Fix crash when app lacks WRITE_CONTACTS and we fail in attempt to update interaction counts. Bug:22405683 Change-Id: I53a10b8907e88fe75296bcfaf4659d7f358875d8
* | Allow split of aggregate contact composed of >1 read-only contactsWalter Jang2015-07-091-3/+9
|/ | | | | | Bug 22382957 Change-Id: I33f22a5ba9c55fe722601b54cecc59a173d6940b
* Merge "Don't display Custom for PHONE_TYPE=CUSTOM part 2." into mnc-devTingting Wang2015-07-081-1/+3
|\
| * Don't display Custom for PHONE_TYPE=CUSTOM part 2.Tingting Wang2015-07-081-1/+3
| | | | | | | | | | | | | | | | | | | | Dialer sometimes creates custom PHONE_TYPE values without specifying the custom string. In this case, we shouldn't display "Custom". We should display nothing. BUG 21900262 Change-Id: Ie65a40fea3c857b7a65ee82a22c8cd1465225781
* | Mark Editors as deleted when entire KindSectionViews are removed.Walter Jang2015-07-084-2/+30
| | | | | | | | | | | | | | | | Regression was introduce by ag/721564 Bug 22345338 Change-Id: I21ef3e94cc20c8cc10f06084ce350b626710bbfc
* | Hide all empty email and phone KindSectionViews expect the lastWalter Jang2015-07-072-1/+20
| | | | | | | | | | | | Bug 22331611 Change-Id: I5c4544ed3cc82982f159f7c1758a1e6cd8868c48
* | Don't delete kind sections when there are >1 emails in the raw contactWalter Jang2015-07-072-50/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Also fix jank when deleting compact editor input fields We were animating removal of input fields when there was more than one field in the raw contact (i.e. Editor.deleteEditor) but not when hiding entire KindViewSections (i.e. KindSectionView.setVisibility(GONE)). When animating KindSectionView removals, we must mark it for deletion since we need to re-assess the number of KindSectionViews that are visibile (in order to show icons) before the removal animation finishes (the visibility is set to GONE at the end of the animation). * Prevent nicknames from being deleted Bug 22228718 Bug 22299522 Change-Id: I28dad184c53e89f067d54675fcb3e7ebac9d971e
* | Group non-phone and email fields together on compact editorWalter Jang2015-07-012-25/+65
| | | | | | | | | | | | Bug 22228718 Change-Id: I561ee25bad95a716744ba7d74fb6b49463b029da
* | Fix showing all phone nums and emails for joined contactsWalter Jang2015-06-303-53/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We must delete the entire KindSectionView for emails and phone numbers for all but the last raw contact that is being edited. Also, icons must be updated whenever an editor housed in a kindview is deleted since we only want to show the icon once for all the kindviews added to the compact layout for all the raw contacts in the delta list. Bug 22203548 Change-Id: If12c4fc10a9c9c09cbcfb86c5bf1472d89f6b890
* | Merge "Set package name on ACTION_PICK intent" into mnc-devBrian Attwell2015-06-261-0/+1
|\ \
| * | Set package name on ACTION_PICK intentBrian Attwell2015-06-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This prevents the disambiguation dialog from appearing. As a result, the user no longer has the ability to decide whether to use their Work or Personal Contacts app. This prevents the intent from becoming cross-profile. Bug: 17472472 Change-Id: Ica5a9bf960a016f735caf933da5cc8fa6aa7614c
* | | Merge "Don't rebuild labels when phone and emails field change" into mnc-devWalter Jang2015-06-261-2/+0
|\ \ \
| * | | Don't rebuild labels when phone and emails field changeWalter Jang2015-06-251-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was necessary when we using different hint colors for groups of input fields but since that was removed this should be safe to remove. Bug 21662781 Change-Id: I7b9f48fed3d963cce251d6b09e705907c9cb224f
* | | | Merge "Check permissions before using associated APIs" into mnc-devBrian Attwell2015-06-253-3/+10
|\ \ \ \ | |/ / / |/| | |
| * | | Check permissions before using associated APIsBrian Attwell2015-06-253-3/+10
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Also, use sdkVersion=MNC. This way missing runtime permissions will throw SecurityExceptions. This will make it easier to catch any unchecked usage of permissions. Bug: 21791169 Change-Id: I6118cc42e3aa6505b47df9470672f722600eca31
* / / Show google account types on editor as "account" instead of "contact"Walter Jang2015-06-254-35/+37
|/ / | | | | | | | | | | | | | | | | | | | | Also, missed the copy of the account type display lable setting logic for read-only contacts in ag/712716 so replacing that with the static utility method. Bug 18719390 Bug 21637149 Change-Id: I112b32a25d4d3682ca8e58ef327660bd163cb273
* / Parsing compact editor profile photo file IDs as longsWalter Jang2015-06-221-1/+1
|/ | | | | | | | This only appears to be affecting the ME profile photo Bug 22010349 Change-Id: If1be0ec6b2491649ebd0d3daa95a47cb437447af
* Show account info for inserts and read-only contact editsWalter Jang2015-06-197-37/+147
| | | | | | Bug 21637149 Change-Id: I224ab188230f119f49f4ab7ddef4b51c451aa892
* Make saving a contact less confusingWalter Jang2015-06-195-43/+64
| | | | | | | | | | | | | | | | * Add always visible save menu item (a checkmark icon) on both the compact and full editors. Selecting it saves changes and closes the editor (what back does currently). * On the compact editor, make back perform a discard, including warning the user if there are unsaved changes. * On the full editor, back still saves and goes back to the full editor. This is not ideal but it's out of scope to not save changes between the two editors when editing an existing contact. Bug 19983789 Change-Id: Ie23b75978db70f2b438a824e39f0ae8fb8aa99ec
* Allow users to edit photos for read-only contacts againWalter Jang2015-06-182-18/+75
| | | | | | | | | | | | Similar to ag/711429 (for editing read-only names), we set the photo bitmap from the read-only contact but set the newly created (and writable) raw contact as the delta underlying the photo editor view so that if the photo is updated by the user, the new raw contact is set as changed and not the read-only raw contact. Bug 21873945 Change-Id: Ibd40f3d708332fe6f87d247773b871d575d7d12e
* Ignore new raw contact display names when saving contactsWalter Jang2015-06-184-19/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we have logic to ignore the display name we add to newly created raw contacts (when the user wants to edit a read-only contact) when determining whether the user made any edits, we can enable changing the display on the compact editor again. Note, there is one glitch -- the name disappears on the compact editor after you click more fields (but only when editing read-only contacts). Tested scenarios: 1) Edit read-only contact, more fields, back, back No bogus contact is created and the read-only name is displayed on both editors. 2) Edit read-only contact, change name on compact editor, back, re-edit read-only contact, and split The read-only contact is unchanged and a new contact with the edited name is created. 3) Edit read-only contact, more fields, change name on full editor, back, back, re-edit read-only contact, and split Same result as (2) 4) Edit read-only contact, add phone on compact editor, back, re-edit read-only contact, and split The read-only contact is unchanged and a new contact with the read-only name and phone number is created. 5) Edit read-only contact, more fields, add phone on full editor, back, back, re-edit read-only contact, and split Same result as (4) Bug 21858251 Bug 21464081 Change-Id: I9028fee38b8ea7569968654a756eb98025318e69
* Fix detection of empty structured namesWalter Jang2015-06-171-12/+18
| | | | | | | | | | | | | TextFieldEditorView.isEmpty does not do the right thing for structured names because that methods just checks every child of the fields ViewGroup and the view retains values for fields that may have been erased by toggling the name expansion. The result is that the FIELD_TURNED_EMPTY EditorListener event is never fired. Bug 21851290 Change-Id: Iaae3ba102a899de9dfd76d0469c9c2f1d094b0bd
* Merge "Don't allow read-only photos to be changed in compact editor" into ↵Walter Jang2015-06-162-16/+23
|\ | | | | | | mnc-dev
| * Don't allow read-only photos to be changed in compact editorWalter Jang2015-06-162-16/+23
| | | | | | | | | | | | | | | | Also don't display compact editor photos for non-editable contacts Bug 21873945 Change-Id: I7523e9cc7f8342e546659ede6a3dd822d790a259
* | Merge "1/2 Sync Contacts and GoogleContacts manifests" into mnc-devWalter Jang2015-06-161-2/+2
|\ \
| * | 1/2 Sync Contacts and GoogleContacts manifestsWalter Jang2015-06-161-2/+2
| |/ | | | | | | | | | | | | Also removed "com.google" from the full editor action names. Change-Id: I1b8afb8f8a32ab1fe60c7174d092830d81dcee07
* / Don't allow read-only names to be changed in compact editorWalter Jang2015-06-161-10/+12
|/ | | | | | Bug 21858251 Change-Id: I3a66d30123ae1a64acbd162f7991a56cf37bcc72
* Pass the preferred name ID into the contact editorWalter Jang2015-06-167-16/+61
| | | | | | Bug 21870691 Change-Id: I99cc6bf8d90f32469ca7cf105567dcc3edf48e9f
* Merge "Don't set super primary name on compact editor unless it changes" ↵Walter Jang2015-06-163-17/+3
|\ | | | | | | into mnc-dev
| * Don't set super primary name on compact editor unless it changesWalter Jang2015-06-153-17/+3
| | | | | | | | | | | | | | | | | | Also fix the contact being loaded unnecessarily when transitioning to the full editor. Bug 21464081 Change-Id: Ic833f64a073898c8524892428512ce65f2f14625
* | Merge "Don't erase vcard type by calling setData()" into mnc-devBrian Attwell2015-06-161-5/+3
|\ \ | |/ |/|
| * Don't erase vcard type by calling setData()Brian Attwell2015-06-161-5/+3
| | | | | | | | | | | | | | | | | | BluetoothOppLauncherActivity checks that the vcard type is correctly set. Note, fixing this doesn't help with the bug that gmail has displaying vcards. Bug: 21650555 Change-Id: Iac08371320bdcc9043c45504b8318027543f094d
* | Fix bug causing a read-only default account to be setWalter Jang2015-06-121-21/+18
| | | | | | | | | | | | Bug 21464081 Change-Id: I97653796b7abbab8df61060c03b0ff0222c1442c
* | Don't initially focus any contact editor input fieldWalter Jang2015-06-092-11/+0
| | | | | | | | | | | | Bug 21644158 Change-Id: I84d1406b4db1646dcbf059ce84a2cc7534b0bd83
* | Revert KindSectionView logic NOT show an empty input fieldWalter Jang2015-06-083-31/+8
| | | | | | | | | | | | | | | | | | | | We don't need to make it optional to show an emtpy input field since we've changed our minds on not allowing users to add email and phone numbers on the compact editor. Bug 21661221 Change-Id: Iec0d3a37a76c787d17922dbc184142dfca98a9de
* | Check for null getCurrentFocus(). Fix NPEBrian Attwell2015-06-051-3/+5
|/ | | | | Bug: 21644090 Change-Id: If09f89d806410e4f6850f0fabdb00bfbe093a33d
* Merge "Hide software input when the Activity is closed." into mnc-devSeigo Nonaka2015-06-041-0/+10
|\
| * Hide software input when the Activity is closed.Seigo Nonaka2015-06-031-0/+10
| | | | | | | | | | | | | | | | | | Input method manager does not close software input when the text field focus is out. This is a workaround of Bug 20612313 by hiding in onPause callback manually. Bug: 20612313 Change-Id: I81d0c8e41b1df81c2383a361c56698a61afe89c8
* | Pass the preferred photo ID into the contact editorWalter Jang2015-06-037-15/+60
|/ | | | | | Bug 21498424 Change-Id: I35e8fa3cff4d963f8017bdd596132fe749479a17
* Merge "Don't allow newly writable contact splits" into mnc-devWalter Jang2015-06-021-2/+3
|\
| * Don't allow newly writable contact splitsWalter Jang2015-06-021-2/+3
| | | | | | | | | | | | | | | | It will result in an empty contact Bug 21464081 Change-Id: I36e79b82ff7d8d3002eabfe735bccda75ee110a7
* | Use new definitions of ProviderStatusBrian Attwell2015-06-022-16/+6
|/ | | | | | | And rebundle Contacts again. Bug: 21090207 Change-Id: I7e93e36ad0c0d667ac56983c76acb1b97bd8755c
* Merge "Can add mulitple email and phones on compact editor again" into mnc-devWalter Jang2015-06-021-10/+10
|\
| * Can add mulitple email and phones on compact editor againWalter Jang2015-06-011-10/+10
| | | | | | | | | | | | Bug 21162602 Change-Id: If484b5f3a0de2d6176863c19519ed63a45aa7c1d
* | Only use one hint color on contact editorsWalter Jang2015-06-013-73/+3
|/ | | | | | | | | | | Also, use the current 25% of black color which already follows the material guideline. Screenshots go/b21442589 Bug 21442589 Change-Id: I82c837fd9856c2165d3264a581165eb32702d807
* Use FLAG_GRANT_READ_URI_PERMISSION for ACTION_SENDBrian Attwell2015-05-281-28/+7
| | | | | | | | | Now that read/writing the profile only has a single permission associated with it, we can use the platform's existing grantUriPermission() support. Bug: 21090207 Change-Id: I31e6ae7b0f49c3589071f6a95f8d69a9456c144d
* Merge "Attach aggregation listener to super primary name field" into mnc-devWalter Jang2015-05-271-1/+3
|\
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-17 20:38:06 +0000