| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
TextFieldEditorView.isEmpty does not do the right thing
for structured names because that methods just checks every
child of the fields ViewGroup and the view retains values
for fields that may have been erased by toggling the
name expansion. The result is that the FIELD_TURNED_EMPTY
EditorListener event is never fired.
Bug 21851290
Change-Id: Iaae3ba102a899de9dfd76d0469c9c2f1d094b0bd
|
|
|
|
|
|
| |
Bug 19624360
Change-Id: Ia1166655d12748129f1281b102c95c1583380d5c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move delete ActionBar icon option back into the overflow
* Move the "More fields" option back to left alignment and
give it accent color
* Make unfocused fields 25% black
* Layout/padding tweaks
- Remove the 0 bottom padding on names so that all fields
have the same spacing between each other
- Use the min edit height on the "More fields" row
so that the spacing is the same as the other fields.
Bug 19729447
Change-Id: Ia11c74c1b65f96f937d6e51ed143f5f088b41561
|
|
|
|
| |
Change-Id: I31deaeeedc4ae49da6b0326b128767785cd01852
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't abort the save even if there are no unsaved changed
when returning the compact from the full editor
* No need to pass the material palette on insert intents.
It does, however, need to be passed back to the compact
editor when editing an existing contact w/o a picture.
* Fix returning to the compact editor repeatedly by
removing the Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET
on compact editor intents.
* Updated StructuredNameEditorView#getDisplayName to fall
back to the display name directly from the ValuesDelta.
This is required when the name is passed to the
contact editor, and the user does not change it, in which
case it will not be written to the underlying data
structure, and thus not passed subsequent expantions.
Bug 19624360
Change-Id: Ife285f3e411a869a76fbbff4d42939c866db617c
|
|
|
|
|
|
| |
Bug 19124091
Change-Id: Ib01df1b0dd222f1c21764ba3760f1f3b765bed32
|
|
|
|
|
|
|
|
|
|
| |
Note, StructuredName must be handled specially on inserts when it is
passed to the fully expanded editor when creating a new contact
because normally the contact name is not overriden.
Bug 19124091
Change-Id: I1d2b383c50b42a3624a7a8c18dd3278d7c3b069d
|
|
|
|
|
|
|
|
|
|
| |
The mocks show all name fields collapsed into a single field.
After deeper inspection, this proved to be poor UX. Instead
we show the three name types inside a single name section.
Screenshot: go/ba_screen_captures/contacts/b18004959_edit_screen_material/name_fields.png
Bug: 18004959
Change-Id: Ic06abcd151a64746cce32832b27e8f47ec6b981d
|
|
|
|
|
|
|
|
|
| |
This allows us to make a simplifying assumption for b/18004959.
After this, we can assume that updateEmptyEditors is never called
with emptyEditors.size() > 1 and findFocus() == null.
Bug: 18004959
Bug: 18194655
Change-Id: Idaf2c64bf3d359c1aa8938150a6cda3684542d42
|
|
|
|
| |
Change-Id: I77e79da6a57d0a6d6b92807495ec66d8a137c6d7
|
|
|
|
|
|
| |
This reverts commit 97b2ccd1e32457382dd5ce7c0ee2a3ab485d8be9.
Bug: 16558948
Change-Id: I736a55c33867e7442ac55417fcb2112c3d7d641d
|
|
|
|
|
|
|
|
|
|
|
| |
This CL simply moves classes from Contacts into ContactsCommon.
This is needed so that Dialer can use ContactLoader related code
for b/11294679. A ContactLoader will also be needed in the future
to allow InCallUI to download hi-res photos while in call.
Bug: 11294679
Change-Id: Ia033f3ea2406a907a4e71290c9ce810a5583dab8
|
|
|
|
|
|
|
|
|
| |
- Automatically create new raw contact when editing a read-only contact.
- Refactored mState to be always initialized.
- Allow RawContactDeltaList to be instantiated with empty constructor.
Bug: 6406182
Change-Id: I7a58625485dae6957b4f9bcc446122f54551afa1
|
|
|
|
|
| |
Bug: 6993891
Change-Id: I8b065c55100a152f72cccea5b62f10a8e30161c2
|
|
|
|
|
|
|
|
|
| |
Making ValuesDelta into top level class so we do not have to move
RawContactDelta into ContactsCommon. ValuesDelta is used by
CustomContactListFilterActivity which needs to be moved.
Bug: 6993891
Change-Id: If7371cf08ac0e14218fb790c96856e971fa613ec
|
|
|
|
|
|
|
| |
Moving dependencies in preparation to move AccountTypeManager.
Bug: 6993891
Change-Id: I804cdbe64b9b8111ed286037943d593e11dc4044
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Re-work of RawContact to be a real data container and removed un-necessary
dependencies.
- Removed un-necessary circular dependency between RawContact and DataItem.
- Cleaned up and made DataItem more compartmentalized by removing un-related
account methods.
- Implemented Parcelable for RawContact and NamedDataItem.
Bug: 6406182
Change-Id: Icd84f34d85e1349a86e473708cc7f8fece12349f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactoring abstracts out the need to directly
refer to Contacts database columns throughout the code. Instead,
all of this information is retained in getter/setter methods
within the Contact, RawContact, and DataItem classes and
sub-classes.
ContactLoader.Result class has been pulled to the top level as
the Contact class.
The Entity class has been removed and replaced with a RawContact
class, with getters/setters to raw contact information.
Renamed EntityDelta to RawContactDelta for better understandability
as well as adding getters/setters for specific fields in the
ValuesDelta nested class within EntityDelta. EntityDeltaList
and EntityModifier have been renamed to RawContactDeltaList and
RawContactModifier with the methods using the RawContact class
directly rather than the Entity class.
Data items for a raw contact are represented by a DataItem object
with specialized getters/setters for subclasses of DataItem.
(e.g., EmailDataItem, PhoneDataItem. etc.). DataItem is a wrapper
around ContentValues. This abstracts away the ContactsContract
column fields into getters/setters.
The above refactoring is accompanied with changes throughout the
codebase to use the new Contact, RawContact, and DataItem classes.
Change-Id: I31c1dccd724e9652f9d0af78ca81feb6c5acd71d
|
|
|
|
|
|
|
|
|
|
| |
Changed import order to be in accordance with style guide:
http://source.android.com/source/code-style.html#order-import-statements
Static imports will be placed at the top since most existing files used that
convention. It is also a style that can be handled by both eclipse and intellij.
Change-Id: Ia7013c7a2d88e5fefb8f4975d121f7fcd3fcc462
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In contact editor, the aggregation suggestions is
1 character behind because the ValuesDelta sent to
the AggergationSuggestionEngine contains a structured
name that is not fully synced with the display name.
The solution is to wait for the structured +
unstructured names to be synced before sending it
to the suggestion engine.
Bug: 5507256
Change-Id: I5f9b6da40ef7843a3b67dc9deaa2af3cbb68c477
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug: 5290661 Edited name for a contact not saved
When the contact editor was recreated on screen rotation the
data on the name editor was updated incorrectly.
The problem was that a change to any of the fields in the name editor
was erasing the other fields. Instead of erasing the other fields, i changed
the code to sync between the display name and structured name so that on
rotation, the data is correctly stored and retrieved.
Change-Id: I644bfea2af4e759e1d7d94aa09840ed15efd079d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For lists and headers, this is calculated by using a similar technique as we
use in the list view for highlighting text when the sort order and display
order do not match - we look for the overlap point between the display name
and the alternate display name, and bold the leading or trailing part, based
on the display order.
For the edit view, we convert the display name into a structured name (via an
API extracted from the structured name editor code that calls into the provider
to handle splitting), and then bold the span corresponding to the contact's
given name.
This also fixes an issue with the alternate display order in which we weren't
honoring that preference on the contact details view.
Change-Id: I6af048725541996cb303810a56a1ad79fc276e11
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove account selection step before contact creation
- (phone) put account info on the right side of photos
instead of having "header" for it
-- renamed header_* ids for account stuffs as they may not be
part of header any more.
- add migration functionality to EntityModifier
- add test for it
- no optimal layout
Bug: 4184675
Change-Id: I0e777f9aa37a7c9145bd430f897f8068b0bede56
|
|
|
|
|
| |
Bug: 4184675
Change-Id: Ibb20cb8b38d0272963fc5330c738bd17c61a5542
|
|
|
|
|
| |
Bug: 3497767
Change-Id: I68d54f07cd4e65843e90f8f819212798df018acd
|
|
|
|
|
| |
Bug: 2969875
Change-Id: Ifd7f1ba2e794ebf24626c53e5ed3a14ae9adc791
|
|
If the user does not change components of the structured
name, the expand and collapse operations in the editor
should not reparse or re-compose the name.
Bug: 3473362
Change-Id: I4fe5f0d06757b2fe098a5bd895c84108195049e9
|