From cf1df73719e171915eed887a5f06916158e42f04 Mon Sep 17 00:00:00 2001 From: John Reck Date: Wed, 27 Jul 2011 13:19:08 -0700 Subject: Fix dialog crash Bug: 5007226 This is sort of a "nuke it from orbit" fix to prevent the crash as it is a test blocker. Bug 5086504 filed to track a "proper" fix Change-Id: Ifd02a1fee05a05d61d70724a1ae758701679fc27 --- src/com/android/browser/GoogleAccountLogin.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'src/com/android/browser') diff --git a/src/com/android/browser/GoogleAccountLogin.java b/src/com/android/browser/GoogleAccountLogin.java index cd963464c..389656018 100644 --- a/src/com/android/browser/GoogleAccountLogin.java +++ b/src/com/android/browser/GoogleAccountLogin.java @@ -274,7 +274,15 @@ public class GoogleAccountLogin implements Runnable, Log.d(LOGTAG, "Finished login attempt for " + mAccount.name); mActivity.runOnUiThread(mRunnable); - mProgressDialog.dismiss(); + try { + mProgressDialog.dismiss(); + } catch (Exception e) { + // TODO: Switch to a managed dialog solution (DialogFragment?) + // Also refactor this class, it doesn't + // play nice with the activity lifecycle, leading to issues + // with the dialog it manages + Log.w(LOGTAG, "Failed to dismiss mProgressDialog: " + e.getMessage()); + } mRunnable = null; mActivity.runOnUiThread(new Runnable() { @Override -- cgit v1.2.3