From 2e53e1d150dd70b304c89f449fe656abe1ec3b04 Mon Sep 17 00:00:00 2001 From: "muzbit.kim" Date: Tue, 2 Apr 2013 15:24:41 +0900 Subject: Fix a Cursor leak When cursor is done, the cursor must be closed to avoid cursor leak. Change-Id: I44609478038ed3b5ea605eb9b3189fb28296a8e6 --- src/com/android/browser/BrowserBookmarksPage.java | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'src/com/android/browser/BrowserBookmarksPage.java') diff --git a/src/com/android/browser/BrowserBookmarksPage.java b/src/com/android/browser/BrowserBookmarksPage.java index b11162c71..af965f4b0 100644 --- a/src/com/android/browser/BrowserBookmarksPage.java +++ b/src/com/android/browser/BrowserBookmarksPage.java @@ -626,10 +626,18 @@ public class BrowserBookmarksPage extends Fragment implements View.OnCreateConte throw new IllegalArgumentException("Missing folder id!"); } Uri uri = BookmarkUtils.getBookmarksUri(mContext); - Cursor c = mContext.getContentResolver().query(uri, - null, BrowserContract.Bookmarks.PARENT + "=?", - new String[] {params[0].toString()}, null); - return c.getCount(); + Cursor c = null; + try { + c = mContext.getContentResolver().query(uri, + null, BrowserContract.Bookmarks.PARENT + "=?", + new String[] {params[0].toString()}, null); + + return c.getCount(); + } finally { + if ( c != null) { + c.close(); + } + } } @Override -- cgit v1.2.3