From 9907efcdb03d1e038b3923d6c58f907b1fda4c5e Mon Sep 17 00:00:00 2001 From: Ben Murdoch Date: Wed, 28 Oct 2009 13:22:46 +0000 Subject: When displaying a bookmark item, only truncate the Strings that we display in the ListView rather than the ones used to index into the bookmarks database. This caused a crash when bookmarks had titles longer than the text view limit. Fix for b/2219781 Change-Id: I4ea3cdfbaedce0dea6bd69f560aae9aea71ed7c1 --- src/com/android/browser/BrowserBookmarksAdapter.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'src/com/android/browser/BrowserBookmarksAdapter.java') diff --git a/src/com/android/browser/BrowserBookmarksAdapter.java b/src/com/android/browser/BrowserBookmarksAdapter.java index dd56d2f91..d1fdf076e 100644 --- a/src/com/android/browser/BrowserBookmarksAdapter.java +++ b/src/com/android/browser/BrowserBookmarksAdapter.java @@ -540,15 +540,8 @@ class BrowserBookmarksAdapter extends BaseAdapter { private void bind(BookmarkItem b, int position) { mCursor.moveToPosition(position- mExtraOffset); - String title = mCursor.getString(Browser.HISTORY_PROJECTION_TITLE_INDEX); - if (title.length() > BrowserSettings.MAX_TEXTVIEW_LEN) { - title = title.substring(0, BrowserSettings.MAX_TEXTVIEW_LEN); - } - b.setName(title); + b.setName(mCursor.getString(Browser.HISTORY_PROJECTION_TITLE_INDEX)); String url = mCursor.getString(Browser.HISTORY_PROJECTION_URL_INDEX); - if (url.length() > BrowserSettings.MAX_TEXTVIEW_LEN) { - url = url.substring(0, BrowserSettings.MAX_TEXTVIEW_LEN); - } b.setUrl(url); byte[] data = mCursor.getBlob(Browser.HISTORY_PROJECTION_FAVICON_INDEX); if (data != null) { -- cgit v1.2.3