diff options
| author | Michael Halcrow <mhalcrow@google.com> | 2014-11-26 09:09:16 -0800 |
|---|---|---|
| committer | Simon Shields <keepcalm444@gmail.com> | 2016-03-15 17:55:31 +1100 |
| commit | 74d8781c8987f23bb289d7b4eceb0c2bcf47686d (patch) | |
| tree | 625cd1ef337b01b58cdc7ea989eafa3a4ba26983 /fs | |
| parent | f35d99ecd31b7cea5d64434c41c6f6a52bd867f0 (diff) | |
| download | kernel_samsung_smdk4412-74d8781c8987f23bb289d7b4eceb0c2bcf47686d.tar.gz kernel_samsung_smdk4412-74d8781c8987f23bb289d7b4eceb0c2bcf47686d.tar.bz2 kernel_samsung_smdk4412-74d8781c8987f23bb289d7b4eceb0c2bcf47686d.zip | |
eCryptfs: Remove buggy and unnecessary write in file name decode routine
Dmitry Chernenkov used KASAN to discover that eCryptfs writes past the
end of the allocated buffer during encrypted filename decoding. This
fix corrects the issue by getting rid of the unnecessary 0 write when
the current bit offset is 2.
Change-Id: Id8e04a580e550495c46cd36fec430a1ec4342940
Signed-off-by: Michael Halcrow <mhalcrow@google.com>
Reported-by: Dmitry Chernenkov <dmitryc@google.com>
Suggested-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org # v2.6.29+: 51ca58d eCryptfs: Filename Encryption: Encoding and encryption functions
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ecryptfs/crypto.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index c6602d24517..dcf1fb542af 100644 --- a/fs/ecryptfs/crypto.c +++ b/fs/ecryptfs/crypto.c @@ -2036,7 +2036,6 @@ ecryptfs_decode_from_filename(unsigned char *dst, size_t *dst_size, break; case 2: dst[dst_byte_offset++] |= (src_byte); - dst[dst_byte_offset] = 0; current_bit_offset = 0; break; } |