diff options
| author | Jan Kara <jack@suse.cz> | 2008-07-25 01:46:50 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-25 10:53:35 -0700 |
| commit | 02a55ca87185e114e5d298a8d00608501dbabf67 (patch) | |
| tree | 958b60f8fb2936d7207146ff99be431c2c17edc5 /fs | |
| parent | b85f4b87a511bea86dac68c4f0fabaee2cac6c4c (diff) | |
| download | kernel_samsung_smdk4412-02a55ca87185e114e5d298a8d00608501dbabf67.tar.gz kernel_samsung_smdk4412-02a55ca87185e114e5d298a8d00608501dbabf67.tar.bz2 kernel_samsung_smdk4412-02a55ca87185e114e5d298a8d00608501dbabf67.zip | |
quota: cleanup loop in sync_dquots()
Make loop in sync_dquots() checking whether there's something to write
more readable, remove useless variable and macro info_any_dirty() which
is used only in this place.
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: "Vegard Nossum" <vegard.nossum@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/quota.c | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/fs/quota.c b/fs/quota.c index db1cc9f3c7a..7f4386ebc23 100644 --- a/fs/quota.c +++ b/fs/quota.c @@ -186,7 +186,7 @@ static void quota_sync_sb(struct super_block *sb, int type) void sync_dquots(struct super_block *sb, int type) { - int cnt, dirty; + int cnt; if (sb) { if (sb->s_qcop->quota_sync) @@ -198,11 +198,17 @@ void sync_dquots(struct super_block *sb, int type) restart: list_for_each_entry(sb, &super_blocks, s_list) { /* This test just improves performance so it needn't be reliable... */ - for (cnt = 0, dirty = 0; cnt < MAXQUOTAS; cnt++) - if ((type == cnt || type == -1) && sb_has_quota_enabled(sb, cnt) - && info_any_dirty(&sb_dqopt(sb)->info[cnt])) - dirty = 1; - if (!dirty) + for (cnt = 0; cnt < MAXQUOTAS; cnt++) { + if (type != -1 && type != cnt) + continue; + if (!sb_has_quota_enabled(sb, cnt)) + continue; + if (!info_dirty(&sb_dqopt(sb)->info[cnt]) && + list_empty(&sb_dqopt(sb)->info[cnt].dqi_dirty_list)) + continue; + break; + } + if (cnt == MAXQUOTAS) continue; sb->s_count++; spin_unlock(&sb_lock); |