diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2010-10-16 19:37:00 -0400 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2011-01-06 11:52:15 +0100 |
| commit | 5026e90b86684bc878e4db0a8cd043fed769719c (patch) | |
| tree | dca74ba7e855871158d8a58f3472503b4a5ec9ab /fs/ext3 | |
| parent | f0cad89f5e8ef8b6d0c065115565524137e44f0b (diff) | |
| download | kernel_samsung_smdk4412-5026e90b86684bc878e4db0a8cd043fed769719c.tar.gz kernel_samsung_smdk4412-5026e90b86684bc878e4db0a8cd043fed769719c.tar.bz2 kernel_samsung_smdk4412-5026e90b86684bc878e4db0a8cd043fed769719c.zip | |
ext3: Use search_dirblock() in ext3_dx_find_entry()
Use the search_dirblock() in ext3_dx_find_entry(). It makes the code
easier to read, and it takes advantage of common code. It also saves
100 bytes or so of text space.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Brad Spengler <spender@grsecurity.net>
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext3')
| -rw-r--r-- | fs/ext3/namei.c | 33 |
1 files changed, 12 insertions, 21 deletions
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index d093cbbe38b..9cc0b2c9664 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c @@ -975,12 +975,9 @@ static struct buffer_head * ext3_dx_find_entry(struct inode *dir, struct super_block *sb = dir->i_sb; struct dx_hash_info hinfo; struct dx_frame frames[2], *frame; - struct ext3_dir_entry_2 *de, *top; struct buffer_head *bh; unsigned long block; int retval; - int namelen = entry->len; - const u8 *name = entry->name; if (!(frame = dx_probe(entry, dir, &hinfo, frames, err))) return NULL; @@ -988,26 +985,20 @@ static struct buffer_head * ext3_dx_find_entry(struct inode *dir, block = dx_get_block(frame->at); if (!(bh = ext3_bread (NULL,dir, block, 0, err))) goto errout; - de = (struct ext3_dir_entry_2 *) bh->b_data; - top = (struct ext3_dir_entry_2 *) ((char *) de + sb->s_blocksize - - EXT3_DIR_REC_LEN(0)); - for (; de < top; de = ext3_next_entry(de)) { - int off = (block << EXT3_BLOCK_SIZE_BITS(sb)) - + ((char *) de - bh->b_data); - - if (!ext3_check_dir_entry(__func__, dir, de, bh, off)) { - brelse(bh); - *err = ERR_BAD_DX_DIR; - goto errout; - } - if (ext3_match(namelen, name, de)) { - *res_dir = de; - dx_release(frames); - return bh; - } + retval = search_dirblock(bh, dir, entry, + block << EXT3_BLOCK_SIZE_BITS(sb), + res_dir); + if (retval == 1) { + dx_release(frames); + return bh; } - brelse (bh); + brelse(bh); + if (retval == -1) { + *err = ERR_BAD_DX_DIR; + goto errout; + } + /* Check to see if we should continue to search */ retval = ext3_htree_next_block(dir, hinfo.hash, frame, frames, NULL); |