diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2016-12-16 13:42:06 -0500 |
|---|---|---|
| committer | Simon Shields <keepcalm444@gmail.com> | 2017-01-08 23:55:35 +1100 |
| commit | 9a7fc3e07911d1eceef278ecaa95c7f5f2d4bf37 (patch) | |
| tree | b5ee7b7ececcd7490679660dce9e92d13282090f /drivers | |
| parent | ca2a2d501c7268a26c8ff82ac510923a30de715b (diff) | |
| download | kernel_samsung_smdk4412-9a7fc3e07911d1eceef278ecaa95c7f5f2d4bf37.tar.gz kernel_samsung_smdk4412-9a7fc3e07911d1eceef278ecaa95c7f5f2d4bf37.tar.bz2 kernel_samsung_smdk4412-9a7fc3e07911d1eceef278ecaa95c7f5f2d4bf37.zip | |
sg_write()/bsg_write() is not fit to be called under KERNEL_DS
Both damn things interpret userland pointers embedded into the payload;
worse, they are actually traversing those. Leaving aside the bad
API design, this is very much _not_ safe to call with KERNEL_DS.
Bail out early if that happens.
Change-Id: I0d2f3b1ed4e763c559ecec98af32767360985e91
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/scsi/sg.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 4172f891f01..819c84bec38 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -543,6 +543,9 @@ sg_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos) sg_io_hdr_t *hp; unsigned char cmnd[MAX_COMMAND_SIZE]; + if (unlikely(segment_eq(get_fs(), KERNEL_DS))) + return -EINVAL; + if ((!(sfp = (Sg_fd *) filp->private_data)) || (!(sdp = sfp->parentdp))) return -ENXIO; SCSI_LOG_TIMEOUT(3, printk("sg_write: %s, count=%d\n", |