aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>2010-10-05 14:03:02 -0700
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2010-10-05 14:03:02 -0700
commit773e3f93577ffb493fb7c39b1a6ecf39b5748e87 (patch)
tree78340c40e26e3dbcbde66b013710b6c916ecc05b
parentb3a084b9b684622b149e8dcf03855bf0d5fb588b (diff)
downloadkernel_samsung_smdk4412-773e3f93577ffb493fb7c39b1a6ecf39b5748e87.tar.gz
kernel_samsung_smdk4412-773e3f93577ffb493fb7c39b1a6ecf39b5748e87.tar.bz2
kernel_samsung_smdk4412-773e3f93577ffb493fb7c39b1a6ecf39b5748e87.zip
rcu: move check from rcu_dereference_bh to rcu_read_lock_bh_held
As suggested by Linus, push the irqs_disabled() down to the rcu_read_lock_bh_held() level so that all callers get the benefit of the correct check. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
-rw-r--r--include/linux/rcupdate.h2
-rw-r--r--kernel/rcupdate.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index 83af1f8d8b7..9fbc54a2585 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -454,7 +454,7 @@ static inline notrace void rcu_read_unlock_sched_notrace(void)
* Makes rcu_dereference_check() do the dirty work.
*/
#define rcu_dereference_bh(p) \
- rcu_dereference_check(p, rcu_read_lock_bh_held() || irqs_disabled())
+ rcu_dereference_check(p, rcu_read_lock_bh_held())
/**
* rcu_dereference_sched - fetch RCU-protected pointer, checking for RCU-sched
diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c
index 4d169835fb3..0af1dc70fec 100644
--- a/kernel/rcupdate.c
+++ b/kernel/rcupdate.c
@@ -86,7 +86,7 @@ int rcu_read_lock_bh_held(void)
{
if (!debug_lockdep_rcu_enabled())
return 1;
- return in_softirq();
+ return in_softirq() || irqs_disabled();
}
EXPORT_SYMBOL_GPL(rcu_read_lock_bh_held);