kernel_samsung_smdk4412/drivers/usb/serial/io_ti.c, branch replicant-6.0

USB: io_ti: Fix NULL dereference in chase_port()

2013-06-07T19:46:48+00:00

commit 1ee0a224bc9aad1de496c795f96bc6ba2c394811 upstream.

The tty is NULL when the port is hanging up.
chase_port() needs to check for this.

This patch is intended for stable series.
The behavior was observed and tested in Linux 3.2 and 3.7.1.

Johan Hovold submitted a more elaborate patch for the mainline kernel.

[   56.277883] usb 1-1: edge_bulk_in_callback - nonzero read bulk status received: -84
[   56.278811] usb 1-1: USB disconnect, device number 3
[   56.278856] usb 1-1: edge_bulk_in_callback - stopping read!
[   56.279562] BUG: unable to handle kernel NULL pointer dereference at 00000000000001c8
[   56.280536] IP: [] _raw_spin_lock_irqsave+0x19/0x35
[   56.281212] PGD 1dc1b067 PUD 1e0f7067 PMD 0
[   56.282085] Oops: 0002 [#1] SMP
[   56.282744] Modules linked in:
[   56.283512] CPU 1
[   56.283512] Pid: 25, comm: khubd Not tainted 3.7.1 #1 innotek GmbH VirtualBox/VirtualBox
[   56.283512] RIP: 0010:[]  [] _raw_spin_lock_irqsave+0x19/0x35
[   56.283512] RSP: 0018:ffff88001fa99ab0  EFLAGS: 00010046
[   56.283512] RAX: 0000000000000046 RBX: 00000000000001c8 RCX: 0000000000640064
[   56.283512] RDX: 0000000000010000 RSI: ffff88001fa99b20 RDI: 00000000000001c8
[   56.283512] RBP: ffff88001fa99b20 R08: 0000000000000000 R09: 0000000000000000
[   56.283512] R10: 0000000000000000 R11: ffffffff812fcb4c R12: ffff88001ddf53c0
[   56.283512] R13: 0000000000000000 R14: 00000000000001c8 R15: ffff88001e19b9f4
[   56.283512] FS:  0000000000000000(0000) GS:ffff88001fd00000(0000) knlGS:0000000000000000
[   56.283512] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[   56.283512] CR2: 00000000000001c8 CR3: 000000001dc51000 CR4: 00000000000006e0
[   56.283512] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[   56.283512] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[   56.283512] Process khubd (pid: 25, threadinfo ffff88001fa98000, task ffff88001fa94f80)
[   56.283512] Stack:
[   56.283512]  0000000000000046 00000000000001c8 ffffffff810578ec ffffffff812fcb4c
[   56.283512]  ffff88001e19b980 0000000000002710 ffffffff812ffe81 0000000000000001
[   56.283512]  ffff88001fa94f80 0000000000000202 ffffffff00000001 0000000000000296
[   56.283512] Call Trace:
[   56.283512]  [] ? add_wait_queue+0x12/0x3c
[   56.283512]  [] ? usb_serial_port_work+0x28/0x28
[   56.283512]  [] ? chase_port+0x84/0x2d6
[   56.283512]  [] ? try_to_wake_up+0x199/0x199
[   56.283512]  [] ? tty_ldisc_hangup+0x222/0x298
[   56.283512]  [] ? edge_close+0x64/0x129
[   56.283512]  [] ? __wake_up+0x35/0x46
[   56.283512]  [] ? should_resched+0x5/0x23
[   56.283512]  [] ? tty_port_shutdown+0x39/0x44
[   56.283512]  [] ? usb_serial_port_work+0x28/0x28
[   56.283512]  [] ? __tty_hangup+0x307/0x351
[   56.283512]  [] ? usb_hcd_flush_endpoint+0xde/0xed
[   56.283512]  [] ? _raw_spin_lock_irqsave+0x14/0x35
[   56.283512]  [] ? usb_serial_disconnect+0x57/0xc2
[   56.283512]  [] ? usb_unbind_interface+0x5c/0x131
[   56.283512]  [] ? __device_release_driver+0x7f/0xd5
[   56.283512]  [] ? device_release_driver+0x1a/0x25
[   56.283512]  [] ? bus_remove_device+0xd2/0xe7
[   56.283512]  [] ? device_del+0x119/0x167
[   56.283512]  [] ? usb_disable_device+0x6a/0x180
[   56.283512]  [] ? usb_disconnect+0x81/0xe6
[   56.283512]  [] ? hub_thread+0x577/0xe82
[   56.283512]  [] ? __schedule+0x490/0x4be
[   56.283512]  [] ? abort_exclusive_wait+0x79/0x79
[   56.283512]  [] ? usb_remote_wakeup+0x2f/0x2f
[   56.283512]  [] ? usb_remote_wakeup+0x2f/0x2f
[   56.283512]  [] ? kthread+0x81/0x89
[   56.283512]  [] ? __kthread_parkme+0x5c/0x5c
[   56.283512]  [] ? ret_from_fork+0x7c/0xb0
[   56.283512]  [] ? __kthread_parkme+0x5c/0x5c
[   56.283512] Code: 8b 7c 24 08 e8 17 0b c3 ff 48 8b 04 24 48 83 c4 10 c3 53 48 89 fb 41 50 e8 e0 0a c3 ff 48 89 04 24 e8 e7 0a c3 ff ba 00 00 01 00
 0f c1 13 48 8b 04 24 89 d1 c1 ea 10 66 39 d1 74 07 f3 90 66
[   56.283512] RIP  [] _raw_spin_lock_irqsave+0x19/0x35
[   56.283512]  RSP 
[   56.283512] CR2: 00000000000001c8
[   56.283512] ---[ end trace 49714df27e1679ce ]---

Signed-off-by: Wolfgang Frisch 
Cc: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

USB: io_ti: fix get_icount for two port adapters

2013-03-28T19:06:04+00:00

commit 5492bf3d5655b4954164f69c02955a7fca267611 upstream.

Add missing get_icount field to two-port driver.

The two-port driver was not updated when switching to the new icount
interface in commit 0bca1b913aff ("tty: Convert the USB drivers to the
new icount interface").

Signed-off-by: Johan Hovold 
Signed-off-by: Greg Kroah-Hartman

usb: io_ti: Make edge_remove_sysfs_attrs the port_remove method.

2012-02-03T17:18:59+00:00

commit 6d443d8499e4e59ffb949759cdded32730f8d2f6 upstream.

Calling edge_remove_sysfs_attrs from edge_disconnect is too late
as the device has already been removed from sysfs.

Do the simple and obvious thing and make edge_remove_sysfs_attrs
the port_remove method.

Signed-off-by: Eric W. Biederman 
Reported-by: Wolfgang Frisch 
Signed-off-by: Greg Kroah-Hartman

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

tty: remove filp from the USB tty ioctls

2011-02-17T19:59:14+00:00

We don't use it so we can trim it from here as we try and stamp the file
object dependencies out of the serial code.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

tiocmset: kill the file pointer argument

2011-02-17T19:52:43+00:00

Doing tiocmget was such fun we should do tiocmset as well for the same
reasons

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

tiocmget: kill off the passing of the struct file

2011-02-17T19:47:33+00:00

We don't actually need this and it causes problems for internal use of
this functionality. Currently there is a single use of the FILE * pointer.
That is the serial core which uses it to check tty_hung_up_p. However if
that is true then IO_ERROR is also already set so the check may be removed.

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

2010-10-24T20:41:39+00:00

* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (39 commits)
  Update broken web addresses in arch directory.
  Update broken web addresses in the kernel.
  Revert "drivers/usb: Remove unnecessary return's from void functions" for musb gadget
  Revert "Fix typo: configuation => configuration" partially
  ida: document IDA_BITMAP_LONGS calculation
  ext2: fix a typo on comment in ext2/inode.c
  drivers/scsi: Remove unnecessary casts of private_data
  drivers/s390: Remove unnecessary casts of private_data
  net/sunrpc/rpc_pipe.c: Remove unnecessary casts of private_data
  drivers/infiniband: Remove unnecessary casts of private_data
  drivers/gpu/drm: Remove unnecessary casts of private_data
  kernel/pm_qos_params.c: Remove unnecessary casts of private_data
  fs/ecryptfs: Remove unnecessary casts of private_data
  fs/seq_file.c: Remove unnecessary casts of private_data
  arm: uengine.c: remove C99 comments
  arm: scoop.c: remove C99 comments
  Fix typo configue => configure in comments
  Fix typo: configuation => configuration
  Fix typo interrest[ing|ed] => interest[ing|ed]
  Fix various typos of valid in comments
  ...

Fix up trivial conflicts in:
	drivers/char/ipmi/ipmi_si_intf.c
	drivers/usb/gadget/rndis.c
	net/irda/irnet/irnet_ppp.c

tty: Convert the USB drivers to the new icount interface

2010-10-22T17:20:04+00:00

Simple pasting job using the new ops function. Also fix a couple of devices
directly returning the internal struct (which happens at this point to match
for the fields that matter but isn't correct or futureproof)

Signed-off-by: Alan Cox 
Signed-off-by: Greg Kroah-Hartman

USB: serial: io_ti.c: don't return 0 if writing the download record failed

2010-08-24T03:50:16+00:00

If the write download record failed we shouldn't return 0.

Signed-off-by: Roel Kluin 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman