aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* modems: xmm616: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-241/+247
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: svc.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-68/+67
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: ss.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-22/+20
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: snd.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-28/+26
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: sms.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-73/+75
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: sec.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-101/+105
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: sat.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-12/+12
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: samsung-ipc.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-44/+56
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: rfs.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-24/+24
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: pwr.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-16/+14
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: protocol.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-42/+40
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: pb.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-8/+6
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: net.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-66/+65
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: misc.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-28/+26
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: imei.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-5/+3
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: gprs.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-93/+93
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: gen.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-9/+7
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: disp.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-16/+14
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* includes: call.h: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-79/+80
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: utils: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-308/+322
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. For __FUNCTION__, according to checkpatch.pl, it's gcc specific: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ However __func__ is part of the C18 standard[1]. In the "6.4.2.2 Predefined identifiers" section, we have: "The identifier __func__ shall be implicitly declared by the translator as if, immediately following the opening brace of each function definition, the declaration static const char __func__[] = "function-name"; " Using symbolic permissions for file mode triggered a checkpatch.pl warning: WARNING: Symbolic permissions 'S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH' are not preferred. Consider using octal permissions '0644'. The rationale behind that is that octal is generally easier to understand than the symbolic relresentation. For more information, see the follwoing Linux commit: f90774e1fd27 checkpatch: look for symbolic permissions and suggest octal instead References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: svc: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-38/+38
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: sms: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-105/+135
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: sec: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-135/+152
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: rfs: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-570/+606
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. For __FUNCTION__, according to checkpatch.pl, it's gcc specific: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ However __func__ is part of the C18 standard[1]. In the "6.4.2.2 Predefined identifiers" section, we have: "The identifier __func__ shall be implicitly declared by the translator as if, immediately following the opening brace of each function definition, the declaration static const char __func__[] = "function-name"; " References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: net: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-59/+66
| | | | | | | This contains no functional changes. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: misc: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-28/+27
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: ipc_utils: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-533/+580
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: ipc: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-272-410/+431
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. For __FUNCTION__, according to checkpatch.pl, it's gcc specific: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ However __func__ is part of the C18 standard[1]. In the "6.4.2.2 Predefined identifiers" section, we have: "The identifier __func__ shall be implicitly declared by the translator as if, immediately following the opening brace of each function definition, the declaration static const char __func__[] = "function-name"; " References: ----------- [1]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: gprs: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-34/+37
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: gen: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-7/+5
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* samsung-ipc: call: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-74/+82
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* tools: nv_data-md5: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-58/+57
| | | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* tools: ipc-modem: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-271-393/+408
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This contains no functional changes. checkpatch.pl still produces warning on tools/ipc-modem.c but there were good reasons to ignore them: - Since there is no documentation for the samsung-ipc protocol, beside the libsamsung-ipc source code, the code that was commented out or between #if 0 #endif has been preserved as it could be relevant to the understanding of the protocol. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. - checkpatch also emits many warnings for "quoted string split across lines". The issue here is that we have conflicting rules in the code style. - In one hand there is a limit of 80 characters per line. - On the other hand, user-visible strings should not be broken because "that breaks the ability to grep for them"[1]. So the strings were split in a way that limit the probability of not finding them in grep. The assignment of the global declaration to 0 also triggered a checkpatch.pl error: ERROR: do not initialise globals to 0 So they were fixed as the fix shouldn't induce any functional change: In the the C18 standard draft[2] in the Semantics section of the Initialization section (6.7.9) we have: If an object that has static or thread storage duration is not initialized explicitly, then: [...] - if it has arithmetic type, it is initialized to (positive or unsigned) zero; References: ----------- [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v5.6#n81 [2]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* tools: ipc-test: switch to Linux code styleDenis 'GNUtoo' Carikli2020-06-251-95/+93
| | | | | | | | | | | | | | This contains no functional changes. The commented out code if any has also been preserved as it could be relevant to the understanding of the code. It will be kept until we understand why the code has been commented. In that case we either need to remove it completely or to replace it by a comment explaining why not having that code was necessary. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Add document explaining how to contribute to libsamsung-ipcDenis 'GNUtoo' Carikli2020-06-251-0/+46
| | | | | | | | This explains the policies and conventions that are already in place. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* check_code_style_conversion.py: also check files that are not the revision rangeDenis 'GNUtoo' Carikli2020-06-251-7/+10
| | | | | | | | | | | | | | | | | | | | This checks the files that aren't modified by any of the commits that are in the revision range. This is not completely failsafe as checkpatch.pl tend to check better what's touched by a patch, in the case of modifications that do not touch C code: - Checking for scripts/spelling.txt with checkpatch.pl -f doesn't raise any errors or warnings. - Checking the patch that adds scripts/spelling.txt raise a lot of warnings. However checkpatch.pl seem to find issues in C code regardless of whether the code is checked as part of individual files or as part of a patch. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* check_code_style_conversion.py: make sure we don't miss any filesDenis 'GNUtoo' Carikli2020-06-251-6/+28
| | | | | | | | | This adds an option to check if all the repository files were "converted" by checking if they all have been modified by a patch in the git revision range given. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* Add a tool to help check the conversion to Linux code styleDenis 'GNUtoo' Carikli2020-06-251-0/+83
| | | | | | | | | | | | | | | | | | | When sending a patch for Linux, and running checkpatch.pl, you typically only need to check the patch with it. However since we're doing an initial conversion to the Linux code style, we also need to check all the content of the files as well, as otherwise the parts that are not being touched by the patches won't be checked at all. We also need to get it right, as otherwise running checkpatch.pl on subsequent patches could trigger some errors that would not come from the patches being checked, but that would instead come from previous code style errors, that were left unfixed. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* Update MAINTAINERSDenis 'GNUtoo' Carikli2020-06-251-7/+8
| | | | | | | | | | | Paul Kocialkowski and Simon Busch are not active anymore in libsamsung-ipc. The file was also converted to the Linux format, to make it compatible with Linux's checkpatch.pl Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* Import checkpatch.pl from Linux v5.6 and configure it.Denis 'GNUtoo' Carikli2020-06-254-0/+8368
| | | | | | | | | | This will be used to check if the patches match Linux code style. The configuration is needed because otherwise the this tool has defaults parameters which are made for Linux. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> Reviewed-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
* Fix IPC_GPRS_FAIL_CAUSE_UNKOWN_PDP_CONTEXT typoDenis 'GNUtoo' Carikli2020-06-111-1/+1
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Fix ipc_sec_lock_infomation_response_data typoDenis 'GNUtoo' Carikli2020-06-111-1/+1
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Fix ipc_sec_lock_infomation_request_data typoDenis 'GNUtoo' Carikli2020-06-112-4/+4
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Fix ipc_sec_lock_infomation_setup typoDenis 'GNUtoo' Carikli2020-06-112-2/+2
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Fix IPC_SEC_LOCK_INFOMATION typoDenis 'GNUtoo' Carikli2020-06-112-3/+3
| | | | Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* ipc_client_gprs_specs handlers: pass the ipc_client structDenis 'GNUtoo' Carikli2020-02-286-14/+25
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: data_create/data_destroy handlers: pass the ipc_client structDenis 'GNUtoo' Carikli2020-02-2810-22/+40
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* devices: gprs activate/deactivate handlers: pass the ipc_client structDenis 'GNUtoo' Carikli2020-02-2812-27/+47
| | | | | | | | | This enables to use logging inside the callbacks. At this point the ipc_client struct is already available, so it is safe to do that. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* Android.mk: Also ship headersDenis 'GNUtoo' Carikli2020-02-281-0/+30
| | | | | | | | | | | | | Without that, the Android components that are using libsamsung-ipc have to hardcode the location of libsamsung-ipc to be able to access the headers. LOCAL_EXPORT_C_INCLUDE_DIRS also enables the other components depending on libsamsung-ipc to automatically add the exported header directory to the header search path during compilation. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
* modem: rename xmm626_sec_modem to xmm626_kernel_smdk4412Denis 'GNUtoo' Carikli2020-02-2110-183/+183
| | | | | | | | | | | | | | | | | | | | | | | | The XMM626 is the modem model, and SEC is a reference to Samsung Electronics. However, in practice the xmm626_sec_modem file and functions are tied to a specific kernel interface which is not upstream. In CyanogenMod, LineageOS and Replicant (up to the 6.0 version), most of the devices supported by libsamsung-ipc use a kernel named android_kernel_samsung_smdk4412, which implements this interface. So it is more clear to use a name that reflects that instead of using the generic xmm626_sec_modem name. Even if SMDK4412 is also a Samsung evaluation board for the Exynos 4412 System on a chip, the kernel name is probably way more known to people working on supporting devices with an XMM626 modem in libsamsung-ipc. Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>