hardware_replicant_libsamsung-ipc, branch main

configure.ac: fix lcov detection

2023-09-20T12:40:35+00:00

Signed-off-by: Denis 'GNUtoo' Carikli

configure.ac: fix typo with code_coverage_tests variable

2023-09-20T12:35:39+00:00

Signed-off-by: Denis 'GNUtoo' Carikli

configure.ac: --enable-samsung-ipc-device: error message: fix typo

2023-08-01T15:17:16+00:00

Signed-off-by: Denis 'GNUtoo' Carikli

Makefile.am: break line over 80 character

2023-08-01T15:17:16+00:00

Signed-off-by: Denis 'GNUtoo' Carikli

Fix and simplify code coverage support

2023-08-01T15:17:16+00:00

This also changes the way code coverage support work: before it was
supposed to build libsamsung-ipc again from a tarball.

This simplification also enables code coverage testing with release
tarballs as before, to prevent infinite recursion of tests it only run
the tests when running from a git checkout.

This bug was introduced in the
commit 2a83232e195af5434bfd8aaa7ec163b806405305 ("Add code coverage
support").

Signed-off-by: Denis 'GNUtoo' Carikli

scripts: guix.scm: switch from OpenSSL to LibreSSL

2023-08-01T15:17:16+00:00

Without that fix, it links against OpenSSL 3.0 which deprecated
MD5_Init, MD5_Update and MD5_Final. And so we end up with warnings
like that:
    samsung-ipc/rfs.c: In function ‘ipc_nv_data_md5_calculate’:
    samsung-ipc/rfs.c:75:9: error: ‘MD5_Init’ is deprecated: Since
    OpenSSL 3.0 [-Werror=deprecated-declarations]
    [...]
    samsung-ipc/rfs.c:76:9: error: ‘MD5_Update’ is deprecated: Since
    OpenSSL 3.0 [-Werror=deprecated-declarations]
    [...]
    samsung-ipc/rfs.c:78:9: error: ‘MD5_Final’ is deprecated: Since
    OpenSSL 3.0 [-Werror=deprecated-declarations]
but since we use -Werror the build fails.

If we simply update libsamsung-ipc to use the newer OpenSSL API, then
it will not compile anymore on older Android versions.

So to update libsamsung-ipc we would need to be compatible with both
older and newer OpenSSL APIs, and that requires a bit more work.

So if we don't want to do that work now, we need a drop-in replacement
package that implements the old OpenSSL API.

In addition using OpenSSL 3.x also bring up licensing consideration as
OpenSSL 3.x versions have changed license from the OpenSSL license
(which was compatible with the GPLv2) to the Apache 2.0 license (which
is only compatible with the GPLv3).

So that can limit the integration of libsamsung-ipc into daemons like
oFono that don't want to link against GPLv3+ libraries.

To avoid these downsides we have the choice between two drop-in
replacement packages: openssl-1.1 and libressl.

Since OpenSSL 1.1.1 will be supported until the 11th September
2023[1], we use LibreSSL in the hope that they will keep the MD5_*
interfaces longer.

[1]https://www.openssl.org/source/

Signed-off-by: Denis 'GNUtoo' Carikli

README: dependencies: Add missing curl

2023-02-17T16:59:51+00:00

If we remove curl, for instance from the libsamsung-ipc package in
scripts/guix.scm:
    -    (inputs (list curl openssl))
    +    (inputs (list openssl))

It then fails to build:
    checking for libcurl >= 7.62.0... no
    configure: error:
    Package requirements (libcurl >= 7.62.0) were not met:

This bug was introduced in commit 397cb23c6cd7e0cf941fd8292dc97c7b612756fd
("tools: Add tool to send SMS from a provider HTTPS interface").

Signed-off-by: Denis 'GNUtoo' Carikli

README: Fix "In order to compile" typo

2023-02-17T16:59:50+00:00

This bug was introduced in
commit 49e4a6eb6d0c3cb9f0f90453aa88c75bdbb93c94 ("Update documentation
in preparation of a new release").

Signed-off-by: Denis 'GNUtoo' Carikli

Enable static builds of (test) utilities

2023-02-17T16:59:50+00:00

Note that we cannot cross compile static binaries out of the box yet
with Guix. For instance if we use:
  guix build --target=arm-linux-gnueabihf --file=scripts/guix.scm

We end up with the following error:
    Backtrace:
    In guix/ui.scm:
        462:3 19 (_)
    In ice-9/boot-9.scm:
      1747:15 18 (with-exception-handler
                  # …)
      1752:10 17 (with-exception-handler _ _ #:unwind? _ # _)
    In guix/ui.scm:
        449:6 16 (_)
    In guix/scripts/build.scm:
        715:5 15 (_)
    In srfi/srfi-1.scm:
       673:15 14 (append-map _ _ . _)
       586:17 13 (map1 ("i686-linux"))
    In guix/scripts/build.scm:
       717:21 12 (_ _)
    In guix/store.scm:
      1377:11 11 (map/accumulate-builds
                  # …)
       1295:8 10 (call-with-build-handler
                  # …)
    In guix/scripts/build.scm:
       676:18  9 (_ _)
    In guix/store.scm:
      2165:25  8 (run-with-store
                  # # …)
      1993:13  7 (_ #)
    In guix/packages.scm:
      1899:40  6 (_)
      1517:16  5 (package->bag _ _ _ #:graft? _)
      1614:22  4 (thunk)
      1353:35  3 (lower* . _)
    In ice-9/boot-9.scm:
      1685:16  2 (raise-exception _ #:continuable? _)
      1685:16  1 (raise-exception _ #:continuable? _)
      1685:16  0 (raise-exception _ #:continuable? _)

    ice-9/boot-9.scm:1685:16: In procedure raise-exception:
    In procedure struct-vtable: Wrong type argument in position 1
    (expecting struct): #f

But if we remove the transformed packages from guix.scm, for instance by
removing them from the list of packages to build at the end of the file:
     (list libsamsung-ipc
           libsamsung-ipc-static
    -      (with-fixed-android-make-stub libsamsung-ipc-clang-android)
    -      (with-fixed-android-make-stub libsamsung-ipc-gcc-android)
           libsamsung-ipc-clang-autotools
           libsamsung-ipc-gcc-autotools)
cross compilation then works.

Thanks to the help from people on #autotools on liberachat for
suggestions on how to improve this patch.

Signed-off-by: Denis 'GNUtoo' Carikli

Add code coverage support

2023-02-17T16:59:50+00:00

Usage:
$ ./configure --enable-code-coverage-tests --enable-debug \
   --enable-samsung-ipc-device=fifo [...]
$ make check
$ sudo make install [...]

Signed-off-by: Denis 'GNUtoo' Carikli