From 8bff4af61219031345e7dae0c1840315e6bfab7f Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Fri, 2 Oct 2009 15:59:52 +0000 Subject: Fix a use-after-free in post-ra-scheduling. MI->addOperand invalidates references to it's operands, avoid touching the operand after a new one was added. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@83249 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/PostRASchedulerList.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'lib/CodeGen/PostRASchedulerList.cpp') diff --git a/lib/CodeGen/PostRASchedulerList.cpp b/lib/CodeGen/PostRASchedulerList.cpp index 902f50517c..662ab01a37 100644 --- a/lib/CodeGen/PostRASchedulerList.cpp +++ b/lib/CodeGen/PostRASchedulerList.cpp @@ -884,6 +884,7 @@ bool SchedulePostRATDList::ToggleKillFlag(MachineInstr *MI, // If any subreg of MO is live, then create an imp-def for that // subreg and keep MO marked as killed. + MO.setIsKill(false); bool AllDead = true; const unsigned SuperReg = MO.getReg(); for (const unsigned *Subreg = TRI->getSubRegisters(SuperReg); @@ -898,7 +899,8 @@ bool SchedulePostRATDList::ToggleKillFlag(MachineInstr *MI, } } - MO.setIsKill(AllDead); + if(AllDead) + MO.setIsKill(true); return false; } -- cgit v1.2.3