| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
1. Skip some frames to adjust AWB automatically on initial time.
2. Skip a frame when applying image effect
End-user doesn't see ugly frames when using camera applications by
above 2 approaches.
Change-Id: I8b4cc868a0a40164bfb3bc1e150c6d2dd351a1ba
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Bug fix: Exception occured when switching recording video mode
in night scene mode.
Change-Id: I8861082983bbcf02efbc246c26f37e1fcaa0d402
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
pid:3848
bug:3181349
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Adding checking preview status in CameraHardwareSec::stopPreview().
So if its status is not previewing, It doesn't call SecCamera::stopPreview.
Thus, buffers what be used by picture thread will not be cleared.
2. Adding killing thread and clear buffers in CameraHardwareSec::cancelPicture()
3. CameraHardwareSec::SplitFrame was modified to remove potential problem
about memory access.
fix : bug 3093595
Change-Id: Iefa85df297a6abdbb5fb7772b58e0c949aeda0de
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
| |
Change-Id: Ie8dea300c4ee5b9c1cd055301ae26fe44ceef68e
|
|
|
|
|
|
|
|
| |
Check preview status to prevent abnormal working by electronic
discharge.
Change-Id: Ie2d7f9de2cc2efa1c5d26bf445b9e75adff49650
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* put back fps high limit for front camera to 30 because
CTS showed it was getting frames faster than the advertised
limit of 15. since this is just a range, and user can't
request a specific frame rate anyway, there's no harm in
advertising that we "might" return faster frame rates.
* move stopRecord() in deinit to after m_cam_fd is closed,
since it uses it
* fix framerate check in setParameter() since now front and
back have different default frame rates
Change-Id: Id4a3eb35b99890782644a4c4315c637a57ae50bb
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
|
|
|
| |
User settings(i.e. color effects) was not kept when switching
camera between VGA camera and 5MP camera. It is fixed.
Change-Id: I76dd7cea6902b0adf5f1340deaf02448b41a5e8a
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
| |
This reverts commit a75b35c7a434a8e15015ed29b7168dac8d85dfb8.
bug - 3066130
Change-Id: I4d37d5cb0794c2790ec5b1d2848d916640562f95
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cleanup the way the camera HAL manages its threads so that
the exit path should no longer fail in a race condition.
The destructor waits for all threads to exit and heaps
are destroyed before closing the fd to driver.
Remove deadlock case (a HAL interface should not call a callback,
because the callback would try to grab a lock that is already
being held).
Removed mutex usage that wasn't needed (CameraServices already
has a mutex).
Add checks that could mess up the state of the sensor driver
(setting parameters or starting preview when a capture was still in
progress). We return errors in these cases instead.
Change-Id: I30d832de582a002dad1c087bd7cc7de43237eb19
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
|
|
|
| |
The camera sensors do not support postview sizes any other
than VGA, so if preview size is not VGA, skip showing the
postview.
Change-Id: Iae984e214a80f33e58fa4b8ec42bcdb1c33fae74
|
|
|
|
|
|
|
|
|
|
|
| |
Camera sensor change its frame rate by brightness.
It makes video that have too low fps in the dark.
So it use fixed frame rate on camcording mode.
Change-Id: I6ca4cf13e733629c75d244e79443b36b5dba59a5
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
pid:3640
|
|
|
|
|
|
|
|
|
| |
Binary version, ISO, focal-length, and flash informations
in EXIF are fixed correctly.
Change-Id: I2dbfd217ae1e1bb875848ba89c4633a93d337779
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
pid:3604
|
|
|
|
|
|
|
|
|
| |
fps for VGA: 7-15
focal length for VGA: 0.9 mm
Change-Id: Ie4c66e153ea925715795f3f7bbc280eb1c0fb819
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
pid:3639
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the check for fps range changes before the scene
mode check. Otherwise, we would change the fps range
out from under the caller and a previously valid
setting would become invalid suddenly.
Change-Id: I998a406387f76cd3f0a586ec61a86ea0fc3a311c
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
pid:3654
|
|
|
|
|
|
|
|
|
|
|
| |
startPreview() of SecCameraHWInterface.cpp should not invoke a
callback when startPreview fails. It will cause a deadlock.
CameraService was holding mLock in any method call from applications.
In those calls, camera HAL must not invoke a callback and it also
needs to acquire the mLock. startPreview should just return an error
and apps will get an exception.
Change-Id: I89f3a614a0efa56abcdde17ba5dd5f7a5e54911c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* don't save parameters that aren't valid
* correct the focal length exif info - should be 3.43mm
* update with right focus distance info for front camera
* correct thumbnail size in params to match HAL code
* fix advertized 1M picture size to match recent driver change
* don't generate thumbnails if size set to 0x0
* set right max preview size
* don't set scene mode if we don't have any in front camera
* update to latest fps ranges in rear sensor (min of 15fps in normal mode, 4fps in night mode)
* add support for GPS_TIMESTAMP, GPS_DATESTAMP, GPS_PROCESSING_METHOD
* remove gps settings if passed NULL
* move recording-size info to internal params
* workaround front camera not supporting get_iso and get_shot_time for now
* remove antibanding code since we don't support it
* ignore invalid jpeg quality settings
* reject fps max and min different than our current setting
* simplify scene mode settings. driver should have all the
right settings already for things like iso, sharpness, saturation,
etc. the HAL shouldn't set these separately because that will
just confuse and override the sensors own settings.
Change-Id: Ib6121cc1ceb650a993661d0ec7498a3472a1dd89
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Exposure value which setting automatically on auto focusing should
be kept until capturing picture or until stopping auto focusing
not until finishing auto focusing.
Change-Id: Id3e4bacb73325f2f19e871cd22a05843ac59967e
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
pid:3568
|
|
|
|
|
|
|
| |
Add thumbnail image in EXIF on capturing image of front camera
Change-Id: I4f6f4eca5c29f397f793ea6a802997a2d2c65dc7
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
| |
Front camera sensor doesn't support jpeg quality by itself.
Because It use H/W JPEG encoder for capturing picture.
So, It should be control in HAL.
Change-Id: I7f31fae9098b69c3b2ec20891f8b815931bee638
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
| |
for supporting torch mode of flash
fix: bugs 3064986
Change-Id: I7b5f822c232635640be7156b918b065623e04319
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
| |
The front-facing camera frames are un-mirrored. This hack
is no longer necessary.
bug:3059865
Change-Id: I5b8f3ea660abdc5c68c0d7d1b71878109336477d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialize the mSecCamera settings in initDefaultParameters in case
setParameter() isn't called by the application (it's not required).
Also had to bump the delay in SecCamera::DeinitCamera() or else
the next CTS test was not able to start because SecCamera::initCamera
would fail to open /dev/video0 because it hadn't been completely
released by the previous camera test.
Also updated focus distances for back camera with new info from TechWin.
Change-Id: Ib84890a466e5f96908a333423e4dcf146a744252
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
| |
Change-Id: If70052d910cc904ac29f048ad28bcbb5fa0ddda0
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
| |
bug:3105659
Change-Id: I0eac573df8c10878edbe33526983c8117c3baa5f
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of change to the interface between driver
and HAL so that driver doesn't do anything if a setting
is the same as current. The HAL part is to send all
settings for preview in one ioctl, instead of about
a dozen to save even more time (total is about 500ms).
Change-Id: I46392e970fd1725719359cdf7fb6ca2006beba4c
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
| |
Change-Id: I95ac2f0f94760ffe51a74a58361ce999c6766bfe
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
| |
Change-Id: Id522b0b386023223bdf19f65431e658417ec0508
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unofficial parameters so 3rd party apps don't start using
them and become incompatible with the offical Google API.
Put placeholders for new API KEY_SUPPORTED_PREVIEW_FPS_RANGE and
KEY_FOCUS_DISTANCES. Will update when we get info from HW team.
Simplify scene settings.
Fix a bunch of log messages and reduce unneeded chatter.
Fix callback result sent for CAMREA_MSG_FOCUS to be boolean since
that's what it's supposed to be.
Remove unneeded sleep in cancelAutoFocus.
Add FOCUS_MODE_INFINITY support (driver needs to go in first).
Change-Id: I10cb8e0f279d3229008fa04771c94bbf9e86d5d8
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
id:3180
|
|
|
|
|
|
|
| |
Also add EXIF data for front camera JPEGs, which is required
for snapshots to have the correct orientation.
Change-Id: I9298df87c0816950779d9a2a9d821dac198c5fd7
|
|
|
|
|
|
|
|
|
|
| |
Cleaned up parameters so that we advertise the
right features for the front and back cameras.
Also remove a lot of unsupported features.
Change-Id: I3b2fd77153c7855cccf27733ee87c1379d357be8
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
Signed-off-by: Mike J. Chen <mjchen@sta.samsung.com>
|
|
|
|
|
| |
Change-Id: I3333df8437bb54897df8594229ffcc1b23221f7f
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
|
| |
1. Fixed : Camera fail when setting exposure with negative value
2. Change: Added "1280x960" and removed "800x480" in supported resolutions
3. Change: Exposure time is adjusted in EXIF informations.
4. Change: Change flash mode parameter to "on,off,auto"
Change-Id: I8cdd2f200780a57e7a324d7f83afc1315b558ce1
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
| |
- add #if defined(BOARD_USES_OVERLAY) on postview
- remove global variable : buf_idx
- remove LOGE : ALL_BUFFERS_FLUSHED case is not error.
Change-Id: I1249b8c4ae25e4d4b6a493dcc54f451678dff964
Signed-off-by: hoony.yu <hoony.yu@samsung.com>
|
|
|
|
|
| |
Change-Id: I3df95e29de2ccd4cc4643205b6ce6eae6916d32b
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
| |
Also clean up supported picture sizes, frame rates and remove
use of hardcoded LCD dimensions.
Change-Id: I30a1035864f3a878ae58f2d6d649a91b5dc44a75
|
|
|
|
|
|
|
| |
Removed inconsistent coding style. Aligned better.
Change-Id: Ib6fa351cc39ede6881ed4937594689246b87bca8
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
| |
Change-Id: Id35655ae15e981065ffb8a9b14ed522559b53764
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
| |
3008600 After picture capture the preview screen goes black on Crespo
Change-Id: I86c1c4aa5c4e51b536186d4567e9ed2d571f280b
Signed-off-by: hoony.yu <hoony.yu@samsung.com>
|
|
|
|
|
| |
Signed-off-by: Mingyu Kim <mingyu0.kim@samsung.com>
Change-Id: I5b55678032bb633103ee596288cd7b7770596b87
|
|
|
|
|
|
|
| |
Also include it in the product definition so that it still gets
used when building crespo
Change-Id: I0ae91726222b40a259339cba4364d03ca74d7cff
|
|
|
|
|
|
|
|
|
|
|
|
| |
libs3cjpeg is library about JPEG encoding by H/W IP.
But libs3cjpeg is Samsung confidential library.
There is some license issues.
In addition, Google doesn't want using H/W JPEG encoder.
So It was modified for just working some function and building binary.
It doesn't work to capture the picture cause problem of jpeg encoding.
Change-Id: Ib5e1377d91a536002a2f94206bb3bdfdbc330688
Signed-off-by: Jeong-Seok Yang <jseok.yang@samsung.com>
|
|
|
|
|
|
|
|
|
| |
- add liboverlay source.
- add overlay option in BoardConfig.mk
- add overlay renderer on libcamera
- change the mode of video0,2
Change-Id: Icd392a80c0baa7b6e608a9b0cf57abfd74ae9f01
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two benefits:
-this follows the convention that all Android.mk files are included,
i.e. that reading an Android.mk file shows the entire picture.
-this allows some of the leaves to become non-conditional, to increase
the number of device-specific modules that are compiled in each build,
which allows catching build breakages earlier.
Change-Id: I060a4aecc4b5d53b9ca56f13b8599b8fa560f896
|
|
Change-Id: I4a6ee248b407c67682eb8884d1176f4807288c7c
|