diff options
| author | Yi Kong <yikong@google.com> | 2015-11-18 13:03:37 +0000 |
|---|---|---|
| committer | Yi Kong <yikong@google.com> | 2015-11-18 18:15:36 +0000 |
| commit | a94596daeb73486d928ab90e435ec36a37e2f6d9 (patch) | |
| tree | 121e064d9afac53bafbcccf538ec64d60b614ce1 /test/003-omnibus-opcodes | |
| parent | 3778c8769f05aafdc1bcc8064e8d1a9c1e008783 (diff) | |
| download | art-a94596daeb73486d928ab90e435ec36a37e2f6d9.tar.gz art-a94596daeb73486d928ab90e435ec36a37e2f6d9.tar.bz2 art-a94596daeb73486d928ab90e435ec36a37e2f6d9.zip | |
Fix 003-omnibus-opcodes
by directly comparing floating point to avoid loss of accuracy from
toString method.
Bug: 25714175
Change-Id: I38923c9a5d0d7c14199d5830226cc5a5d2a0f365
Diffstat (limited to 'test/003-omnibus-opcodes')
| -rw-r--r-- | test/003-omnibus-opcodes/expected.txt | 8 | ||||
| -rw-r--r-- | test/003-omnibus-opcodes/src/FloatMath.java | 14 |
2 files changed, 6 insertions, 16 deletions
diff --git a/test/003-omnibus-opcodes/expected.txt b/test/003-omnibus-opcodes/expected.txt index b591a7a024..ee25ec10e6 100644 --- a/test/003-omnibus-opcodes/expected.txt +++ b/test/003-omnibus-opcodes/expected.txt @@ -31,15 +31,7 @@ FloatMath.doubleOperTest FloatMath.checkConvI FloatMath.checkConvL FloatMath.checkConvF - 0: -2.0054409E9 - 1: -8.613303E18 - 2: -3.1415927 --2.0054409E9, -8.6133031E18, -3.1415927 FloatMath.checkConvD - 0: -2.005440939E9 - 1: -8.613303245920329E18 - 2: 123.45600128173828 --2.005440939E9, -8.6133032459203287E18, 123.4560012817382 FloatMath.checkConsts FloatMath.jlmTests IntMath.testIntCompare diff --git a/test/003-omnibus-opcodes/src/FloatMath.java b/test/003-omnibus-opcodes/src/FloatMath.java index a0bc9f46dd..96befe9cdc 100644 --- a/test/003-omnibus-opcodes/src/FloatMath.java +++ b/test/003-omnibus-opcodes/src/FloatMath.java @@ -245,10 +245,9 @@ public class FloatMath { } static void checkConvF(float[] results) { System.out.println("FloatMath.checkConvF"); - // TODO: Main.assertTrue values - for (int i = 0; i < results.length; i++) - System.out.println(" " + i + ": " + results[i]); - System.out.println("-2.0054409E9, -8.6133031E18, -3.1415927"); + Main.assertTrue(results[0] == -2.0054409E9f); + Main.assertTrue(results[1] == -8.613303E18f); + Main.assertTrue(results[2] == -3.1415927f); } static double[] convD(int i, long l, float f) { @@ -260,10 +259,9 @@ public class FloatMath { } static void checkConvD(double[] results) { System.out.println("FloatMath.checkConvD"); - // TODO: Main.assertTrue values - for (int i = 0; i < results.length; i++) - System.out.println(" " + i + ": " + results[i]); - System.out.println("-2.005440939E9, -8.6133032459203287E18, 123.4560012817382"); + Main.assertTrue(results[0] == -2.005440939E9); + Main.assertTrue(results[1] == -8.6133032459203287E18); + Main.assertTrue(results[2] == 123.45600128173828); } static void checkConsts() { |