diff options
author | Andreas Gampe <agampe@google.com> | 2015-01-13 19:11:14 +0000 |
---|---|---|
committer | Andreas Gampe <agampe@google.com> | 2015-01-13 19:11:14 +0000 |
commit | 6e73272f093e9dc045c08baae57eebb5dcd6e044 (patch) | |
tree | bffd41529429f9b654ab6824c368191dd5e97719 /compiler | |
parent | 54953dfdcb3bb8896d8af2d20adef84fb740ce77 (diff) | |
download | art-6e73272f093e9dc045c08baae57eebb5dcd6e044.tar.gz art-6e73272f093e9dc045c08baae57eebb5dcd6e044.tar.bz2 art-6e73272f093e9dc045c08baae57eebb5dcd6e044.zip |
Revert "ART: dex2oat flag for HGraphVisualizer dump file"
Breaks compilation of tests.
This reverts commit 54953dfdcb3bb8896d8af2d20adef84fb740ce77.
Change-Id: I868b876c3130be61f1169c5fccdffc0368bee11e
Diffstat (limited to 'compiler')
-rw-r--r-- | compiler/driver/compiler_driver.cc | 4 | ||||
-rw-r--r-- | compiler/driver/compiler_driver.h | 6 | ||||
-rw-r--r-- | compiler/optimizing/optimizing_compiler.cc | 5 |
3 files changed, 3 insertions, 12 deletions
diff --git a/compiler/driver/compiler_driver.cc b/compiler/driver/compiler_driver.cc index e37180768a..9985d66469 100644 --- a/compiler/driver/compiler_driver.cc +++ b/compiler/driver/compiler_driver.cc @@ -339,8 +339,7 @@ CompilerDriver::CompilerDriver(const CompilerOptions* compiler_options, const InstructionSetFeatures* instruction_set_features, bool image, std::set<std::string>* image_classes, std::set<std::string>* compiled_classes, size_t thread_count, - bool dump_stats, bool dump_passes, - const std::string& dump_cfg_file_name, CumulativeLogger* timer, + bool dump_stats, bool dump_passes, CumulativeLogger* timer, int swap_fd, const std::string& profile_file) : swap_space_(swap_fd == -1 ? nullptr : new SwapSpace(swap_fd, 10 * MB)), swap_space_allocator_(new SwapAllocator<void>(swap_space_.get())), @@ -362,7 +361,6 @@ CompilerDriver::CompilerDriver(const CompilerOptions* compiler_options, stats_(new AOTCompilationStats), dump_stats_(dump_stats), dump_passes_(dump_passes), - dump_cfg_file_name_(dump_cfg_file_name), timings_logger_(timer), compiler_context_(nullptr), support_boot_image_fixup_(instruction_set != kMips), diff --git a/compiler/driver/compiler_driver.h b/compiler/driver/compiler_driver.h index 11b4329e32..7ddc32cdd8 100644 --- a/compiler/driver/compiler_driver.h +++ b/compiler/driver/compiler_driver.h @@ -97,7 +97,6 @@ class CompilerDriver { bool image, std::set<std::string>* image_classes, std::set<std::string>* compiled_classes, size_t thread_count, bool dump_stats, bool dump_passes, - const std::string& dump_cfg_file_name, CumulativeLogger* timer, int swap_fd, const std::string& profile_file); @@ -372,10 +371,6 @@ class CompilerDriver { return dump_passes_; } - const std::string& GetDumpCfgFileName() const { - return dump_cfg_file_name_; - } - CumulativeLogger* GetTimingsLogger() const { return timings_logger_; } @@ -547,7 +542,6 @@ class CompilerDriver { bool dump_stats_; const bool dump_passes_; - const std::string& dump_cfg_file_name_; CumulativeLogger* const timings_logger_; diff --git a/compiler/optimizing/optimizing_compiler.cc b/compiler/optimizing/optimizing_compiler.cc index eaecbb04ae..692d452f54 100644 --- a/compiler/optimizing/optimizing_compiler.cc +++ b/compiler/optimizing/optimizing_compiler.cc @@ -149,12 +149,11 @@ void OptimizingCompiler::Init() { // Enable C1visualizer output. Must be done in Init() because the compiler // driver is not fully initialized when passed to the compiler's constructor. CompilerDriver* driver = GetCompilerDriver(); - const std::string cfg_file_name = driver->GetDumpCfgFileName(); - if (!cfg_file_name.empty()) { + if (driver->GetDumpPasses()) { CHECK_EQ(driver->GetThreadCount(), 1U) << "Graph visualizer requires the compiler to run single-threaded. " << "Invoke the compiler with '-j1'."; - visualizer_output_.reset(new std::ofstream(cfg_file_name)); + visualizer_output_.reset(new std::ofstream("art.cfg")); } } |