power: Clean up and fix set_interactive_override

* Remove debug logs and useless comments
* Consistent return values
* Add back display hints for legacy platforms, they used to live in
  power-common.c but removed in commit 561cffcbfa66192e839e040d2da3bff2ecf8dcac
* Check if set_interactive_override handled hints and print
  info message if it didn't

Change-Id: Iff9f7327ba71c282e34ff3143c45a3f40f72fc92

1 files changed, 2 insertions, 7 deletions

diff --git a/power-845.c b/power-845.c
index aaf355b..d952111 100644
--- a/power-845.c
+++ b/power-845.c
@@ -209,12 +209,8 @@ int set_interactive_override(int on) {
     static const char* display_off = "0";
     char err_buf[80];
     static int init_interactive_hint = 0;
-    static int set_i_count = 0;
     int rc = 0;
 
-    set_i_count++;
-    ALOGI("Got set_interactive hint on= %d, count= %d\n", on, set_i_count);
-
     if (init_interactive_hint == 0) {
         // First time the display is turned off
         display_fd = TEMP_FAILURE_RETRY(open(SYS_DISPLAY_PWR, O_RDWR));
@@ -224,7 +220,7 @@ int set_interactive_override(int on) {
         } else
             init_interactive_hint = 1;
     } else if (!on) {
-        /* Display off. */
+        /* Display off */
         rc = TEMP_FAILURE_RETRY(write(display_fd, display_off, strlen(display_off)));
         if (rc < 0) {
             strerror_r(errno, err_buf, sizeof(err_buf));
@@ -238,6 +234,5 @@ int set_interactive_override(int on) {
             ALOGE("Error writing %s to  %s: %s\n", display_on, SYS_DISPLAY_PWR, err_buf);
         }
     }
-
-    return HINT_HANDLED; /* Don't excecute this code path, not in use */
+    return HINT_HANDLED;
 }