summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Bestas <mkbestas@lineageos.org>2018-03-26 01:00:20 +0300
committerMichael Bestas <mkbestas@lineageos.org>2019-10-23 01:12:56 +0300
commitc3942652f9d6d56e390223934ca7eb8a1ebd7d46 (patch)
treebbce12695470fb4cdf4ce811f8505fefd1aa2535
parent9cdea7baf4392d87cf0a55d24837f6fd0d6faa96 (diff)
downloadvendor_qcom_opensource_power-c3942652f9d6d56e390223934ca7eb8a1ebd7d46.tar.gz
vendor_qcom_opensource_power-c3942652f9d6d56e390223934ca7eb8a1ebd7d46.tar.bz2
vendor_qcom_opensource_power-c3942652f9d6d56e390223934ca7eb8a1ebd7d46.zip
power: Compile with -Wall -Wextra -Werror
* And fix the build errors Change-Id: I183203edfd92d4672893d74aa7428bc9f5e17772
-rw-r--r--Android.mk2
-rw-r--r--power-660.c7
-rw-r--r--power-8226.c4
-rw-r--r--power-8610.c4
-rw-r--r--power-8909.c1
-rw-r--r--power-8916.c2
-rw-r--r--power-8952.c4
-rw-r--r--power-8953.c6
-rw-r--r--power-msmnile.c2
9 files changed, 16 insertions, 16 deletions
diff --git a/Android.mk b/Android.mk
index 41d1993..7f3cdb8 100644
--- a/Android.mk
+++ b/Android.mk
@@ -28,6 +28,8 @@ LOCAL_SRC_FILES := \
service.cpp \
Power.cpp
+LOCAL_CFLAGS += -Wall -Wextra -Werror
+
ifneq ($(BOARD_POWER_CUSTOM_BOARD_LIB),)
LOCAL_WHOLE_STATIC_LIBRARIES += $(BOARD_POWER_CUSTOM_BOARD_LIB)
else
diff --git a/power-660.c b/power-660.c
index 15f9d02..4d4ca14 100644
--- a/power-660.c
+++ b/power-660.c
@@ -52,11 +52,9 @@
#define MIN_VAL(X, Y) ((X > Y) ? (Y) : (X))
static int video_encode_hint_sent;
-static int cam_preview_hint_sent;
static int camera_hint_ref_count;
static void process_video_encode_hint(void* metadata);
-// static void process_cam_preview_hint(void *metadata);
/**
* Returns true if the target is SDM630/SDM455.
@@ -81,17 +79,16 @@ int power_hint_override(power_hint_t hint, void* data) {
process_video_encode_hint(data);
return HINT_HANDLED;
}
+ default:
+ break;
}
return HINT_NONE;
}
int set_interactive_override(int on) {
char governor[80];
- char tmp_str[NODE_MAX];
int resource_values[20];
int num_resources;
- struct video_encode_metadata_t video_encode_metadata;
- int rc;
ALOGI("Got set_interactive hint");
diff --git a/power-8226.c b/power-8226.c
index 7ac90ea..a53cc72 100644
--- a/power-8226.c
+++ b/power-8226.c
@@ -47,7 +47,7 @@
#include "power-common.h"
#include "utils.h"
-int power_hint_override(power_hint_t hint, void* data) {
+int power_hint_override(power_hint_t hint, void* UNUSED(data)) {
switch (hint) {
case POWER_HINT_INTERACTION: {
int resources[] = {0x702, 0x20B, 0x30B};
@@ -56,6 +56,8 @@ int power_hint_override(power_hint_t hint, void* data) {
interaction(duration, ARRAY_SIZE(resources), resources);
return HINT_HANDLED;
}
+ default:
+ break;
}
return HINT_NONE;
}
diff --git a/power-8610.c b/power-8610.c
index 7ac90ea..a53cc72 100644
--- a/power-8610.c
+++ b/power-8610.c
@@ -47,7 +47,7 @@
#include "power-common.h"
#include "utils.h"
-int power_hint_override(power_hint_t hint, void* data) {
+int power_hint_override(power_hint_t hint, void* UNUSED(data)) {
switch (hint) {
case POWER_HINT_INTERACTION: {
int resources[] = {0x702, 0x20B, 0x30B};
@@ -56,6 +56,8 @@ int power_hint_override(power_hint_t hint, void* data) {
interaction(duration, ARRAY_SIZE(resources), resources);
return HINT_HANDLED;
}
+ default:
+ break;
}
return HINT_NONE;
}
diff --git a/power-8909.c b/power-8909.c
index 4c1506a..47dc814 100644
--- a/power-8909.c
+++ b/power-8909.c
@@ -50,7 +50,6 @@
static void process_video_encode_hint(void* metadata) {
char governor[80];
struct video_encode_metadata_t video_encode_metadata;
- char tmp_str[NODE_MAX];
if (get_scaling_governor(governor, sizeof(governor)) == -1) {
ALOGE("Can't obtain scaling governor.");
diff --git a/power-8916.c b/power-8916.c
index a8ed760..1ad6ab9 100644
--- a/power-8916.c
+++ b/power-8916.c
@@ -71,7 +71,7 @@ static bool is_target_8916(void) {
return is_8916;
}
-int power_hint_override(power_hint_t hint, void* data) {
+int power_hint_override(power_hint_t hint, void* UNUSED(data)) {
switch (hint) {
case POWER_HINT_VSYNC:
break;
diff --git a/power-8952.c b/power-8952.c
index 4918bf0..585eb58 100644
--- a/power-8952.c
+++ b/power-8952.c
@@ -80,14 +80,14 @@ int power_hint_override(power_hint_t hint, void* data) {
process_video_encode_hint(data);
return HINT_HANDLED;
}
+ default:
+ break;
}
return HINT_NONE;
}
int set_interactive_override(int on) {
char governor[80];
- char tmp_str[NODE_MAX];
- struct video_encode_metadata_t video_encode_metadata;
int rc = 0;
static const char* display_on = "1";
diff --git a/power-8953.c b/power-8953.c
index f0d2d6f..ff1e323 100644
--- a/power-8953.c
+++ b/power-8953.c
@@ -52,11 +52,9 @@
#define MIN_VAL(X, Y) ((X > Y) ? (Y) : (X))
static int video_encode_hint_sent;
-static int cam_preview_hint_sent;
static int camera_hint_ref_count;
static void process_video_encode_hint(void* metadata);
-// static void process_cam_preview_hint(void *metadata);
static int display_fd;
#define SYS_DISPLAY_PWR "/sys/kernel/hbtp/display_pwr"
@@ -84,14 +82,14 @@ int power_hint_override(power_hint_t hint, void* data) {
process_video_encode_hint(data);
return HINT_HANDLED;
}
+ default:
+ break;
}
return HINT_NONE;
}
int set_interactive_override(int on) {
char governor[80];
- char tmp_str[NODE_MAX];
- struct video_encode_metadata_t video_encode_metadata;
int rc = 0;
static const char* display_on = "1";
diff --git a/power-msmnile.c b/power-msmnile.c
index 2888f73..965eb9d 100644
--- a/power-msmnile.c
+++ b/power-msmnile.c
@@ -86,7 +86,7 @@ int set_interactive_override(int on) {
return HINT_HANDLED;
}
-int power_hint_override(power_hint_t hint, void* data) {
+int power_hint_override(power_hint_t hint, void* UNUSED(data)) {
int ret_val = HINT_NONE;
switch (hint) {
case POWER_HINT_INTERACTION: {