From 8f7b9e3d39cdae8363816aa7bcbab0d79fd70cea Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Wed, 27 Jul 2016 16:25:51 -0700 Subject: Fix clang-tidy performance warnings in syste/core. * Use const reference type for parameters to avoid unnecessary copy. * Suppress warning of not using faster overloaded string find function. Bug: 30407689 Bug: 30411878 Change-Id: I6cfdbbd50cf5e8f3db6e5263076d3a17a9a791ee Test: build with WITH_TIDY=1 Merged-In: Ie79dbe21899867bc62031f8618bb1322b8071525 --- libbacktrace/backtrace_offline_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libbacktrace') diff --git a/libbacktrace/backtrace_offline_test.cpp b/libbacktrace/backtrace_offline_test.cpp index 88a3533a2..d6dc2c960 100644 --- a/libbacktrace/backtrace_offline_test.cpp +++ b/libbacktrace/backtrace_offline_test.cpp @@ -73,7 +73,7 @@ static ucontext_t GetUContextFromUnwContext(const unw_context_t& unw_context) { return ucontext; } -static void OfflineBacktraceFunctionCall(std::function function, +static void OfflineBacktraceFunctionCall(const std::function& function, std::vector* pc_values) { // Create a thread to generate the needed stack and registers information. g_exit_flag = false; -- cgit v1.2.3