| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| | |
am: 94b9e4df04
Change-Id: I2dc89613d382ea5fd86bd1a1736310d3e8e49dbc
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Sdcardfs has been modified to use bind mounts
in place of three separate mounts. This lowers
resource usage, and removes a number of race
conditions around updates via differnt views.
Test: Run storage cts tests with sdcardfs enabled
Change-Id: Icdc196ba3d6f46d54d27ef91c01ffebcf81dd47e
|
|\|
| |
| |
| |
| |
| |
| |
| | |
FUSE_INIT."
am: 0673412bb9
Change-Id: I85e6be67fdd5285c2abc26a097301c7136a676f9
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We return the minor version number 15 to FUSE_INIT since we don't handle
BATCH_FORGET. Thus the kernel does not accept the latest size of
fuse_init_out. Instead we need to use FUSE_COMPAT_22_INIT_OUT_SIZE.
Previously the code unintentionally used FUSE_COMPAT_22_INIT_OUT_SIZE always
because we override the minor version out->minor to 15. Because sdcard.c shares
the buffer for |in| and |out|, it overrides the version number of in->minnor as
well.
The if closure in the previous code "if (in->minor <= 22)" was always true. The
CL removes the if closure to explicitly use FUSE_COMPAT_22_INIT_OUT_SIZE always.
Bug: 32779923
Test: Manually boot Android and check if the storage shows up in Settings app.
Change-Id: Ibbc50da7fb82be148acfc5f1a3d46fefbe211f9d
|
|\|
| |
| |
| |
| |
| | |
am: c2eaefdd15
Change-Id: I800d48fb1d74531681cdcd35fcd3ea674e7c3025
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Add TEMP_FAILURE_RETRY around all relevant system calls.
- Cleanup some of the read calls.
- Add error log messages when read/write calls do not actually read/write the
expected number of bytes.
- Add error messages for write failures in fuse_status/fuse_replay.
Test: Attached to the sdcard process and stepped through most of the modified
Test: code. Also, create/read/write/delete files in /storage/emulated/0
Test: directory.
Change-Id: I73e4c0db861960f4c0af1bf96b06cd61fa74be69
|
|\ \
| |/
|/|
| |
| |
| | |
am: 5f4db94228
Change-Id: I05fbf1cffb44595d354219b1753cd7c2b37e10db
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use a non yet maintainer reviewed kernel patch from QCOM that greatly
improves IO speed in case it is available from the device specific
kernel headers.
Bug: 24216004
Bug: 30222859
Change-Id: I4101d80082c9ad9d042dde5c620ddb309d193d52
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A few changes got dropped along merge resolution. This adds them back
Affected CLs:
Ie188cb044be2ad87166f2d43c32a1f6b97660de0
Ibdb72ad16a1e6c3a01edcb03d003c42de7a03cd6
Change-Id: I1924f5a4bd7564ceaf9bb3a45b7fb7804b3619d7
|
| |
| |
| |
| |
| |
| | |
Bug: 30222003
Change-Id: I3d0a29cb92e83416eb6851b54cb72886da4f7cf2
(cherry picked from commit a65f3e1a1fdaf2a23f0cea0d0aedee81117a6e1a)
|
|\ \
| | |
| | |
| | |
| | |
| | | |
am: 47b077a44f
Change-Id: Ib0a0b5083d09d60bd0ee42bebcecced05b3645e5
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use C++ logging for everything.
Bug: 30222003
Change-Id: I5c5d85102b01df6965a515b59aa275ac85f50f00
|
|\| |
| | |
| | |
| | | |
Change-Id: I65550ff841d27f985a3ab8618ecdf4a3500fb0be
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
"PRI{u,x}64" was not compiling on C++ because of macro expansions.
Implement DLOG the same way DCHECK is implemented in
<android-base/logging.h>, and mechanically replace the problematic
lines with C++ logging. Remaining TRACE() lines will be replaced in a
follow-up CL.
Bug: 30222003
Change-Id: I377a91722eb4c035093fc96b79438c4f638b9a45
|
|\| |
| | |
| | |
| | |
| | |
| | | |
am: c15ab6e2c6
Change-Id: Icacd305ffdf501ce6d7a6bbdd73d5f245575d804
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Having CaseInsensitiveCompare use strcasecomp is not ideal, but other
solutions are not prettier.
Also, add a TODO to fix FUSE_TRACE, broken by the switch to C++.
Bug: 27147273
Change-Id: I0017c3a7d0254eb81abd128b97cd06c5ad0d1dff
|
|\| |
| | |
| | |
| | |
| | |
| | | |
am: ddbcecec3a
Change-Id: Ia8405d8bc181b1cdbf1f0812c0dbe8f7701747ef
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Also make adbd use ScopedMinijail.
Bug: 30191189
Change-Id: I5e259aa466817b51037912aba043ba75bd35f9e1
|
|\| |
| | |
| | |
| | |
| | |
| | | |
am: 97f49e5cb3
Change-Id: I032ea3fcdac1a16bf36d43731b8533214264fee2
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Having so many copies of privilege-dropping code leads to errors.
De-duplicate this code and use Minijail for it.
Bug: 30156807
Change-Id: I36c85962b913a12efe5648a23cbacc5bcbb3853c
|
|\| |
| | |
| | |
| | |
| | |
| | | |
am: a17427cb1e
Change-Id: Ie112f67f724e511b6c8ffabd0db04f3e017132cc
|
| |\ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix string literals and cast void* appropriately. Alternatively, we
could switch some of the allocations to new/delete, but we would need
to make sure that none of those end up passed to other code that will
call free(3) on them.
Bug: 30110940
Change-Id: I6f39df65cd960930530e5a1f8420a28d50adc25d
|
|\| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
am: 2703425de8
Change-Id: I90103d0521bd2cd4de3710adf3bc6013721cb6f9
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This gets rid of a bunch of "strerror(errno)" bits.
Will convert fuse.cpp after
https://android-review.googlesource.com/#/c/247780 lands.
Bug: 30110940
Change-Id: Iacefe5b6519b217ed687c709763fe5827b3b0b59
|
|\| |
| | |
| | |
| | | |
Change-Id: I12a541cb698d1df866b8be4dc1e35cb99e6f1e64
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
sdcard.c is a *really* big file. This makes it hard to do things like
improving priv dropping or adding more sandboxing. Extract all
FUSE-related code to a separate unit, fuse.{h|c}, which exports only
two functions. Convert the rest of sdcard.c to C++ as sdcard.cpp.
fuse.c is kept as C (at least for now) since interacting with the FUSE
API is realistically easier from C.
Bug: 30110940
Change-Id: I188bfdc21c184742117e07539adb09090d4d747c
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
am: 2f67f4687b
* commit '2f67f4687b94bcead719d504ea4f77571ae84b3b':
enable integer sanitizer for sdcard service
Change-Id: Ib54476445c01a1f5bd6234aec66c7019939a3858
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The previous false positive fix (df9c4a01) is enough to pass tests, and
it doesn't appear that there are any remaining issues.
Change-Id: Ib9812f1201ff0cd2ae8c8371737754fc328765b5
|
|\ \ \
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | | |
am: 2abee9e
* commit '2abee9e063d1549fb006853b27f378c7d22192af':
Add support for FUSE_CANONICAL_PATH
Change-Id: I47a41bc0b5b3a013e59932cbf66ae6852e15b1c3
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This allows inotify requests on FUSE to be alerted when any
other stacked filesystem would trigger an inotify for the
same file.
Bug: 23904372
Change-Id: I4289b38230c314432eaf2c0d20d4ccefc058f59e
|
|\ \ \
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | | |
am: 182b310
* commit '182b310b1de5654a93c21417c77722897b93882d':
sdcard: avoid benign unsigned overflow
Change-Id: I14e80911060bb609de5b91a4c56315cd701857f9
|
| | |
| | |
| | |
| | | |
Change-Id: Id9427b4e01602bba31f8958b8d491b092b31482b
|
| |\ \ |
|
| | |\ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
am: b84295d027
am: bbaa2b296a
* commit 'bbaa2b296ad836e9d6511549661884d94b53ccee':
[DO NOT MERGE] Use FUSE_SHORTCIRCUIT if available
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Use a non yet maintainer reviewed kernel patch from QCOM that greatly
improves IO speed in case it is available from the device specific
kernel headers.
Bug: 24216004
Change-Id: I4101d80082c9ad9d042dde5c620ddb309d193d52
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When packages change, existing package-specific directories may have
gained/lost a UID mapping, so we need to update the permissions for
any in-memory nodes.
This allows an app to deliver data for another package before that
package is installed, which is the typical pattern of how OBB files
are delivered.
Also fix bug by re-deriving permissions when files are moved.
Bug: 25399427
Change-Id: I06f38a24ad7dee5f5099ba81429aef03208e5683
|
|\ \ \ \ \
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
am: c414027
* commit 'c414027e927fa025877afd53b27886b6c3b19cfd':
Fix overflow in path building
Change-Id: I6e2692539738d81055cc49a183a34261074e5e68
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
An incorrect size was causing an unsigned value
to wrap, causing it to write past the end of
the buffer.
Bug: 28085658
Change-Id: Ie9625c729cca024d514ba2880ff97209d435a165
|
|\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
am: 20ca983
* commit '20ca9836b9a780c41a22850f478a29f29677553e':
Give users and devices control over sdcardfs.
Change-Id: I0144b346157952f79fdde5100f0fdc01daa58d9b
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Instead of relying only on kernel support for sdcardfs, give each
device the ability to quickly toggle between sdcardfs and FUSE. Also
add the ability to users to explicitly enable/disable the behavior
for testing and debugging purposes.
Bug: 27991427
Change-Id: Ie188cb044be2ad87166f2d43c32a1f6b97660de0
|
|\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
am: 71f6b95
* commit '71f6b9569c2c707d061b96e48021b4be617e40a4':
Revert "Revert "sdcard: Support sdcardfs""
Change-Id: I37880f88c21bec8a0dcd4ff8e93ea0986f0b8475
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Issue resolved by commit
6855c48093e109c92df39340a8355a3be2540b8e
"Skip mounting sdcardfs in core mode."
This reverts commit f8fccd2f5a799540ba5a80098cc11cab276fb8f5.
Bug: 27932087
Change-Id: Ibdb72ad16a1e6c3a01edcb03d003c42de7a03cd6
|
|\| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
am: 6267d70
* commit '6267d70b2646e020c09439944bebc6aff1d7d652':
Revert "sdcard: Support sdcardfs"
Change-Id: Iab8254f8cbbf54c29857dcf51911a208eab02115
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 2bd0efa89cf93bf055bd91b1641477da2937ce8d.
Bug: 27932087
Change-Id: Ie27f17c1f283514b90ce9da0c895b528d87e5f47
|
|\| | | |
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
am: a775e62
* commit 'a775e6269308db9c56a8b53b85e7bfbb739b2221':
sdcard: Support sdcardfs
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add ability to use sdcardfs if kernel support is found.
In the future, we will likely remove the fuse components
entirely, but for now, just use sdcardfs when possible.
Bug: 19160983
Change-Id: I35e4d6cb5976c00c6f87ff7fc478ba9f9d212c05
Signed-off-by: Daniel Rosenberg <drosen@google.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When packages change, existing package-specific directories may have
gained/lost a UID mapping, so we need to update the permissions for
any in-memory nodes.
This allows an app to deliver data for another package before that
package is installed, which is the typical pattern of how OBB files
are delivered.
Also fix bug by re-deriving permissions when files are moved.
Bug: 25399427
Change-Id: I06f38a24ad7dee5f5099ba81429aef03208e5683
|
| |/ /
|/| |
| | |
| | |
| | | |
Bug: http://b/27171986
Change-Id: I4af3b4b9f17972327b926ad9ee0d03672d1d4a64
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When packages change, existing package-specific directories may have
gained/lost a UID mapping, so we need to update the permissions for
any in-memory nodes.
This allows an app to deliver data for another package before that
package is installed, which is the typical pattern of how OBB files
are delivered.
Also fix bug by re-deriving permissions when files are moved.
Bug: 25399427
Change-Id: I06f38a24ad7dee5f5099ba81429aef03208e5683
|