| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
CYGWIN is not supported, USE_MINGW and HOST_OS==windows are being
replaced with LOCAL_..._windows variables.
Bug: 23566667
Change-Id: I3e4a1e4097dc994cf5abdce6939e83a91758fd75
|
|
|
|
|
|
|
|
|
|
| |
j is a ssize_t, which can go negative. If it goes negative,
the resulting multiplication of mItemSize*j doesn't make
any sense. Since the value is never used, just don't perform
the calculation if j < 0.
Bug: 23607865
Change-Id: I14f6f6506645d582f7d67a2e2d60ead3cb18b957
|
|
|
|
|
|
|
| |
Call abort() on undefined or sketchy integer behavior.
Protects against integer overflow attacks.
Change-Id: I475e5e9fb04160dd2d201e926ab2b897539f8bb6
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Hashing functions rely on integer overflow behavior.
Mark those functions as safe.
* abort() if a passed in size_t value is greater than
UINT32_MAX. This can occur on 64 bit builds where size_t
is larger than uint32_t.
* Special case the index lookup for an empty sorted vector.
Without the special case, size() == 0, and size()-1 underflows.
Change-Id: I343a14b589fc8f0d221c1998ae5d6f0b9e2781f8
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Patch contributed in:
https://code.google.com/p/android/issues/detail?id=182908
Bug: 23290056
Change-Id: Ide0e9a8acc4e95a9104bab3ae803aa3a40098222
|
|/
|
|
| |
Change-Id: Ib283c85a404a20688c5357fa513e5d07c2f42803
|
|\ |
|
| |
| |
| |
| | |
Change-Id: I9967f3fd758c2a5b40be5b60ae72be7e2fb75136
|
|/
|
|
| |
Change-Id: I9855b6fe72e2f2f3a8360c0993a67cb988024ee4
|
|
|
|
| |
Change-Id: Ia0e4a4f968c640eb44317821d2dc6b195f9f490e
|
|
|
|
|
|
|
|
| |
It's easier for people to debug, and side-steps the problem that errno
values differ between architectures.
Bug: http://b/17458391
Change-Id: I1db9b2cbb653839d3936b91e37e5cff02671318a
|
|
|
|
| |
Change-Id: Ib1d94648cdc163675ac7b6acf86408d5be6b5ad2
|
|
|
|
| |
Change-Id: I720b8ef1050da45a7833adef8219b6acb2cf3a38
|
|
|
|
| |
This reverts commit a7870d88167f619e758b5bcd15b410d16da7c16b.
|
|
|
|
|
|
|
|
| |
Breaks internal master.
This reverts commit 98ff77204cef9bb8f0f27420833233622060a09e.
Change-Id: I18dc6021cb43efff8aa88486c2d980dc2b8eedba
|
|
|
|
|
|
|
| |
Move StringPrintf and the string based file I/O from libutils to
libbase.
Change-Id: I0297a6063874b9d92100e0dd5123fddfbda932fe
|
|
|
|
|
|
|
|
|
| |
Nobody ever called acquire() so release() was always
equivalent to delete. Just use delete instead so that
people can use unique_ptr directly (or shared_ptr if
they really want refcounts).
Change-Id: I9e3ad5e0f6a4fcc4e02e5a2ff7ef9514fe234415
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The reference to NOT_USING_KLIBC appears to be the only one
in our codebase. This change also removes some cygwin specific
retry logic - all other supported platforms in this section
of the code should support mapping at an offset.
Note that i've reversed the sense of the check, we always sysconf
since that's recommended practice.
Change-Id: Ib985fb665193d7a07a282f7092cd77c0bc508a66
|
|/
|
|
|
|
|
|
|
|
| |
The actual bug is == instead of !=, but the real cause was me trying to be
too clever. This patch switches to much simpler code, and -- since the
intended use of this code is security anyway -- adds logging if anything
goes wrong.
Bug: 19361774
Change-Id: If2af07d31a5002f9010b838247b691f6b28bdfb1
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This isn't particularly useful in and of itself, but it does introduce the
first (trivial) unit test, improves the documentation (including details
about how to debug init crashes), and made me aware of how unpleasant the
existing parser is.
I also fixed a bug in passing --- unless you thought the "peboot" and "pm"
commands were features...
Bug: 19217569
Change-Id: I6ab76129a543ce3ed3dab52ef2c638009874c3de
|
|
|
|
|
|
|
| |
Only two days in, and I'm already really regretting putting this code
somewhere that builds for Mac OS and Windows...
Change-Id: I576ee4a9e647e10dc2d47c7e1e38aedee2bf404c
|
|
|
|
| |
Change-Id: I857a80b61768d4e9610bdd149eff2d9d8e48d2c0
|
|
|
|
| |
Change-Id: If333c28b8ed047346a2dd85e591c4bedbab874cc
|
|
|
|
|
|
|
| |
I knew I should have created a new library that doesn't build for the
Mac or Windows rather than adding to libutils...
Change-Id: I7c07eaa93affb7e83d4da384f03652c39065562a
|
|
|
|
|
| |
Bug: 19217569
Change-Id: I64789d3fa6777ee30a324cdf00fdc275c1230e1b
|
|
|
|
|
| |
Bug: 19083585
Change-Id: Ic09eb3dd250bc5c5b63cac7998f99f5fa007f407
|
|
|
|
| |
Change-Id: I8343b398f2ce0d743487fdd086e67763c7dd67f1
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed LOCAL_C_INCLUDES as the external/zlib headers are no longer
referenced by anything in libutils.
Removed unused host_commonLdlibs build variable. This was referenced
by the lib64utils host target which was removed in commit 03cc1f747
Tested compiling some of the projects that make use of libcutils
using a clean out dir with the folllowing targets
aosp_arm-eng : make -j16 logd dexdump
aosp-flouder-userdebug : make -j16 keystore vold libjavacore logd
aosp-x86_64-eng : make -j16 keystore vold libjavacore logd dexdump
Change-Id: I663e52bbf28dde27866dad9429bf95ada6b594a5
|
|
|
|
| |
Change-Id: I777da5757f01d8328d5475e654d56d81dc802655
|
|
|
|
|
|
| |
For build-system CFLAGS clean-up, "remove" unused variables.
Change-Id: Ic96f066981cd96ca16af81ee3fdbc972507e8c81
|
|
|
|
| |
Change-Id: I9e25ac9d27e95b04fb8bf7a66c619af0139d8b8f
|
|
|
|
|
|
| |
Change to avoid "unused parameter" warning.
Bug: 18397020
Change-Id: I4b26de55314c78237daead8e873385b97cafe4d4
|
|
|
|
|
| |
Bug: 18397020
Change-Id: Ibc8d886d729c51932a403531888214de4e541452
|
|
|
|
|
| |
Bug: 15193147
Change-Id: I85aff3bcabb5ee3c8be9918b7bef0fd1bbfa98e3
|
|
|
|
|
|
| |
Should use memmove when you expect overlap.
Change-Id: I268a173db40a4be54232958e37aa8a03c2a885ee
|
|
|
|
|
| |
Bug: 18315579
Change-Id: I0bd5fb946b12cb90e0c9c73a478df41609b8c3e2
|
|\
| |
| |
| |
| | |
* commit '7a92d20ec845c07472eaea7cf14fd0e69df836ef':
Clean up some test makefiles.
|
| |
| |
| |
| |
| |
| |
| | |
Needed for building with libc++ as the default STL.
Bug: 15193147
Change-Id: I8b462bd288fbea7e0ab182f85ffcbf438afb6aa4
|
|\ \
| | |
| | |
| | |
| | | |
* commit '1c77bf4ce5059f3a770418cfa8afed39ee41ab24':
Fix windows specific behavior of FileMap
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The implementation of the FileMap destructor would
close the file, only on Windows, which did not match
the behavior on mac/linux.
This is because calling munmap does not close the file
descriptor. It must be closed separately, before or after
munmap.
On Windows, the file must also be closed manually,
before or after closing the mappingFile.
The change basically removes the closing file from
the windows-specific part of the destructor, to
make behavior more consistent on all platforms
where the caller to FileMap is responsible for closing
its own file (since FileMap receives an opened file).
Change-Id: I5e3cfffbb870d5f3595802ccac57dbc1dbf1ce6e
|
|\| |
| | |
| | |
| | |
| | | |
* commit '3fe9adc932948da8993d3f812bce1875efc47c0e':
Fix write past end of memory.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The computed flattened size of the blob does not match the size used by the
flatten function when the last cached entry size is not 4 byte aligned.
Bug: 17873145
Change-Id: I9f9fc102d4bde4681ae977b6de5f263aaaf56708
|
|\ \ \
| | |/
| |/|
| | |
| | | |
* commit '522c1d340b6c1742d3e47aad27b974e43fad4bc2':
Remove makefile cruft.
|
| |\ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Don't manually include stlport, and don't use private bionic headers.
Change-Id: I0fc4e8b34ab449e9ef07c26f71e472fca5640590
|
|\| | |
| | | |
| | | |
| | | |
| | | | |
* commit 'e4bf208ce8d893634a0f6f63ce34ec6498934d05':
Move libutils over to pthread_gettid_np.
|
| |/ /
| | |
| | |
| | |
| | | |
Bug: 17476168
Change-Id: I934d93a023eb00e036ed3cee8c52efaeb17b8915
|
|\ \ \
| | |/
| |/|
| | |
| | |
| | |
| | | |
thread name fails" into lmp-dev
* commit '6ba555f2ad878129cd1da9dd7b7613ab166090ab':
libutils: Don't segfault ProcessCallStack when getting thread name fails
|