summaryrefslogtreecommitdiffstats
path: root/libsysutils
Commit message (Collapse)AuthorAgeFilesLines
* [libsysutils] Modernize codebase by replacing NULL with nullptrYi Kong2018-07-244-23/+23
| | | | | | | | Fixes -Wzero-as-null-pointer-constant warning. Test: m Bug: 68236239 Change-Id: I9e95daa0750f2622d1c4788941fdfae23ee61801
* Merge "Parse IfIndex for Netlink RTM_NEWADDR / RTM_DELADDR event"Rubin Xu2018-06-271-4/+5
|\
| * Parse IfIndex for Netlink RTM_NEWADDR / RTM_DELADDR eventRubin Xu2018-06-071-4/+5
| | | | | | | | | | | | | | | | Bug: 64692591 Test: cts-tradefed run commandAndExit cts-dev -m CtsHostsideNetworkTests -t com.android.cts.net.HostsideVpnTests Change-Id: Icb2ae1264f0d2fcd285b04edd27641175dd2646f Merged-In: Icb2ae1264f0d2fcd285b04edd27641175dd2646f (cherry picked from commit 3668291d8ece81ce1eccdee150588c2d71cae723)
* | Merge "libsysutils: Delete dead code: FrameworkClient"Treehugger Robot2018-06-072-79/+0
|\ \
| * | libsysutils: Delete dead code: FrameworkClientBernie Innocenti2018-06-072-79/+0
| | | | | | | | | | | | | | | Test: mm Change-Id: I372f2aa8d7f7e3f5ce1cd9399292bef9e4900de7
* | | Merge "Move per-file OWNERS directives to their directories."Lorenzo Colitti2018-06-062-0/+4
|\ \ \ | |/ / |/| |
| * | Move per-file OWNERS directives to their directories.Lorenzo Colitti2018-06-062-0/+4
| |/ | | | | | | | | | | | | | | | | As documented at go/gerrit-owners, per-file directives cannot contain directory paths. Therefore the current per-file directives in system/core/OWNERS have no effect. Test: build/make/tools/checkowners.py system/core/{,libsysutils/src/,include/sysutils/}OWNERS Change-Id: Ia88b2be42dd50346578bb51dd17fb6136a4591f1
* / Revert "SocketListener: use poll() instead of select()"Kevin Rocard2018-06-063-68/+107
|/ | | | | | | | This reverts commit 0ad41cf3f44e5403132f7f620d8199446cb815b4. Reason for revert: Breaks many tests, see b/109745952#comment18 b/109745952#comment20 and b/79838856#comment19 amongst others Change-Id: I92db38d47cd1dcd7841091e37e3b65dce9456cdf
* SocketListener: use poll() instead of select()Bernie Innocenti2018-05-253-107/+68
| | | | | | | | | | | | | | | | FD_SET is limited to 1024 file descriptors in Linux, which causes processes with too many open files or connections to crash: FORTIFY: FD_ISSET: file descriptor 1024 >= FD_SETSIZE 128 The fix we used elsewhere is replacing select() with poll(), but in the case of SocketListener we additionally need to replace the SocketClient list with a map indexed by fd in order to avoid quadratic behavior on each poll() wakeup. Bug: 79838856 Test: device boots and appears to work normally Change-Id: I19ca4be675e9638104c0e7acf4a4bc62085e8ecd
* Include iface index in the netlink eventChenbo Feng2018-03-071-0/+6
| | | | | | | | | | | | | The TrafficController inside netd also get notified when the interface on device added or removed, and it need both ifaceName and ifaceIndex information from Netlink event. Add the ifaceIndex in the event can avoid the TrafficController to run if_nametoindex again when receive the event. Bug: 30950746 Bug: 73137611 Test: new interface show up in bpf interface map. Change-Id: Ia3b4aeb8eff345ce7cf03ccec88f0893cfe125c0
* Don't complain that the DNSSL RA option is "unknown".Lorenzo Colitti2017-11-281-0/+2
| | | | | | | | This option isn't unknown, we just don't support it. Bug: 69778511 Test: walleye builds, boots, connects to IPv6 network Change-Id: If3a37d855f404da708fec4a7ba242ed41a493895
* Stop depending on libnl.Lorenzo Colitti2017-10-053-11/+44
| | | | | | | | | | We only use it for trivial functions. Replace them and drop the dependency. Bug: 67345547 Test: bullhead builds, boots Test: CtsOsTestCases android.os.cts.StrictModeTest passes Change-Id: I36254962284babdd1a55a32a76dd0dc92d85420c
* Mark the modules as VNDK in Android.bpJustin Yun2017-09-141-0/+3
| | | | | | | | | | | | | | | | | | | As a VNDK module, Android.bp must have 'vndk' tag as well as 'vendor_available: true'. The 'vndk' tag for VNDK module is formated as below: vndk: { enabled: true, }, VNDK modules will be installed both in system/lib(64) as normal and in system/lib(64)/vndk as a vendor variant. Bug: 63866913 Test: build and boot with BOARD_VNDK_VERSION=current Merged-In: Icecb22ed2ed0f58c3168605d4cf64815e2dda750 Change-Id: Icecb22ed2ed0f58c3168605d4cf64815e2dda750 (cherry picked from commit 9b0ed7294273d5f10020388e5a5b7e545a2fd1de)
* Remove old LOG_EVENT_* code from libsysutilsYifan Hong2017-07-112-3/+0
| | | | | | | | | | | As a side effect, this change fixes libbsysutils => liblog dependencies. LOG_EVENT_* macros are not defined for liblog.vendor. Test: BOARD_VNDK_VERSION=current mma Bug: 33241851 Bug: 63034227 Change-Id: I3df700d97481ec9aa59cf1796da1e991af28bdf5
* libsysutils: Fix vold vulnerability in FrameworkListenerNIEJuhu2017-06-201-1/+1
| | | | | | | | | | Don't release the sender socket when FrameworkListener receives a command that exceed the maximum buffer length Bug: https://issuetracker.google.com/issues/62812018 Test: manual Change-Id: I160f504f3fb902ba25fc79deb8ae7d78d811a807
* Mark libsysutils vendor_available.Jayant Chowdhary2017-05-241-0/+2
| | | | | | | | | | | | | libsysutils belongs to vndk-cap. Mark it vendor_available to enable vndk abi stability checks on it. Details: https://android-review.googlesource.com/368372 Test: mm -j64 Bug: 38244611 Change-Id: I3ef1d09c7e836549eb13ce68ac7cdcd5923bde0f
* libsysutils: Android.mk -> Android.bpSteven Moreland2017-04-242-27/+25
| | | | | Test: links Change-Id: If1d034ecb880e8c41d58b14ebebcda5b72e88424
* There's no longer a limit to property names.Elliott Hughes2017-02-282-38/+16
| | | | | | Bug: http://b/33926793 Test: boots Change-Id: I8554d7af74e064c114cf817f5a2ba1247fa2a2db
* fix warning: Null pointer argument in call to memory comparison functionYunlian Jiang2017-02-081-2/+4
| | | | | | | | | This fixes warning: Null pointer argument in call to memory comparison function [clang-analyzer-cplusplus.NewDeleteLeaks] Bug: None Test: The warning is gone. Change-Id: I957365184966cc1435d7e37d64f2cc6a32846ebd
* Exporting C++ headers from system/coreVijay Venkatraman2017-01-2411-0/+768
| | | | | | | | | | | | | | | | | | | | | | Moved headers from include/libutils and include/libsysutils to libutils/include and libsysutils/include respectively, so they can be exported via these libs. They needed to be moved since Soong does not allow export from external folder. Added symlink from old locations. They are needed since Soong includes system/core/include by default. Once all modules are cleaned up to explicitly add the required libs, the symlinks will be removed. Moved headers of libutils to libutils_headers. They should be used by modules for header-only inlines. Added libutils_headers as dependency of libutils. Split of C++ headers into those that have no dependency and those that have dependency on libutils.so will be handled in a later CL. Test: Add above libs to shared lib of local module Change-Id: I122db72056b26b1f39bad1d9a0c2a1c5efda3550
* Merge "system/core: preparation to pull back interfaces from android/log.h"Mark Salyzyn2016-10-207-7/+13
|\ | | | | | | | | | | am: 27d2d49f48 Change-Id: I604bb1d4cf62636663fa92e3d14a55887dbcae23
| * system/core: preparation to pull back interfaces from android/log.hMark Salyzyn2016-10-207-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Point to log/log.h where necessary, define LOG_TAG where necessary. Accept that private/android_logger.h is suitable replacement for log/logger.h and android/log.h. Correct liblog/README Effectively a cleanup and controlled select revert of 'system/core: drop or replace log/logger.h' and 'system/core: Replace log/log.h with android/log.h'. Test: compile Bug: 30465923 Change-Id: Ic2ad157bad6f5efe2c6af293a73bb753300b17a2
* | system/core Replace cutils/log.h with android/log.h am: 66ce3e08c5Mark Salyzyn2016-09-308-48/+95
|\| | | | | | | | | | | am: eb189f147b Change-Id: I3f2b13e259d9bbb7bc714f21eab7181fa72c35bf
| * system/core Replace cutils/log.h with android/log.hMark Salyzyn2016-09-308-48/+95
| | | | | | | | | | | | | | | | | | | | | | Should use android/log.h instead of cutils/log.h as a good example to all others. Adjust header order to comply with Android Coding standards. Test: Compile Bug: 26552300 Bug: 31289077 Change-Id: I2c9cbbbd64d8dccf2d44356361d9742e4a9b9031
* | Merge "Most accept/accept4 calls in system/core don't actually want the ↵Elliott Hughes2016-08-231-10/+1
|\| | | | | | | | | | | | | | | remote address." am: 299d64144b am: 8615d79d85 Change-Id: I89aeabf6efa8217c9acd3f8a766bbd18f7e994fa
| * Merge "Most accept/accept4 calls in system/core don't actually want the ↵Elliott Hughes2016-08-231-10/+1
| |\ | | | | | | | | | | | | | | | | | | | | | remote address." am: 299d64144b Change-Id: I3fb9678dfed08f0b1d6e90e547ecae6cdcabc9a1
| | * Most accept/accept4 calls in system/core don't actually want the remote address.Elliott Hughes2016-08-231-10/+1
| | | | | | | | | | | | | | | | | | | | | So don't write the extra code for it or waste the kernel's time copying it around. Change-Id: I93de64064c2d4fe58ba5b5322cfa69bf31a76dad
* | | Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c ↵Connor O'Brien2016-08-191-3/+14
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 am: 2f78b2c3d6 am: 2b5e6d8ffc am: 2427a462c0 am: 6b155c1cc4 am: 2f16eeede6 Change-Id: I3d2fdfc10f91080ca32aa6557b13391355427edc
| * | Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c ↵Connor O'Brien2016-08-191-3/+14
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 am: 2f78b2c3d6 am: 2b5e6d8ffc am: 2427a462c0 am: 6b155c1cc4 Change-Id: Ie6c2bcee1deacb94259a6153097757674fa19251
| | * \ Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c ↵Connor O'Brien2016-08-191-3/+14
| | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb am: 9745b11db1 Change-Id: I61f685976803f51db9ba85729554fc14efaa4b2c
| | | * \ Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6c ↵Connor O'Brien2016-08-191-3/+14
| | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 109024f74a am: b906ad88b9 am: 2fadbb93a4 am: e04054d9bb Change-Id: Ia5f46e5b9622946ca0e44fbe7399729807d2d08a
| | | | * \ Fix vold vulnerability in FrameworkListener am: 470484d2a2 am: e9e046df6cConnor O'Brien2016-08-191-3/+14
| | | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: 109024f74a Change-Id: Ia6e8dca36bc28d442a6e374ecf033b79176f4b93
| | | | | * \ Fix vold vulnerability in FrameworkListener am: 470484d2a2Connor O'Brien2016-08-191-3/+14
| | | | | |\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | am: e9e046df6c Change-Id: I8f2452782817ddf03051af08e70ba9d4c4fa578a
| | | | | | * | Fix vold vulnerability in FrameworkListenerConnor O'Brien2016-08-191-3/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modify FrameworkListener to ignore commands that exceed the maximum buffer length and send an error message. Bug: 29831647 Change-Id: I9e57d1648d55af2ca0191bb47868e375ecc26950 Signed-off-by: Connor O'Brien <connoro@google.com> (cherry picked from commit baa126dc158a40bc83c17c6d428c760e5b93fb1a)
* | | | | | | | Merge "Clean up CLOEXEC in SocketListener." am: ed83cfba68Elliott Hughes2016-02-231-2/+1
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | / | | |_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | am: f5a2f6e963 * commit 'f5a2f6e963b4c82adbb129b2df460594524ebedf': Clean up CLOEXEC in SocketListener.
| * | | | | | Clean up CLOEXEC in SocketListener.Elliott Hughes2016-02-191-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I9811573a4b64ef2e38f1e4ba17158911b05a5f34
* | | | | | | Tolerate RTM_DELADDR messages from deleted interfaces.Lorenzo Colitti2016-02-161-5/+3
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When an interface is deleted (which can happen, for example, to the tun interfaces used for VPN and 464xlat), the kernel sends RTM_DELADDR messages for all its IP addresses. Currently we ignore these because we cannot fetch the interface name. Instead, pass them up with an empty interface name so that NetlinkHandler can do something useful for them, such as destroy connections on the IP addresses that are being deleted. Bug: 26976388 Change-Id: I2ced7e389228f9d665d0a87d97bd3452c8c0c98b
* / / / / / Switch from using sockaddr to sockaddr_storage.Erik Kline2015-12-071-3/+4
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | This is to ensure sufficient space is always available. Change-Id: Ifa87b93ecdc90dcacbfb24446c872344da6703d3
* | | | | Fix incorrectly sized buffer.Erik Kline2015-07-281-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also: use a more correct size type. Bug: 21562630 Bug: 21764392 Bug: 22464419 Change-Id: I9a9cf64f0481670828fac707e00196e222d0311e
* | | | | Qualify IPv6 link-local DNS servers with an interface nameErik Kline2015-06-181-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 21562630 Bug: 21764392 Change-Id: I7d271ae0f3fd92f70049017d38ccc15e3c1dda83
* | | | | Give SocketListener some FD_CLOEXEC.Jeff Sharkey2015-04-011-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sockets love FD_CLOEXEC. Bug: 19993667 Change-Id: I0d72a27e0f46b79843bb91ed48ebaf1c89484fd2
* | | | | Revert "Sigh, more vendors linking against hidden APIs."Vineeta Srivastava2015-03-201-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 31837298166e678d8e9c9fba1b30aea5abf1350f. Change-Id: I5c041d7438b64c4c258c414ca9a133075999e1b6
* | | | | Sigh, more vendors linking against hidden APIs.Jeff Sharkey2015-03-161-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | Bug: 19762346 Change-Id: I6c0823bf69e3f7e854ffea7b5483d09bb7359ff6
* | | | | Define enum class for NetlinkEvent actions.Jeff Sharkey2015-03-131-25/+13
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | This lets us use it for switch statements, and gives us stronger type safety. Change-Id: Idb3ad7098657a09f13c95dc7070611d35ede66ae
* | | | Add missing <malloc.h> and <string.h> includes.Elliott Hughes2015-01-281-0/+1
| | | | | | | | | | | | | | | | Change-Id: Ia41756e607663d056e7d2fdd7ecbec7e5841a913
* | | | Remove obsolete BUILD_TINY_ANDROID check from libsysutils makefileTrevor Drake2015-01-241-3/+0
| | | | | | | | | | | | | | | | Change-Id: I3cd1430b1555a5cd27b31ed3eebc1663f43e7b3b
* | | | Extend to receive NFLOG packets.Jeff Sharkey2015-01-153-10/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Packets captured and logged by the NFLOG target are unicast, so extend to catch and decode them. To avoid escaping issues, the raw contents are passed around as hex strings. Bug: 18335678 Change-Id: Ib7299500baa00080a1f000f9da843eb527363353
* | | | Fix formatting in 4df4dfedf6beef891d05d4e80704f5f4a594a885.Elliott Hughes2014-11-101-1/+2
| | | | | | | | | | | | | | | | Change-Id: I1ad219285cb1f4a39cfe2bdef224b78eff843317
* | | | When new error happend,then errno should be updated accordingly.Bo Huang2014-11-101-1/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise, need to keep previous errno. Reproduced steps: pre-condition: DUT support external SDcard or Usb mass storage; 1. Insert blank(no partition) SDcard or UMS to DUT; Expected result: Should prompt user with storage error. Test result: There is no notification for error. Error log: 01-01 01:06:49.239 I/fsck_msdos( 200): fsck_msdos terminated by exit(8) 01-01 01:06:49.239 E/Vold ( 200): /dev/block/vold/179:16 failed FS checks (I/O error) 01-01 01:06:49.239 D/Vold ( 200): Volume sdcard1 state changing 3 (Checking) -> 1 (Idle-Unmounted) 01-01 01:06:49.239 W/Vold ( 200): Returning OperationFailed - no handler for errno 0) Root cause analysis: 1.Volume::setState will call senBroadcase to send out state notification; 2.Finally, SocketClient::sendDataLockedv was called to sent message. In sendDataLockedv funtion, when current == iovcnt, e is 0 by default. So Vold get incorrect errno. Change-Id: Icb32a4193f02f22b5e3feaba177bc278f8f1f41b Signed-off-by: Bo Huang <bo.b.huang@intel.com>
* | | Support parsing netlink route messages.Lorenzo Colitti2014-06-211-0/+99
| | | | | | | | | | | | | | | Bug: 9180552 Change-Id: I4a36d869ac692647fb226d0912285bdf2ffcb1fa
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-25 23:47:45 +0000