Only thread group leaders should be registered with lmkd. Add a check to ignore any non-leader TIDs and generate an error if such condition is detected. Run the same check before killing a process to detect cases of non-leader TIDs being used to kill a process. This might happen if PIDs overflow and previously registered PID gets reused for a non-leader thread in the following scenario: 1. pid X is a thread group leader and is registered with lmkd 2. pid X dies without lmkd knowing it and pid gets recycled 3. process Y creates a thread with tid X 4. lmkd kills pid X which results in process Y being killed Bug: 136408020 Test: lmkd_unit_test Change-Id: I46c5a0b273f2b72cefc20ec59b80b4393f2a1a37 Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Test: boots, works Bug: 133761317 Signed-off-by: Tim Murray <timmurray@google.com> Exempt-From-Owner-Approval: trivial change Change-Id: I1a4a3741694078eec124f1f560ea68e78754bca6
Occasionally we see cases when 40ms polling is still too conservative. Change to 10ms polling period. Since the polling happens only after PSI signal and continues for 1sec this should not affect system performance. Test: lmkd_unit_test Bug: 129358844 Change-Id: Ib759b865b2104be23741fc0eacaa541e22d50dde Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Previous change If154dc364711bf7c86f32e24ddcd10be359386de called "lmkd: Do not downgrade/ignore events when swap is full" added SwapTotal into meminfo structure without adding the field into events.logtag file. This results in logs which missing field and all fields starting with "SwapFree" get reordered as a result. Fix this by adding the missing field into events.logtag. Bug: 129274901 Test: Confirm correct information in the logcat Change-Id: Ia4de3790a7e9d49a0e4cba8b3161a715eaf6532e Signed-off-by: Suren Baghdasaryan <surenb@google.com>
200ms was too lenient when under severe memory pressure. Test: boots, works Bug: 127765309 Change-Id: I8e047de6318574a107720c56473ed0f25582e182 Signed-off-by: Tim Murray <timmurray@google.com>
Log min_score_adj when lmkd kills a process to determine the oom_score levels that lmkd considers during the kill. Bug: 123024834 Change-Id: I986ae8f2808199b1654bc8d2a32dd88046c79aa3 Signed-off-by: Suren Baghdasaryan <surenb@google.com>
lmkd can't kill processes because it has compare the size between free swap and free memory. Free swap is often larger than the free memory when system is under low memory with less swap-backed or swappable pages and finally leads to I/O thrashing. Test: TreeHugger Bug: 124727769 Change-Id: Ia2848859aa97a24bd13c704acee4b86cd2d3f647
Bug: http://b/116873221 If not, building with coverage (and -O0) is broken since Clang does not inline these functions, and does not emit a definition because they are not static or extern. Test: Build with coverage (-O0) Change-Id: I2880119834f764164a1aac10b696e76a2b462b71
We already know that "polling" must be non-zero at this point, because it hasn't been modified since our check on line 1960. So we remove this check for code clarity. Test: TreeHugger Change-Id: I069d9fd0eef70748a5333733dd0518d1ac8021b7
With new psi monitor support in the kernel lmkd can use it to register custom pressure levels. Add lmkd support for psi monitors when they are provided by the kernel and use them by default. When kernel does not support psi lmkd will fall back to vmpressure usage. Add ability to poll memory status after the initial psi event is triggered because kernel throttles psi memory pressure events to one per PSI tracking window (currently set to 1sec). Current implementation polls every 200ms for 1sec duration after the initial event is triggered. If ro.lmk.use_psi is set to false psi logic will be disabled even when psi is supported in kernel. Bug: 111308141 Test: lmkd_unit_test Change-Id: I685774b176f393bab7412161773f5c9af51e0163 Signed-off-by: Suren Baghdasaryan <surenb@google.com>