system_core/libziparchive, branch replicant-10

zip_writer.cc: update powerof2 and use it unconditionally

2019-03-27T17:24:44+00:00

Update the powerof2 macro to one that is integer overflow safe.
This definition is the same one used by bionic, but cleaned up using
clang_format.

Unconditionally use this powerof2 macro, to ensure consistency across
all the build environments.

Test: compiles and boots
Change-Id: I21bfaf2360d1f77caf96365e20490b1deadfdfe0

Merge "libziparchive: add integer checks"

2019-03-27T13:03:16+00:00

Merge "zip_archive.cc: delete android_errorWriteLog"

2019-03-23T03:08:35+00:00

zip_archive.cc: delete android_errorWriteLog

2019-03-21T16:58:56+00:00

The process of determining whether or not to emit a safetynet error
entry while processing a malformed file relies on addition overflow.
Since this is only logging, and logging which isn't used, delete the
code instead of trying to fix the logic which is causing the integer
overflow.

This change is necessary to enable integer sanitization on this code.

Somewhat related to Bug: 122975762
Test: atest ziparchive-tests

Change-Id: I6b41ccf7881348cb4e5236324eaa44a05662a725

entry_name_utils-inl.h: clear top bit before shifting

2019-03-21T16:29:31+00:00

Attempting to shift a uint8_t which has the top bit set results in a
value outside of the range allowable for a uint8_t. The process of
converting this value back to a uint8_t triggers ubsan's
implicit-conversion sanitizer.

Ensure the high order bit is stripped before shifting, so that the
shifted value fits into the allowable uint8_t range.

This change is necessary to enable integer sanitization on this code.

Somewhat related to Bug: 122975762
Test: atest ziparchive-tests

Change-Id: I940c8b2828ac88348d80f731274b990e35de6631

libziparchive: add integer checks

2019-03-20T20:04:02+00:00

The code in libziparchive has lots of questionable looking but not
obviously wrong integer operations. In order to shake out integer bugs
in libziparchive (for example, commit
1ee4892e66ba314131b7ecf17e98bb1762c4b84c from bug 31251826) and provide
protection against security bugs, enable some integer sanitization
options in libziparchive.

Bug: 122975762
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=941802
Test: device boots and no obvious problems.
Change-Id: I215d81892a6eff12d692648c69a03e8200b334d7

Revert the explicit config, see topic

2019-02-20T21:29:11+00:00

Other CL in topic address the issue of the file pusher.
The explicit config for this module will not be required
anymore.

Test: atest -v ziparchive-tests
Bug: 124515549
Change-Id: I4dad8adbce0817009158bc191c2cce86c38d9e3e

Ziparchive: Give tests a test config

2019-02-15T19:53:49+00:00

To work around problems with the autogenerated one.

Bug: 117891984
Bug: 124515549
Test: atest ziparchive-tests
Change-Id: Ia4b352b7404255a4fe9e644a56ae9c5d41c79886

zip_archive.cc: add O_CLOEXEC

2018-12-18T20:48:06+00:00

Prevent file descriptors from leaking across an exec() boundary.

Bug: 120983106
Test: compiles and boots
Change-Id: I392b0767674b557b1e4404a2ba63bc48e3e37b24

Merge "TEST_MAPPING: add the rest of our actively maintained tests."

2018-11-28T00:56:36+00:00