system_core/libappfuse, branch replicant-10 Fork of system/core Merge "Close /dev/fuse FD before calling onClosed" into qt-dev 2019-05-31T15:59:39+00:00 Anton Hansson hansson@google.com 2019-05-31T15:59:39+00:00 b6d9fbddc6d77f57c8630ec372bdb9890679b7be 






Close /dev/fuse FD before calling onClosed
2019-05-31T15:58:45+00:00

Anton Hansson
hansson@google.com

2019-05-31T12:22:34+00:00

c9e873f2747108cc6f010791c86569367d0bef44

This works around a deadlock when a bridge that is about to be closed
is reused for a new call to openFile. The call to open() ends up holding
the vold lock, waiting for appfuse to respond. The appfuse event loop
calls onClosed(), which ends up calling vold.unmountAppFuse(), which
cannot get the lock.

Closing this file descriptor causes any current calls to open() on its
mount path to fail with either ECONNABORTED or ENOTCONN, allowing the
event loop to make progress, call onClosed() and unmount the path.

Note that the failed call to open() will result in a retry, which
will create a new appfuse bridge. This is not ideal but not a new
problem -- the common case here is that that each call to
openProxyFileDescriptor creates a new bridge. This should ideally
be improved.

Bug: 132344997
Test: flick through info of photos with location info attached
Exempt-From-Owner-Approval: verbal approval of approach
Change-Id: I878e5cf86f18c5233f8505f52eb9db076bd72d01





This works around a deadlock when a bridge that is about to be closed
is reused for a new call to openFile. The call to open() ends up holding
the vold lock, waiting for appfuse to respond. The appfuse event loop
calls onClosed(), which ends up calling vold.unmountAppFuse(), which
cannot get the lock.

Closing this file descriptor causes any current calls to open() on its
mount path to fail with either ECONNABORTED or ENOTCONN, allowing the
event loop to make progress, call onClosed() and unmount the path.

Note that the failed call to open() will result in a retry, which
will create a new appfuse bridge. This is not ideal but not a new
problem -- the common case here is that that each call to
openProxyFileDescriptor creates a new bridge. This should ideally
be improved.

Bug: 132344997
Test: flick through info of photos with location info attached
Exempt-From-Owner-Approval: verbal approval of approach
Change-Id: I878e5cf86f18c5233f8505f52eb9db076bd72d01







Fix BridgeEpollController to handles EAGAIN correctly
2019-05-31T03:51:05+00:00

Daichi Hirono
hirono@google.com

2019-05-31T03:51:05+00:00

ca0d4ffbe38a1997d8b1555210a184a5e0d112f4

When reading/writing proxy FD, if it returns EAGAIN,
BridgeEpollController updates epoll entries to observe specific FD
events. Before updating epoll entries, BridgeEpollController checks if
it really needs to update by comparing |state_| and |last_state_|.
|last_state_| has not been updated correctly so it resulted in wrong
epoll settings and keeps blocking the event loop.

Bug: 134104939
Test: atest libappfuse_test
Change-Id: I1c4a0164c1c016baf24ecfd523476ced981d3b28





When reading/writing proxy FD, if it returns EAGAIN,
BridgeEpollController updates epoll entries to observe specific FD
events. Before updating epoll entries, BridgeEpollController checks if
it really needs to update by comparing |state_| and |last_state_|.
|last_state_| has not been updated correctly so it resulted in wrong
epoll settings and keeps blocking the event loop.

Bug: 134104939
Test: atest libappfuse_test
Change-Id: I1c4a0164c1c016baf24ecfd523476ced981d3b28







use epoll_create1(EPOLL_CLOEXEC)
2018-12-17T17:32:23+00:00

Nick Kralevich
nnk@google.com

2018-12-17T17:32:23+00:00

f47c91053ffb0c4477a6dc7271dae0b20b6223c3

epoll_create(0) leaks file descriptors. Use epoll_create1(EPOLL_CLOEXEC)
instead.

Bug: 120983106
Test: compiles and boots
Change-Id: I2a733d4482d6a74ceb3254e501cdb5f6de0cd5dc





epoll_create(0) leaks file descriptors. Use epoll_create1(EPOLL_CLOEXEC)
instead.

Bug: 120983106
Test: compiles and boots
Change-Id: I2a733d4482d6a74ceb3254e501cdb5f6de0cd5dc







Stop using SO_SNDBUFFORCE
2018-03-15T05:22:27+00:00

Ryo Hashimoto
hashimoto@google.com

2018-03-14T10:24:47+00:00

3d95d88b14ce1272202a866296258dcd3a1a85ce

Use SO_SNDBUF which doesn't require CAP_NET_ADMIN instead.
Change the value of kFuseMaxWrite to 128KB.

In the kernel code, there is a constant FUSE_MAX_PAGES_PER_REQ which
limits the size of requests to 128KB.

Bug: 74725300
Test: atest android.os.storage.cts.StorageManagerTest

Change-Id: Ic3a8f1a7378d027a6c0ee054cedc2c9f4b7509ad





Use SO_SNDBUF which doesn't require CAP_NET_ADMIN instead.
Change the value of kFuseMaxWrite to 128KB.

In the kernel code, there is a constant FUSE_MAX_PAGES_PER_REQ which
limits the size of requests to 128KB.

Bug: 74725300
Test: atest android.os.storage.cts.StorageManagerTest

Change-Id: Ic3a8f1a7378d027a6c0ee054cedc2c9f4b7509ad







bpfmt.
2018-02-17T01:58:14+00:00

Elliott Hughes
enh@google.com

2018-02-17T01:58:14+00:00

dc699a269f6a22af6cbba0f6e1359fde103dc4d3

Bug: N/A
Test: builds
Change-Id: I89ad00e1c4c7e0767bc80a7ac7935a4d55e090ac





Bug: N/A
Test: builds
Change-Id: I89ad00e1c4c7e0767bc80a7ac7935a4d55e090ac







Merge "Add OWNERS."
2017-12-07T23:21:26+00:00

Elliott Hughes
enh@google.com

2017-12-07T23:21:26+00:00

3289b9c9282dec777363256e27fcc23cd97001c1












Add OWNERS.
2017-12-07T21:30:03+00:00

Elliott Hughes
enh@google.com

2017-12-07T19:31:02+00:00

693d63f9cfc21e3334c6f8f228d73c4fb60ced8b

Bug: N/A
Test: N/A
Change-Id: Ie785058c0f5eb9b4086c98ccba6e63e3ed411b65





Bug: N/A
Test: N/A
Change-Id: Ie785058c0f5eb9b4086c98ccba6e63e3ed411b65







Merge "Remove LOCAL_CLANG and clang: true" am: 80ec81cf4b am: f7b315c985 am: 8a8b97b271
2017-07-25T22:39:58+00:00

Lennart Wieboldt
lennart.1997@gmx.de

2017-07-25T22:39:58+00:00

6da3de27be0a477a40104f6eaadcf6707c55fd56

am: e1332dd01b

Change-Id: I193d86abf96e64b29efc7266f4fa3a26b5d2b3af





am: e1332dd01b

Change-Id: I193d86abf96e64b29efc7266f4fa3a26b5d2b3af







Merge "Remove LOCAL_CLANG and clang: true" am: 80ec81cf4b am: f7b315c985
2017-07-25T22:35:56+00:00

Lennart Wieboldt
lennart.1997@gmx.de

2017-07-25T22:35:56+00:00

e1332dd01b48bb4996e2f28f41c349d11280afba

am: 8a8b97b271

Change-Id: I7e691abe2e2ccec5d9477c528d603c081c0a5661





am: 8a8b97b271

Change-Id: I7e691abe2e2ccec5d9477c528d603c081c0a5661