kernel_replicant_linux, branch replicant-11

net: usb: sipc_hsic: fix crash

2022-02-08T08:50:48+00:00

If the device is disconnected, we need to make sure that ep->in_urb is
not used otherwise we can have a use after free:
    ------------[ cut here ]------------
    WARNING: CPU: 2 PID: 5464 at lib/refcount.c:28 refcount_warn_saturate+0x60/0x134
    refcount_t: underflow; use-after-free.
    CPU: 2 PID: 5464 Comm: ipc-modem Not tainted 5.10.70-977921-g2f5a453af3fc-dirty #77
    Hardware name: Samsung Exynos (Flattened Device Tree)
    Backtrace:
    [] (dump_backtrace) from [] (show_stack+0x18/0x1c)
     r7:00000009 r6:60000013 r5:00000000 r4:c0eae790
    [] (show_stack) from [] (dump_stack+0x90/0xac)
    [] (dump_stack) from [] (__warn+0xac/0xd4)
     r7:00000009 r6:c3355c34 r5:00000000 r4:00000009
    [] (__warn) from [] (warn_slowpath_fmt+0x80/0xbc)
     r6:c03d282c r5:0000001c r4:c0bbea9c
    [] (warn_slowpath_fmt) from [] (refcount_warn_saturate+0x60/0x134)
     r8:c0e95dd0 r7:00000000 r6:00000000 r5:c0e95d98 r4:c5327d80
    [] (refcount_warn_saturate) from [] (usb_free_urb+0x6c/0x70)
    [] (usb_free_urb) from [] (sipc_disconnect+0x60/0x68)
     r5:c0e95d98 r4:c5327c40
    [] (sipc_disconnect) from [] (usb_unbind_interface+0x8c/0x1e4)
     r7:00000000 r6:c3564800 r5:00000000 r4:c3564020
    [] (usb_unbind_interface) from [] (device_release_driver_internal+0xc0/0x1b0)
     r10:c35648bc r9:c0beeea9 r8:c0eb5780 r7:00000000 r6:c0e95dd0 r5:00000000
     r4:c3564020
    [] (device_release_driver_internal) from [] (device_release_driver+0x18/0x1c)
     r7:00000000 r6:c0e96124 r5:c1c39030 r4:c3564020
    [] (device_release_driver) from [] (bus_remove_device+0xe4/0x120)
    [] (bus_remove_device) from [] (device_del+0x19c/0x370)
     r7:00000000 r6:c3564878 r5:c0e8e8f4 r4:c3564020
    [] (device_del) from [] (usb_disable_device+0x158/0x19c)
     r10:c35648bc r9:c0beeea9 r8:c0eb5780 r7:00000000 r6:00000000 r5:c3564000
     r4:c3564800
    [] (usb_disable_device) from [] (usb_disconnect+0x98/0x1dc)
     r9:c34cc800 r8:00000000 r7:00000000 r6:c3564878 r5:00000000 r4:c3564800
    [] (usb_disconnect) from [] (usb_disconnect+0x1bc/0x1dc)
     r10:c34cccbc r9:c3355e20 r8:00000000 r7:c35cec00 r6:c34ccc78 r5:00000001
     r4:c34ccc00
    [] (usb_disconnect) from [] (usb_remove_hcd+0xd0/0x1d4)
     r10:00000004 r9:c3354000 r8:00000000 r7:c161d454 r6:00000001 r5:c2c44cc0
     r4:c2c44c00
    [] (usb_remove_hcd) from [] (store_ehci_power+0x84/0x18c)
     r6:00000002 r5:c161d410 r4:c2c44c00
    [] (store_ehci_power) from [] (dev_attr_store+0x1c/0x28)
     r8:c33c1710 r7:c3355f00 r6:c33c1700 r5:c3d0d4c0 r4:c05dc51c
    [] (dev_attr_store) from [] (sysfs_kf_write+0x40/0x4c)
     r5:c3d0d4c0 r4:c04bc31c
    [] (sysfs_kf_write) from [] (kernfs_fop_write_iter+0xec/0x1ac)
     r5:c3d0d4c0 r4:00000002
    [] (kernfs_fop_write_iter) from [] (vfs_write+0x1a8/0x204)
     r8:beb948d8 r7:00000000 r6:c3355f58 r5:c367b600 r4:00000002
    [] (vfs_write) from [] (ksys_write+0x7c/0xd0)
     r8:00000002 r7:c3355f64 r6:c3355f58 r5:beb948d8 r4:c367b600
    [] (ksys_write) from [] (sys_write+0x10/0x14)
     r8:c0100264 r7:00000004 r6:00000000 r5:beb948d8 r4:00000004
    [] (sys_write) from [] (__sys_trace_return+0x0/0x1c)
    Exception stack(0xc3355fa8 to 0xc3355ff0)
    5fa0:                   00000004 beb948d8 00000004 beb948d8 00000002 00000000
    5fc0: 00000004 beb948d8 00000000 00000004 b6f40550 b6c32328 00452960 00464000
    5fe0: b6eed0ac beb948c0 b6ecc028 b6f01100
    ---[ end trace 9e1c4c0c71f8dda6 ]---

Signed-off-by: Denis 'GNUtoo' Carikli

net: usb: sipc_hsic: style cleanup

2022-02-08T08:49:55+00:00

Signed-off-by: Denis 'GNUtoo' Carikli

net: usb: sipc_hsic: disconnect: remove usb_driver_release_interface

2022-02-07T14:41:04+00:00

usb_driver_release_interface does nothing when called from disconnect().

Signed-off-by: Denis 'GNUtoo' Carikli

build.sh: use CONFIG_LOCALVERSION_AUTO

2022-01-28T13:08:21+00:00

Signed-off-by: Denis 'GNUtoo' Carikli

Revert "ARM: replicant_defconfig: Add vertical-720x1280 logo for midas"

2021-12-06T17:29:14+00:00

Since we now managed to make the bootanimation program display the
Replicant logo, we can disable that configuration, to save some space
in the BOOT and RECOVERY partitions.

This reverts commit 7f13dccb4de933a6a5e8c2aad9a4feabae58e736.

Signed-off-by: Denis 'GNUtoo' Carikli

build.sh: disable boot cursor

2021-11-29T13:11:24+00:00

We now have a logo at boot, so we don't need to display a blinking
cursor anymore.

Signed-off-by: Denis 'GNUtoo' Carikli

ARM: config: disable boot cursor

2021-11-29T13:11:23+00:00

We now have a logo at boot, so we don't need to display a blinking
cursor anymore.

Signed-off-by: Denis 'GNUtoo' Carikli

ARM: replicant_defconfig: Add vertical-720x1280 logo for midas

2021-11-29T13:11:23+00:00

Signed-off-by: Denis 'GNUtoo' Carikli

video/logo: Add Replicant logos

2021-11-29T13:06:52+00:00

For some reason, the bootanimation program runs during boot but it
doesn't display anything on the screen.

I've tried to run it at very early boot by using init=/path/to/bash.
While it's possible to use a bash built with Guix, we then end up
being unable to run Android utilities because for some reason apexd
refuses to run (it probably need to be able to get/set properties to
run).

And without apexd we can't run most binaries (including
/system/bin/sh, /system/xbin/bash or bootanimation).

As bootanimation seems to require surfaceflinger, I've tried to
disable the com.android.systemui after boot but I didn't manage to do
it in a way that enabled me to launch bootanimation.

Remains the debug through prints or LOG statements, but that will
probably take a long time to do, so in the meantime I'm adding the
Replicant logo to the kernel.

The images have been taken from tests/linux-boot-logos/ in the
vendor/replicant/artwork repository[1][2] at the commit
6135d3a081a5abda8ffb603cfdd370ea3c2f8b1f (scripts: linux-boot-logos:
rename the output files).

I don't know if Linux is capable of finding the logo that is best
suited for the display resolution and orientation. If not that
makes the kernel device specific. While the bootanimation.zip is
device specific, the kernel takes way longer to rebuild than just
copying a zip file.

In addition adding logos inside the kernel takes some precious space
so at the end it's probably way better to have the boot logo be
completely in userspace.

[1]https://git.replicant.us/infrastructure/replicant_artwork
[2]Note that this repository might move to
   https://git.replicant.us/replicant/vendor_replicant_artwork
   in the future.

Signed-off-by: Denis 'GNUtoo' Carikli

ARM: replicant_recovery_defconfig: Remove unused 8250 options

2021-11-26T17:45:08+00:00

While CONFIG_SERIAL_8250 is required for CONFIG_SERIAL_SAMSUNG,
not all the CONFIG_SERIAL_8250 options are needed.

This should potentially reduce the size of the kernel image and
live us more room for other drivers or for more things in the
recovery initramfs.

Signed-off-by: Denis 'GNUtoo' Carikli