diff options
| author | rago <rago@google.com> | 2016-10-07 18:13:29 -0700 |
|---|---|---|
| committer | Jessica Wagantall <jwagantall@cyngn.com> | 2016-12-09 10:41:29 -0800 |
| commit | 5063771777f8a833874e82612ddbf3d45ea20a04 (patch) | |
| tree | fd30a53f97bd7a5cde86f8845b4fd0d4b079ff96 | |
| parent | 83b1ab83b4505d27a9c7a6f90c31bc788dd435ab (diff) | |
| download | hardware_qcom_audio-stable/cm-13.0-caf-8996-ZNH2K.tar.gz hardware_qcom_audio-stable/cm-13.0-caf-8996-ZNH2K.tar.bz2 hardware_qcom_audio-stable/cm-13.0-caf-8996-ZNH2K.zip | |
Fix potential NULL dereference in Visualizer effectstable/cm-13.0-caf-8996-ZNH2K
Bug: 30229821
CYNGNOS-3312
Test: fixing CL. Existing unit tests still pass.
Change-Id: I73d3fe413dd7590470c5b3b19569d6a7969c4dd8
(cherry picked from commit 0c39abc483ba980f7c417e57a0aa39139136c97a)
| -rw-r--r-- | visualizer/offload_visualizer.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/visualizer/offload_visualizer.c b/visualizer/offload_visualizer.c index 0db8498a..ca976fe6 100644 --- a/visualizer/offload_visualizer.c +++ b/visualizer/offload_visualizer.c @@ -894,9 +894,13 @@ int visualizer_command(effect_context_t * context, uint32_t cmdCode, uint32_t cm case VISUALIZER_CMD_MEASURE: { if (pReplyData == NULL || replySize == NULL || *replySize < (sizeof(int32_t) * MEASUREMENT_COUNT)) { - ALOGV("%s VISUALIZER_CMD_MEASURE error *replySize %d <" - "(sizeof(int32_t) * MEASUREMENT_COUNT) %d", - __func__, *replySize, sizeof(int32_t) * MEASUREMENT_COUNT); + if (replySize == NULL) { + ALOGV("%s VISUALIZER_CMD_MEASURE error replySize NULL", __func__); + } else { + ALOGV("%s VISUALIZER_CMD_MEASURE error *replySize %u <" + "(sizeof(int32_t) * MEASUREMENT_COUNT) %zu", + __func__, *replySize, sizeof(int32_t) * MEASUREMENT_COUNT); + } android_errorWriteLog(0x534e4554, "30229821"); return -EINVAL; } |